From: "Longpeng (Mike)" <longpeng2@huawei.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
luonengjun@huawei.com, mst@redhat.com, cornelia.huck@de.ibm.com,
stefanha@redhat.com, denglingli@chinamobile.com,
Jani.Kokkonen@huawei.com, Ola.Liljedahl@arm.com,
Varun.Sethi@freescale.com, xin.zeng@intel.com,
brian.a.keating@intel.com, liang.j.ma@intel.com,
john.griffin@intel.com, weidong.huang@huawei.com, agraf@suse.de,
jasowang@redhat.com, vincent.jardin@6wind.com,
arei.gonglei@huawei.com, wangxinxin.wang@huawei.com,
jianjay.zhou@huawei.com
Subject: Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification
Date: Mon, 11 Dec 2017 20:56:07 +0800 [thread overview]
Message-ID: <5A2E8067.4050000@huawei.com> (raw)
In-Reply-To: <0209e49f-3d81-cbc9-eb07-13654a288a22@linux.vnet.ibm.com>
On 2017/12/6 19:01, Halil Pasic wrote:
>
>
> On 12/06/2017 08:37 AM, Longpeng(Mike) wrote:
>> +\field{outcome_len} is the size of struct virtio_crypto_session_input or
>> +ZERO for the session-destroy operation.
>
> This ain't correct. It should have been something like virtio_crypto_destroy_session_input.
>
Hi Halil,
I already fixed this just now.
Do you have any other comments on v22 ? I'll send v23 tomorrow if no. :)
--
Regards,
Longpeng(Mike)
>> +
>> +
>> +\paragraph{Session operation}\label{sec:Device Types / Crypto Device / Device
>> +Operation / Control Virtqueue / Session operation}
>> +
>> +The session is a handle which describes the cryptographic parameters to be
>> +applied to a number of buffers.
>> +
>> +The following structure stores the result of session creation set by the device:
>> +
>> +\begin{lstlisting}
>> +struct virtio_crypto_session_input {
>> + /* Device write only portion */
>> + le64 session_id;
>> + le32 status;
>> + le32 padding;
>> +};
>> +\end{lstlisting}
>> +
>> +A request to destroy a session includes the following information:
>> +
>> +\begin{lstlisting}
>> +struct virtio_crypto_destroy_session_flf {
>> + /* Device read only portion */
>> + le64 session_id;
>> + /* Device write only portion */
>
> This is the device writable portion and thus what we cal op_outcome above.
> So it should have been
> };
>
>
> struct virtio_crypto_destroy_session_input {
>> + le32 status;
>> + le32 padding;
>> +};
>
> If we aren't consistent about it the dividing into parts (like op specific
> fixed and variable length (output) fields, operation outcome (input))
> isn't really helpful.
>
>
> Regards,
> Halil
>> +\end{lstlisting}
>
>
> .
>
--
Regards,
Longpeng(Mike)
next prev parent reply other threads:[~2017-12-11 12:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 7:37 [Qemu-devel] [v22 0/2] virtio-crypto: virtio crypto device specification Longpeng(Mike)
2017-12-06 7:37 ` [virtio-dev] " Longpeng(Mike)
2017-12-06 7:37 ` [Qemu-devel] [v22 1/2] virtio-crypto: Add " Longpeng(Mike)
2017-12-06 11:01 ` Halil Pasic
2017-12-06 11:01 ` [virtio-dev] " Halil Pasic
2017-12-07 7:59 ` Gonglei (Arei)
2017-12-07 7:59 ` [virtio-dev] " Gonglei (Arei)
2017-12-11 12:56 ` Longpeng (Mike) [this message]
2017-12-11 13:54 ` Halil Pasic
2017-12-11 13:54 ` [virtio-dev] " Halil Pasic
2017-12-11 14:09 ` Michael S. Tsirkin
2017-12-11 14:09 ` [virtio-dev] " Michael S. Tsirkin
2017-12-11 15:41 ` Halil Pasic
2017-12-11 15:41 ` [virtio-dev] " Halil Pasic
2017-12-18 8:43 ` [Qemu-devel] [virtio-dev] " Longpeng (Mike)
2017-12-18 12:29 ` Halil Pasic
2017-12-18 12:29 ` [virtio-dev] " Halil Pasic
2017-12-18 13:51 ` Michael S. Tsirkin
2017-12-18 13:51 ` [virtio-dev] " Michael S. Tsirkin
2017-12-18 15:27 ` Halil Pasic
2017-12-18 15:27 ` [virtio-dev] " Halil Pasic
2017-12-23 9:11 ` [Qemu-devel] [virtio-dev] " Longpeng (Mike)
2017-12-20 16:44 ` [Qemu-devel] " Halil Pasic
2017-12-20 16:44 ` [virtio-dev] " Halil Pasic
2017-12-30 7:57 ` Longpeng (Mike)
2018-01-03 20:43 ` Halil Pasic
2018-01-03 20:43 ` [virtio-dev] " Halil Pasic
2018-01-04 8:55 ` [Qemu-devel] [virtio-dev] " Longpeng (Mike)
2018-01-04 8:55 ` [virtio-dev] Re: [Qemu-devel] " Longpeng (Mike)
2017-12-06 7:37 ` [Qemu-devel] [v22 2/2] virtio-crypto: Add conformance clauses Longpeng(Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A2E8067.4050000@huawei.com \
--to=longpeng2@huawei.com \
--cc=Jani.Kokkonen@huawei.com \
--cc=Ola.Liljedahl@arm.com \
--cc=Varun.Sethi@freescale.com \
--cc=agraf@suse.de \
--cc=arei.gonglei@huawei.com \
--cc=brian.a.keating@intel.com \
--cc=cornelia.huck@de.ibm.com \
--cc=denglingli@chinamobile.com \
--cc=jasowang@redhat.com \
--cc=jianjay.zhou@huawei.com \
--cc=john.griffin@intel.com \
--cc=liang.j.ma@intel.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vincent.jardin@6wind.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=xin.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.