All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Maya Erez <qca_merez@qca.qualcomm.com>,
	Kalle Valo <kvalo@codeaurora.org>
Cc: Dedy Lansky <qca_dlansky@qca.qualcomm.com>,
	linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com
Subject: Re: [PATCH 1/9] wil6210: support Scheduled scan
Date: Wed, 13 Dec 2017 09:58:47 +0100	[thread overview]
Message-ID: <5A30EBC7.6060401@broadcom.com> (raw)
In-Reply-To: <1513105442-28041-2-git-send-email-qca_merez@qca.qualcomm.com>

On 12/12/2017 8:03 PM, Maya Erez wrote:
> From: Dedy Lansky <qca_dlansky@qca.qualcomm.com>
>
> Add support for sched_scan_start/stop by sending PNO commands to FW.
> Driver reports WIPHY_FLAG_SUPPORTS_SCHED_SCAN and invokes
> cfg80211_sched_scan_results upon receiving
> WMI_SCHED_SCAN_RESULT_EVENTID from FW.

The commit message triggered me as the wiphy flag mentioned no longer 
exists. Looking further into the patch it looks fine to me, but the flag 
needs to be removed from the commit message.

> Signed-off-by: Dedy Lansky <qca_dlansky@qca.qualcomm.com>
> Signed-off-by: Maya Erez <qca_merez@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/wil6210/cfg80211.c |  65 ++++++++
>   drivers/net/wireless/ath/wil6210/main.c     |   8 +
>   drivers/net/wireless/ath/wil6210/wil6210.h  |   4 +
>   drivers/net/wireless/ath/wil6210/wmi.c      | 239 +++++++++++++++++++++++++++-
>   drivers/net/wireless/ath/wil6210/wmi.h      |  99 +++++++++---
>   5 files changed, 395 insertions(+), 20 deletions(-)

[...]

> diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
> index 8ace618..ed7cdb7 100644
> --- a/drivers/net/wireless/ath/wil6210/wmi.c
> +++ b/drivers/net/wireless/ath/wil6210/wmi.c

[...]

> @@ -658,8 +669,6 @@ static void wmi_evt_rx_mgmt(struct wil6210_priv *wil, int id, void *d, int len)
>   		wil_hex_dump_wmi("IE ", DUMP_PREFIX_OFFSET, 16, 1, ie_buf,
>   				 ie_len, true);
>
> -		wil_dbg_wmi(wil, "Capability info : 0x%04x\n", cap);
> -

This does not seem related.

>   		bss = cfg80211_inform_bss_frame(wiphy, channel, rx_mgmt_frame,
>   						d_len, signal, GFP_KERNEL);
>   		if (bss) {

[...]

> diff --git a/drivers/net/wireless/ath/wil6210/wmi.h b/drivers/net/wireless/ath/wil6210/wmi.h
> index d9e220a..7c6ac9c 100644
> --- a/drivers/net/wireless/ath/wil6210/wmi.h
> +++ b/drivers/net/wireless/ath/wil6210/wmi.h

[...]

> +/* WMI_START_SCHED_SCAN_EVENTID */
> +enum pno_result {
> +	PNO_SUCCESS		= 0x00,
> +	PNO_REJECT		= 0x01,
> +	PNO_INVALID_PARAMETERS	= 0x02,
> +	PNO_NOT_ENABLED		= 0x03,
> +};

Maybe good to stick with 'wmi_' for types defined in this file, ie. 
wmi_pno_result. Preferably also the enum values, but throughout the file 
I see instances with 'WMI_' prefix and without.

> +
> +struct wmi_start_sched_scan_event {
> +	/* pno_result */
> +	u8 result;
> +	u8 reserved[3];
> +} __packed;
> +
> +struct wmi_stop_sched_scan_event {
> +	/* pno_result */
> +	u8 result;
> +	u8 reserved[3];
> +} __packed;

Regards,
Arend

  reply	other threads:[~2017-12-13  8:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 19:03 [PATCH 0/9] wil6210 patches Maya Erez
2017-12-12 19:03 ` [PATCH 1/9] wil6210: support Scheduled scan Maya Erez
2017-12-13  8:58   ` Arend van Spriel [this message]
2017-12-12 19:03 ` [PATCH 2/9] wil6210: support 40bit DMA addresses Maya Erez
2017-12-12 19:03 ` [PATCH 3/9] wil6210: add platform capabilities bitmap Maya Erez
2017-12-12 19:03 ` [PATCH 4/9] wil6210: set platform features based on FW capabilities Maya Erez
2017-12-12 19:03 ` [PATCH 5/9] wil6210: prevent parallel suspend and dump collection Maya Erez
2017-12-12 19:03 ` [PATCH 6/9] wil6210: add support for headroom configuration Maya Erez
2017-12-12 19:04 ` [PATCH 7/9] wil6210: configurable broadcast TX MCS Maya Erez
2017-12-12 19:04 ` [PATCH 8/9] wil6210: remove leftover "FIXME"s Maya Erez
2017-12-12 19:04 ` [PATCH 9/9] wil6210: remove reference to preset_chandef Maya Erez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A30EBC7.6060401@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=qca_dlansky@qca.qualcomm.com \
    --cc=qca_merez@qca.qualcomm.com \
    --cc=wil6210@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.