From: "Jan Beulich" <JBeulich@suse.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 4/6] x86/shadow: widen reference count
Date: Wed, 13 Dec 2017 02:17:42 -0700 [thread overview]
Message-ID: <5A30FE4602000078001970F3@prv-mh.provo.novell.com> (raw)
In-Reply-To: <22f1a542-107e-2010-8857-1929beb95a4b@citrix.com>
>>> On 12.12.17 at 17:32, <george.dunlap@citrix.com> wrote:
>> @@ -82,7 +153,7 @@ struct page_info
>> unsigned long type:5; /* What kind of shadow is this? */
>> unsigned long pinned:1; /* Is the shadow pinned? */
>> unsigned long head:1; /* Is this the first page of the shadow? */
>> -#define PAGE_SH_REFCOUNT_WIDTH 25
>> +#define PAGE_SH_REFCOUNT_WIDTH (PGT_count_width - 7)
>> unsigned long count:PAGE_SH_REFCOUNT_WIDTH; /* Reference count */
>> } sh;
It is this use of PGT_count_width ...
> What's the point of moving this code? And are there any important changes?
... which requires the move. I thought that would be clear enough.
> It would be a lot easier to review if you separated code motion from
> code changes; but if you don't want to do that, you need to make it
> clear what you're doing in your changelog.
I've added
"Note that the first and last hunks of the xen/include/asm-x86/mm.h
change are merely code motion."
to the description; I don't think separating out that change would
make review any easier (you either trust the code-motion-only
statement, or you want to compare both blocks, regardless of
whether this was a separate patch).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2017-12-13 9:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 14:53 [PATCH 0/6] XSA-248...251 follow-up Jan Beulich
2017-12-12 15:04 ` [PATCH 1/6] x86/shadow: drop further 32-bit relics Jan Beulich
2017-12-20 8:03 ` Tim Deegan
2017-12-12 15:05 ` [PATCH 2/6] x86/shadow: remove pointless loops over all vCPU-s Jan Beulich
2017-12-20 8:06 ` Tim Deegan
2017-12-12 15:06 ` [PATCH 3/6] x86/shadow: ignore sh_pin() failure in one more case Jan Beulich
2017-12-20 8:08 ` Tim Deegan
2017-12-12 15:07 ` [PATCH 4/6] x86/shadow: widen reference count Jan Beulich
2017-12-12 16:32 ` George Dunlap
2017-12-13 9:17 ` Jan Beulich [this message]
2017-12-13 10:32 ` George Dunlap
2017-12-13 14:20 ` Jan Beulich
2017-12-20 8:08 ` Tim Deegan
2017-12-12 15:08 ` [PATCH 5/6] x86/mm: clean up SHARED_M2P{,_ENTRY} uses Jan Beulich
2017-12-12 17:50 ` [PATCH 5/6] x86/mm: clean up SHARED_M2P{, _ENTRY} uses George Dunlap
2017-12-13 9:30 ` Jan Beulich
2017-12-18 16:56 ` Jan Beulich
2017-12-20 8:09 ` Tim Deegan
2017-12-12 15:09 ` [PATCH 6/6] x86: use paging_mark_pfn_dirty() Jan Beulich
2017-12-20 8:10 ` Tim Deegan
2017-12-20 9:37 ` [PATCH v2 0/3] XSA-248...251 follow-up Jan Beulich
2017-12-20 9:40 ` [PATCH v2 1/3] x86/shadow: widen reference count Jan Beulich
2017-12-20 9:41 ` [PATCH v2 2/3] x86/mm: clean up SHARED_M2P{, _ENTRY} uses Jan Beulich
2018-02-08 12:31 ` George Dunlap
2017-12-20 9:42 ` [PATCH v2 3/3] x86: use paging_mark_pfn_dirty() Jan Beulich
2017-12-20 9:44 ` Paul Durrant
2018-02-08 12:32 ` George Dunlap
2018-02-07 15:27 ` Ping: [PATCH v2 0/3] XSA-248...251 follow-up Jan Beulich
2018-02-08 12:34 ` George Dunlap
2018-02-13 7:44 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A30FE4602000078001970F3@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.