From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82127C433F5 for ; Mon, 4 Apr 2022 19:53:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CBFA6B0071; Mon, 4 Apr 2022 15:53:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07C3F6B0073; Mon, 4 Apr 2022 15:53:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEAB16B0074; Mon, 4 Apr 2022 15:53:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id D020B6B0071 for ; Mon, 4 Apr 2022 15:53:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 869A7183E9043 for ; Mon, 4 Apr 2022 19:53:16 +0000 (UTC) X-FDA: 79320245592.24.7CFAD09 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2054.outbound.protection.outlook.com [40.107.95.54]) by imf09.hostedemail.com (Postfix) with ESMTP id EAFAB140039 for ; Mon, 4 Apr 2022 19:53:15 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2vxLHsG1R50In1N7ukeMUuCvOCAN/da223m6QoCYObHmDqCJVUwyT5oYARGI6QDCCFEQDPp9Pve2l+CZYKOLZvjIz9PC88czniY+HJ36HlNmvLxYsc67ykbxiPJnubhygHBSzNc52Vm/oSsZjeUsFtmQrqrqfVJcvzdyFirNiVVa/kXobx4REAMxtgDxQ/iCX/uPrwwMytRYIP/R66WSIGurju1P+euvpaPF/AAzg1H4tfHZFfYWdNnqtL0TSNrID3xoeSBmRaFt/d2aYV1sS+XPFMnE6GUZs6Px6seSOP5/8tqIRWc52MfHZJiF0FvGQgIHjykFA3WCQHBJ/PI1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ywHsIApW0WL49oTiAzqIQbP76rk1iFmRhMg9dxJzPXo=; b=TBuVidvF0vykXt9wGCiuHhSWHpSTvmBD5NXvZbyAi+usiZFg+FyXmjQbDlxdfwMPlM/pp5c1M4BZHqJFXXI5gAMtj6kM5uQsWyz3NPgmkohu541pAhbAWEKoZzvwXgIyYZdmkgjpl1TIWWedReEEu/omNv1MkZiL+JIF4cLZJNK9ZeuwIMYhd7ByUK+NVIsGtVS4GiC5L1HBsjBd7LTy+4lCVCVtCfXRRPEZilsfRAGATb1O5K8t2v5GChaNVcQv+kJeayq73k83DPDLKJMni5pJIBjbfDQ17yDbdxUS7JqMpEg0bjDcd4i+4G9mFWdWLM+LADfyL+JL9ibK4xZ5LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ywHsIApW0WL49oTiAzqIQbP76rk1iFmRhMg9dxJzPXo=; b=fuuCRs/hbII+Zq/xx7WgTKMEU+SDS4/T04/EhkuSFEAkaaNgyKC+l05cHOgsfmHl3rxypjjIoWFSLy93qeDJyKja/STZPSfWRaCYZlPWDis5TwRAh3x54wpkIJ9Xq36G5z0t1Q9RNeAV8D1X3u/2SzSrm6XpipkNG95KRHgFkPXMsuvrhoVNhpJhXe9rGjWF+LxsD/+7gVR0BsVOldtUfVpT0vmJTAtyCYqyqXeFwSzI1BZM7FEgEZZBAg7+czvSRLCJ4N97H02iBGq9RW1oxqOaV5ynN7FR7j/mw5bF21gSh4jOSOeiZnxlDLa0tp+K/6B6VxzqHy5+8f7UyZ7TrA== Received: from MN2PR12MB3823.namprd12.prod.outlook.com (2603:10b6:208:168::26) by DM6PR12MB2618.namprd12.prod.outlook.com (2603:10b6:5:49::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 19:53:13 +0000 Received: from MN2PR12MB3823.namprd12.prod.outlook.com ([fe80::69f1:dff6:826b:7d9c]) by MN2PR12MB3823.namprd12.prod.outlook.com ([fe80::69f1:dff6:826b:7d9c%5]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 19:53:13 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 0/4] Alternative fixes for migration Date: Mon, 04 Apr 2022 15:53:11 -0400 X-Mailer: MailMate (1.14r5870) Message-ID: <5A32BE86-B8EF-4526-AF6D-18A53608DBF4@nvidia.com> In-Reply-To: <20220404193006.1429250-1-willy@infradead.org> References: <20220404193006.1429250-1-willy@infradead.org> Content-Type: multipart/signed; boundary="=_MailMate_919CE3A4-65C3-4EC4-A9A7-607B5F4C5495_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: MN2PR15CA0053.namprd15.prod.outlook.com (2603:10b6:208:237::22) To MN2PR12MB3823.namprd12.prod.outlook.com (2603:10b6:208:168::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6be89dde-a3a6-4bbc-c8ee-08da1674c0d1 X-MS-TrafficTypeDiagnostic: DM6PR12MB2618:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ed5ukiU3Ku77+QeQvWMi2D7FriZA5UoIbdQJOqOBmUctSP1u6xv12vt+/KGx13m3WxO07t2N9QYl/ApgJkDjjEAtaEMEHsgzOXOXBhhr1VYnd3VQ7VSOfVkdrAOrabKPuERABOqy1cnArf5IU1cAa8jRbv/SBthlMdHElGSU794xkewylsWnsyhf2d3mE3YFHxDyicyD2m/DbZz2kc9o7qKyc9aEuu9ulM6Ie9QMzm7qADrvXvMWTW5BKEk2YmnR2eNjYy12D6W2QVx8Y4P4VcblEJPboeCWTvEFbvvsywGXOHpC0O4mHYkfQhzcEVsUhyvChCc1vdPDNBaJT2BOc2R8ZWVxZstka9AEXEa1rou+g0B/Vgk4/EcGY8+2gEA+BfKC4deGyF9Bub6txSd/bCnmnjERFJvn1w3Ghj8tFKvooWfJ3Pf2luDS+eIk8lb/NpPQolhwOjq4fHZePNJBWPZxNxlImwmO0eHpAh+zn6kz8hyr2L0WtBmxY/faE+D6yTrqN7yySG49+Y6PsJyCijY36Y1NzYQeo7QjghQG4sEJGh+ugq4R/46fPwYNhKQezLu5MMja3yMNs7m+fikwmYOSnOfVUL1M/6ax95vZ0F022LhKMZrBucxnOdWsXdXZ5wyaX6p9lePTraW85odLtMqnYYLBPL6+gp9kCi+nvQPaodbonPn6GdzJMvcKygnOzfaBS0+6vMlLAHk5ZSj4nqNmAS4e+7jHI3gnlgGDI4g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3823.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(235185007)(8936002)(2616005)(6512007)(2906002)(26005)(186003)(53546011)(38100700002)(6506007)(86362001)(316002)(66946007)(66556008)(66476007)(83380400001)(4326008)(6916009)(8676002)(36756003)(6486002)(21480400003)(508600001)(33656002)(72826004)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g9CdoLZZq3w4xIipd7HPlSUMqoMrND8Jhd9/SKBN85/LlNL7f0w0Q5VuTNdP?= =?us-ascii?Q?mOpwDGpMa4pEiBpr9LeZALI18r3QSLDZmD7bwvlWrpc2JKDQe3+3po0G6SPi?= =?us-ascii?Q?d7Xd4Vn7wCiJSRpDIB/qngcoIsgU4RzXusngOEukSLMiC2kdtqYAhXHloAax?= =?us-ascii?Q?IbgDkYQQaBW2s/1Nd5HCpbIRUlrapQJe5TcQxTllciyY619zOzD0A/yLqDpR?= =?us-ascii?Q?ke9R90vm9bIE5eDzWWboFPU398vSWaB329y+zqvb/x0DOGQp4kBTNml5R4su?= =?us-ascii?Q?Rxc2tgelYdjVADupAQSvmSVD4OkJbEoHj9ULLIH7oZffRh9IpgeXfx4Qu2uy?= =?us-ascii?Q?N154o4v7Cep2mY2e5LlKfOBcE+p94ACb5O2YW4Bh+TtMisIqzx048VVp0S/6?= =?us-ascii?Q?ssCCSLJ6CxHWDsJkb4iQPIxgOsTmiXoCwoniABXD3HMTGJMD+rHndkh1tIv4?= =?us-ascii?Q?GPdhWRIK9bONQ2CuqgUYGWYZEZkjKBIk9PNoPybxFyBzEk2dl2OI24Wd8+06?= =?us-ascii?Q?ityA6AHOC20UMZABvgaVsExSyhLzXzQxfOieKJSFdWPiZ+ltZodIJcVj+vCb?= =?us-ascii?Q?OCA+VOFInidZDf7tJjTgdspQSJLhEjy3vTpHwwu5GyLJZF2Qu82VRjsfuuAr?= =?us-ascii?Q?sxgaUmV9e8C0aQcI1wQoc3mxwDY5YTqvr+pFXYQaehYRJEKstthHTTGu+nSC?= =?us-ascii?Q?QbvML4oDSxwj9DjlbbwGYG7lJ90qu66Pyz78Fw2r/DjvjglGuCYrcgkYhPJ3?= =?us-ascii?Q?g6mXjruAZeiO20xiiOG/Isj9Z7mFu5OAkQruxQJBI7r4cqRvDqgvrvmV8rTK?= =?us-ascii?Q?Oxk4KYwkRevTMRdkHOvs4MRtE5lS2AM0n44jD5GARoVu3eFuoQVWhzeZ1Ug4?= =?us-ascii?Q?EcCiArws1n/gdRMbUcrGaJWOgAZ+iLnJhyY1QWswjgPmutLnBreArl2gy3Bf?= =?us-ascii?Q?v9GA33E/9AqOYZ4+Lui+bGGRzsVrQ5OyV3RMFR+kh8UxvhhG4rMO3j154S5X?= =?us-ascii?Q?6l3ETkI6x9uvAApBQVlfahccdugLpjbhXtzH0CpQyJPlWsVB1fqu9YvwBcz2?= =?us-ascii?Q?f70gwbSpcyZMNxS95wZpqV3FouQ1FGCXPPJKrgNLNKKJtEBWrf7MXCt6fbHy?= =?us-ascii?Q?OLcBZQBTm2SWIh2GbYg39qtBRRrBHc2Edz8O7TOYLdXrTaJFKXI7/Xqyj98v?= =?us-ascii?Q?gtLqevxR55D2WMXBZYiYpaDrBwY/KLRyAPfR/L0hefit4yt3SVabANxbqYys?= =?us-ascii?Q?OXjh/kg2lspt69b1KmPsiKQwWK0MXA085ZHw8eG9fiOHi0Q8kaOzhxOADw2/?= =?us-ascii?Q?dGnB0DOe1+SkZ3/WjXBgc5xxrEeVZ2tcWOLFcmrcI8LKYkvOjcUKrcDt6AwD?= =?us-ascii?Q?iIsGZmyNw9v3SqPl9fKKVXjkddw+RtHBmqJve2uFj0dDZF2C1cdISvExdxIE?= =?us-ascii?Q?+dh19kXsOW5WksrSuEq7YooQxfVIYi3DpRqXiOO5DT0xH8nVSaTxaLbllZ8a?= =?us-ascii?Q?P9IFcp7wSXwgFQfxrozjrS0T6sUI97/v8KLtHwNP7x/S0Zwhodz3pZ62UPzn?= =?us-ascii?Q?WKCUH/24cJfddbYtP70g+Sh75Trgo5DeLs351kyz/x6eFa3r0LBMExPSdOBZ?= =?us-ascii?Q?FqIlfvTzlGFotWizNnH36P+rTiFo5pg1N6AwOq4CEBYZhFosOXn9rdQGHX6o?= =?us-ascii?Q?wClsaLheXW226ehBs0Vf9WHrwa6+py6N7VD2fKoHApwD6n8wnVtMRDxz7HW/?= =?us-ascii?Q?aEwD/RKYnQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6be89dde-a3a6-4bbc-c8ee-08da1674c0d1 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 19:53:13.4275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CmZ38MnM/sWbodAvnF5zfAYCJ4F+9lO503UxDOc2NX3xV5XG26LiwsmFZU/Okcgz X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2618 X-Rspam-User: X-Stat-Signature: yi7193xk1kniqiy9oz873rrzzra6p4w5 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="fuuCRs/h"; spf=none (imf09.hostedemail.com: domain of ziy@nvidia.com has no SPF policy when checking 40.107.95.54) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EAFAB140039 X-HE-Tag: 1649101995-888660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_919CE3A4-65C3-4EC4-A9A7-607B5F4C5495_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 4 Apr 2022, at 15:30, Matthew Wilcox (Oracle) wrote: > I heartily endorse Zi Yan's minimal fixes. These patches, drawn from > my development tree and with absolutely no testing, are a different > approach to fixing the problem. I would have submitted these patches > earlier if I'd known they were needed. > > I think migrate_misplaced_transhuge_page() may be missing from Zi's > patch, but maybe filesystem pages can't end up in that path? Anyway, > let me know if you like these patches better. Yeah, I thought numa faulting only works on anonymous pages. I was wrong. > > Matthew Wilcox (Oracle) (4): > mm/migrate: Use a folio in alloc_migration_target() > mm/migrate: Use a folio in migrate_misplaced_transhuge_page() > mm: Add vma_alloc_folio() > mm/mempolicy: Use vma_alloc_folio() in new_page() > > include/linux/gfp.h | 8 +++-- > mm/mempolicy.c | 38 +++++++++++++-------- > mm/migrate.c | 80 +++++++++++++++------------------------------= > 3 files changed, 56 insertions(+), 70 deletions(-) > > -- = > 2.34.1 The whole series looks good to me. My patch can be dropped. Thanks. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi --=_MailMate_919CE3A4-65C3-4EC4-A9A7-607B5F4C5495_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmJLTKgPHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhU4+EP/iXOvtxiJzogLl6J9ZPQlJtRY6Th8UCETVAo YW8mTvjzhwalakJty7rvMY1fSBzyEXZ1ym5IutPEGYGT6gBiXX8LcO8qww1ZgEAS trz8crx8+IoBCXe7VZHO3GxmVigswsqJxcME912q1qVp2uIp9TQYsjkZaWnZpZfi 0LnLO1gYB45Hg77isEqU4fQErGi0ervHmkugYCvgbkkuPr441GuXqFMdy8M8G0FY 1wjN16RHUss9P+iCwGC1kmRgWjhyTsyCl37r+XmqXft035LWXy2SmKk6URKVot7R igAxfx/pEU/o9F6pKenbHt5D1ExBZYSc+GE8k0Ts8Tj8yaHKTHgiisKJ+qjcGT+n s0RwbJkXmzqgpHCnkGfgb1EI2X+93WUG2ZtD3UeyjvhCazZALJJrN9IB2ij0hxkL 0DOCVsjCwt/KjNztXSaxzSJ3feaeJ3OF7iiMESzM81ESWffC3Lay1qFskFrtpnD2 elWK/Ob8GYXRZ8L0NV5iJPJFrkr56PHIzyFW+saIhAUXDAGHjTdwgfqRXsRR/TsS LJjC5ivTJs/rvRPpkGGbLksScYCGfAhUMaJ4tsweqHYD8xaNi6JaTpphRdeKQjhX 0dLDdCOV7LSmvrhyoXTLBaBjuuVk5N5UYDjXMQlimFwLRxCqxyptq63SNSPmSpDa Zyj93Avy =bUqX -----END PGP SIGNATURE----- --=_MailMate_919CE3A4-65C3-4EC4-A9A7-607B5F4C5495_=--