From: Zhoujie Wu <zjwu@marvell.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Nadav Haklai <nadavh@marvell.com>, Victor Gu <xigu@marvell.com>,
xswang@marvell.com, Wilson Ding <dingwei@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Hanna Hawa <hannah@marvell.com>,
hongd@marvell.com, Doug Jones <dougj@marvell.com>,
Ryan Gao <ygao@marvell.com>, "Wei(SOCP) Liu" <liuw@marvell.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [EXT] Re: [PATCH v2] mmc: sdhci: wait 5ms after set 1.8V signal enable
Date: Thu, 14 Dec 2017 11:04:28 -0800 [thread overview]
Message-ID: <5A32CB3C.4060105@marvell.com> (raw)
In-Reply-To: <CAPDyKFp=B2EBBOVky=x89Bcqw77XZyXcW1Hyn_LEHOkhtyAyFA@mail.gmail.com>
Hi Ulf,
On 12/14/2017 12:41 AM, Ulf Hansson wrote:
> External Email
>
> ----------------------------------------------------------------------
> On 14 December 2017 at 00:48, Zhoujie Wu <zjwu@marvell.com> wrote:
>> According to SD spec 3.00 3.6.1 signal voltage switch
>> procedure, host should wait 5ms after set 1.8V signal
>> enable bit in Host Control 2 register and check if 1.8V
>> is stable or not.
>>
> The core already deals with this. See mmc_set_uhs_voltage() and
> mmc_host_set_uhs_voltage().
>
> We even have a retry mechanism in place.
I checked these functions, they just make sure when do signal voltage
switch, gate the clock to SD card 5ms and wait 1ms before check data lines.
This patch is following below spec requirement when switching signal
voltage to 1.8V, wait 5ms after set 1.8V signal Enable bit in Host
control 2 register.
Current code will set 1.8V Signal Enable bit and check if this bit is
cleared by host right after that, the bit is not cleared and host
report "1.8V regulator output did not became stable".
You can find the steps at SD spec 3.0 3.6.1.
(6) Set 1.8V Signal Enable in the Host Control 2 register.
(7) Wait 5ms. 1.8V voltage regulator shall be stable within this period.
(8) If 1.8V Signal Enable is cleared by Host Controller, go to step (12).
>
>> On some cards, found without the delay would see "1.8V
>> regulator output did not became stable" err log.
> Seems like you need to fix the regulator instead.
>
> BTW, is this a regression? No?
It is not regulator related, the regulator already output 1.8V and add
delay after regulator set voltage didn't help.
The only solution is to add 5ms after set 1.8V signal enable bit .
Not a regression issue, we recently found it when enabling uhs on some
platforms since they didn't enable it previously.
>
> [...]
>
> Kind regards
> Uffe
next prev parent reply other threads:[~2017-12-14 19:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 23:48 [PATCH v2] mmc: sdhci: wait 5ms after set 1.8V signal enable Zhoujie Wu
2017-12-14 8:41 ` Ulf Hansson
2017-12-14 19:04 ` Zhoujie Wu [this message]
2017-12-15 7:05 ` [EXT] " Ulf Hansson
2017-12-15 18:53 ` Zhoujie Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A32CB3C.4060105@marvell.com \
--to=zjwu@marvell.com \
--cc=adrian.hunter@intel.com \
--cc=dingwei@marvell.com \
--cc=dougj@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=hannah@marvell.com \
--cc=hongd@marvell.com \
--cc=kostap@marvell.com \
--cc=linux-mmc@vger.kernel.org \
--cc=liuw@marvell.com \
--cc=nadavh@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
--cc=xigu@marvell.com \
--cc=xswang@marvell.com \
--cc=ygao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.