From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH v2 2/2] x86/p2m: force return value checking of p2m_set_entry() Date: Wed, 20 Dec 2017 02:35:34 -0700 Message-ID: <5A3A3CF60200007800198C9F@prv-mh.provo.novell.com> References: <5A25364E0200007800194503@prv-mh.provo.novell.com> <5A3A3A7C0200007800198C85@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRami-0001Xx-2F for xen-devel@lists.xenproject.org; Wed, 20 Dec 2017 09:35:32 +0000 In-Reply-To: <5A3A3A7C0200007800198C85@prv-mh.provo.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: xen-devel Cc: George Dunlap , Andrew Cooper , Kevin Tian , Jun Nakajima List-Id: xen-devel@lists.xenproject.org QXMgWFNBcyAyNDYgYW5kIDI0NyBoYXZlIHNob3duLCBub3QgZG9pbmcgc28gaXMgcmF0aGVyIGRh bmdlcm91cy4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4K QWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmll d2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KCi0tLSBhL3hlbi9hcmNo L3g4Ni9tbS9wMm0uYworKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMKQEAgLTE1NTAsOSArMTU1 MCwxMSBAQCB2b2lkIHAybV9tZW1fcGFnaW5nX3BvcHVsYXRlKHN0cnVjdCBkb21hCiAgICAgICAg IGlmICggcDJtdCA9PSBwMm1fcmFtX3BhZ2luZ19vdXQgKQogICAgICAgICAgICAgcmVxLnUubWVt X3BhZ2luZy5mbGFncyB8PSBNRU1fUEFHSU5HX0VWSUNUX0ZBSUw7CiAKLSAgICAgICAgcDJtX3Nl dF9lbnRyeShwMm0sIGdmbiwgbWZuLCBQQUdFX09SREVSXzRLLCBwMm1fcmFtX3BhZ2luZ19pbiwg YSk7CisgICAgICAgIHJjID0gcDJtX3NldF9lbnRyeShwMm0sIGdmbiwgbWZuLCBQQUdFX09SREVS XzRLLCBwMm1fcmFtX3BhZ2luZ19pbiwgYSk7CiAgICAgfQogICAgIGdmbl91bmxvY2socDJtLCBn Zm4sIDApOworICAgIGlmICggcmMgPCAwICkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLyogUGF1 c2UgZG9tYWluIGlmIHJlcXVlc3QgY2FtZSBmcm9tIGd1ZXN0IGFuZCBnZm4gaGFzIHBhZ2luZyB0 eXBlICovCiAgICAgaWYgKCBwMm1faXNfcGFnaW5nKHAybXQpICYmIHYtPmRvbWFpbiA9PSBkICkK QEAgLTE3MDAsMTAgKzE3MDIsMTIgQEAgdm9pZCBwMm1fbWVtX3BhZ2luZ19yZXN1bWUoc3RydWN0 IGRvbWFpbgogICAgICAgICAgKi8KICAgICAgICAgaWYgKCBtZm5fdmFsaWQobWZuKSAmJiAocDJt dCA9PSBwMm1fcmFtX3BhZ2luZ19pbikgKQogICAgICAgICB7Ci0gICAgICAgICAgICBwMm1fc2V0 X2VudHJ5KHAybSwgZ2ZuLCBtZm4sIFBBR0VfT1JERVJfNEssCi0gICAgICAgICAgICAgICAgICAg ICAgICAgIHBhZ2luZ19tb2RlX2xvZ19kaXJ0eShkKSA/IHAybV9yYW1fbG9nZGlydHkgOgotICAg ICAgICAgICAgICAgICAgICAgICAgICBwMm1fcmFtX3J3LCBhKTsKLSAgICAgICAgICAgIHNldF9n cGZuX2Zyb21fbWZuKG1mbl94KG1mbiksIGdmbl94KGdmbikpOworICAgICAgICAgICAgaW50IHJj ID0gcDJtX3NldF9lbnRyeShwMm0sIGdmbiwgbWZuLCBQQUdFX09SREVSXzRLLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBwYWdpbmdfbW9kZV9sb2dfZGlydHkoZCkgPyBwMm1f cmFtX2xvZ2RpcnR5IDoKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX3Jh bV9ydywgYSk7CisKKyAgICAgICAgICAgIGlmICggIXJjICkKKyAgICAgICAgICAgICAgICBzZXRf Z3Bmbl9mcm9tX21mbihtZm5feChtZm4pLCBnZm5feChnZm4pKTsKICAgICAgICAgfQogICAgICAg ICBnZm5fdW5sb2NrKHAybSwgZ2ZuLCAwKTsKICAgICB9CkBAIC0yNDYzLDkgKzI0NjcsOSBAQCBz dGF0aWMgdm9pZCBwMm1fcmVzZXRfYWx0cDJtKHN0cnVjdCBwMm1fCiAgICAgcDJtLT5tYXhfcmVt YXBwZWRfZ2ZuID0gMDsKIH0KIAotdm9pZCBwMm1fYWx0cDJtX3Byb3BhZ2F0ZV9jaGFuZ2Uoc3Ry dWN0IGRvbWFpbiAqZCwgZ2ZuX3QgZ2ZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQgcGFnZV9vcmRlciwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHAybV90eXBlX3QgcDJtdCwgcDJtX2FjY2Vzc190IHAybWEpCitpbnQg cDJtX2FsdHAybV9wcm9wYWdhdGVfY2hhbmdlKHN0cnVjdCBkb21haW4gKmQsIGdmbl90IGdmbiwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQg cGFnZV9vcmRlciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX3R5cGVfdCBw Mm10LCBwMm1fYWNjZXNzX3QgcDJtYSkKIHsKICAgICBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtOwog ICAgIHAybV9hY2Nlc3NfdCBhOwpAQCAtMjQ3NCw5ICsyNDc4LDEwIEBAIHZvaWQgcDJtX2FsdHAy bV9wcm9wYWdhdGVfY2hhbmdlKHN0cnVjdAogICAgIHVuc2lnbmVkIGludCBpOwogICAgIHVuc2ln bmVkIGludCByZXNldF9jb3VudCA9IDA7CiAgICAgdW5zaWduZWQgaW50IGxhc3RfcmVzZXRfaWR4 ID0gfjA7CisgICAgaW50IHJldCA9IDA7CiAKICAgICBpZiAoICFhbHRwMm1fYWN0aXZlKGQpICkK LSAgICAgICAgcmV0dXJuOworICAgICAgICByZXR1cm4gMDsKIAogICAgIGFsdHAybV9saXN0X2xv Y2soZCk7CiAKQEAgLTI1MTUsMTcgKzI1MjAsMjUgQEAgdm9pZCBwMm1fYWx0cDJtX3Byb3BhZ2F0 ZV9jaGFuZ2Uoc3RydWN0CiAgICAgICAgICAgICAgICAgICAgIHAybV91bmxvY2socDJtKTsKICAg ICAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgICAgICBnb3RvIG91dDsKKyAgICAgICAgICAg ICAgICByZXQgPSAwOworICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAg ICAgICB9CiAgICAgICAgIGVsc2UgaWYgKCAhbWZuX2VxKG0sIElOVkFMSURfTUZOKSApCi0gICAg ICAgICAgICBwMm1fc2V0X2VudHJ5KHAybSwgZ2ZuLCBtZm4sIHBhZ2Vfb3JkZXIsIHAybXQsIHAy bWEpOworICAgICAgICB7CisgICAgICAgICAgICBpbnQgcmMgPSBwMm1fc2V0X2VudHJ5KHAybSwg Z2ZuLCBtZm4sIHBhZ2Vfb3JkZXIsIHAybXQsIHAybWEpOworCisgICAgICAgICAgICAvKiBCZXN0 IGVmZm9ydDogRG9uJ3QgYmFpbCBvbiBlcnJvci4gKi8KKyAgICAgICAgICAgIGlmICggIXJldCAp CisgICAgICAgICAgICAgICAgcmV0ID0gcmM7CisgICAgICAgIH0KIAogICAgICAgICBfX3B1dF9n Zm4ocDJtLCBnZm5feChnZm4pKTsKICAgICB9CiAKLSBvdXQ6CiAgICAgYWx0cDJtX2xpc3RfdW5s b2NrKGQpOworCisgICAgcmV0dXJuIHJldDsKIH0KIAogLyoqKiBBdWRpdCAqKiovCi0tLSBhL3hl bi9hcmNoL3g4Ni9tbS9wMm0tZXB0LmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS1lcHQuYwpA QCAtOTA0LDcgKzkwNCwxMSBAQCBvdXQ6CiAgICAgICAgIGVwdF9mcmVlX2VudHJ5KHAybSwgJm9s ZF9lbnRyeSwgdGFyZ2V0KTsKIAogICAgIGlmICggZW50cnlfd3JpdHRlbiAmJiBwMm1faXNfaG9z dHAybShwMm0pICkKLSAgICAgICAgcDJtX2FsdHAybV9wcm9wYWdhdGVfY2hhbmdlKGQsIF9nZm4o Z2ZuKSwgbWZuLCBvcmRlciwgcDJtdCwgcDJtYSk7CisgICAgeworICAgICAgICByZXQgPSBwMm1f YWx0cDJtX3Byb3BhZ2F0ZV9jaGFuZ2UoZCwgX2dmbihnZm4pLCBtZm4sIG9yZGVyLCBwMm10LCBw Mm1hKTsKKyAgICAgICAgaWYgKCAhcmMgKQorICAgICAgICAgICAgcmMgPSByZXQ7CisgICAgfQog CiAgICAgcmV0dXJuIHJjOwogfQotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5oCisrKyBi L3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTY4OSw4ICs2ODksOSBAQCB2b2lkIHAybV9m cmVlX3B0cChzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtCiAKIC8qIERpcmVjdGx5IHNldCBhIHAybSBl bnRyeTogb25seSBmb3IgdXNlIGJ5IHAybSBjb2RlLiBEb2VzIG5vdCBuZWVkCiAgKiBhIGNhbGwg dG8gcHV0X2dmbiBhZnRlcndhcmRzLyAqLwotaW50IHAybV9zZXRfZW50cnkoc3RydWN0IHAybV9k b21haW4gKnAybSwgZ2ZuX3QgZ2ZuLCBtZm5fdCBtZm4sCi0gICAgICAgICAgICAgICAgICB1bnNp Z25lZCBpbnQgcGFnZV9vcmRlciwgcDJtX3R5cGVfdCBwMm10LCBwMm1fYWNjZXNzX3QgcDJtYSk7 CitpbnQgX19tdXN0X2NoZWNrIHAybV9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4gKnAybSwg Z2ZuX3QgZ2ZuLCBtZm5fdCBtZm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IHBhZ2Vfb3JkZXIsIHAybV90eXBlX3QgcDJtdCwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBwMm1fYWNjZXNzX3QgcDJtYSk7CiAKIC8qIFNldCB1cCBmdW5jdGlvbiBw b2ludGVycyBmb3IgUFQgaW1wbGVtZW50YXRpb246IG9ubHkgZm9yIHVzZSBieSBwMm0gY29kZSAq LwogZXh0ZXJuIHZvaWQgcDJtX3B0X2luaXQoc3RydWN0IHAybV9kb21haW4gKnAybSk7CkBAIC04 MzAsOSArODMxLDkgQEAgaW50IHAybV9jaGFuZ2VfYWx0cDJtX2dmbihzdHJ1Y3QgZG9tYWluCiAg ICAgICAgICAgICAgICAgICAgICAgICAgIGdmbl90IG9sZF9nZm4sIGdmbl90IG5ld19nZm4pOwog CiAvKiBQcm9wYWdhdGUgYSBob3N0IHAybSBjaGFuZ2UgdG8gYWxsIGFsdGVybmF0ZSBwMm0ncyAq Lwotdm9pZCBwMm1fYWx0cDJtX3Byb3BhZ2F0ZV9jaGFuZ2Uoc3RydWN0IGRvbWFpbiAqZCwgZ2Zu X3QgZ2ZuLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZuX3QgbWZuLCB1bnNp Z25lZCBpbnQgcGFnZV9vcmRlciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAy bV90eXBlX3QgcDJtdCwgcDJtX2FjY2Vzc190IHAybWEpOworaW50IHAybV9hbHRwMm1fcHJvcGFn YXRlX2NoYW5nZShzdHJ1Y3QgZG9tYWluICpkLCBnZm5fdCBnZm4sCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIG1mbl90IG1mbiwgdW5zaWduZWQgaW50IHBhZ2Vfb3JkZXIsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV90eXBlX3QgcDJtdCwgcDJtX2FjY2Vzc190 IHAybWEpOwogCiAvKgogICogcDJtIHR5cGUgdG8gSU9NTVUgZmxhZ3MKCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==