From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755931AbeARO64 (ORCPT ); Thu, 18 Jan 2018 09:58:56 -0500 Received: from regular1.263xmail.com ([211.150.99.131]:33476 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755828AbeARO6x (ORCPT ); Thu, 18 Jan 2018 09:58:53 -0500 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: will.deacon@arm.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <188cc1d5cf68a6f41e7604e16e81cef8> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5A60B60F.6040602@rock-chips.com> Date: Thu, 18 Jan 2018 22:58:23 +0800 From: JeffyChen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Will Deacon , Joerg Roedel CC: linux-kernel@vger.kernel.org, jcliang@chromium.org, tfiga@chromium.org, iommu@lists.linux-foundation.org, Robin Murphy Subject: Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones References: <20180103060920.23475-1-jeffy.chen@rock-chips.com> <20180117132808.s5henw63oseg3ufd@8bytes.org> <20180118144118.GA12394@arm.com> In-Reply-To: <20180118144118.GA12394@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, Thanks for your reply. On 01/18/2018 10:41 PM, Will Deacon wrote: >> > >> >Makes sense to me, but I'd like to have an OK from Robin or Will (added >> >to Cc) before applying this. > I don't think this patch makes a lot of sense in isolation: the SMMU drivers > themselves will likely still probe, and it's unclear what we should about > DMA when an IOMMU is not deemed to be available. See: > > https://patchwork.kernel.org/patch/9681211/ > > Jeffy -- are you solving a real issue here, or is this just an attempt at > some cleanup? hmmm, it's just a cleanup, but it seems like we already removed this of_iommu_init_fn in: b0c560f7d8a4 iommu: Clean up of_iommu_init_fn so this patch can be disregarded too :) > > Will > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: JeffyChen Subject: Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones Date: Thu, 18 Jan 2018 22:58:23 +0800 Message-ID: <5A60B60F.6040602@rock-chips.com> References: <20180103060920.23475-1-jeffy.chen@rock-chips.com> <20180117132808.s5henw63oseg3ufd@8bytes.org> <20180118144118.GA12394@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180118144118.GA12394-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Will Deacon , Joerg Roedel Cc: jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Will, Thanks for your reply. On 01/18/2018 10:41 PM, Will Deacon wrote: >> > >> >Makes sense to me, but I'd like to have an OK from Robin or Will (added >> >to Cc) before applying this. > I don't think this patch makes a lot of sense in isolation: the SMMU drivers > themselves will likely still probe, and it's unclear what we should about > DMA when an IOMMU is not deemed to be available. See: > > https://patchwork.kernel.org/patch/9681211/ > > Jeffy -- are you solving a real issue here, or is this just an attempt at > some cleanup? hmmm, it's just a cleanup, but it seems like we already removed this of_iommu_init_fn in: b0c560f7d8a4 iommu: Clean up of_iommu_init_fn so this patch can be disregarded too :) > > Will > > >