From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: AndrewCooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 5/9] x86: relocate pvh_info
Date: Fri, 19 Jan 2018 03:07:18 -0700 [thread overview]
Message-ID: <5A61D16602000078001A042A@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20180118181652.26397-6-wei.liu2@citrix.com>
>>> On 18.01.18 at 19:16, <wei.liu2@citrix.com> wrote:
> Modify early boot code to relocate pvh info as well, so that we can be
> sure __va in __start_xen works.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one cosmetic request:
> @@ -29,6 +29,10 @@ asm (
> #include "../../../include/xen/multiboot.h"
> #include "../../../include/xen/multiboot2.h"
>
> +#ifdef CONFIG_PVH_GUEST
> +#include <public/arch-x86/hvm/start_info.h>
> +#endif
Would you mind moving the #include ...
> @@ -71,6 +75,38 @@ static u32 copy_string(u32 src)
> return copy_mem(src, p - src + 1);
> }
>
> +#ifdef CONFIG_PVH_GUEST
> +static struct hvm_start_info *pvh_info_reloc(u32 in)
... above this line, to avoid the duplicate #ifdef?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-19 10:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 18:16 [PATCH 0/9] Fix and improvements to pvshim Wei Liu
2018-01-18 18:16 ` [PATCH 1/9] Update shim.config Wei Liu
2018-01-18 18:26 ` Andrew Cooper
2018-01-18 18:28 ` Wei Liu
2018-01-18 18:30 ` Andrew Cooper
2018-01-19 10:16 ` Roger Pau Monné
2018-01-18 18:16 ` [PATCH 2/9] libxl: remove whitespaces introduced in 62982da926 Wei Liu
2018-01-19 10:18 ` Roger Pau Monné
2018-01-18 18:16 ` [PATCH 3/9] x86/guest: clean up guest/xen.h Wei Liu
2018-01-18 18:26 ` Andrew Cooper
2018-01-19 10:21 ` Roger Pau Monné
2018-01-19 12:22 ` Wei Liu
2018-01-19 12:29 ` Roger Pau Monné
2018-01-19 12:34 ` Wei Liu
2018-01-18 18:16 ` [PATCH 4/9] Remove sched=null from shim cmdline and doc Wei Liu
2018-01-18 18:27 ` Andrew Cooper
2018-01-19 10:28 ` Roger Pau Monné
2018-01-19 11:40 ` Wei Liu
2018-01-18 18:16 ` [PATCH 5/9] x86: relocate pvh_info Wei Liu
2018-01-19 10:07 ` Jan Beulich [this message]
2018-01-19 10:10 ` Andrew Cooper
2018-01-19 10:20 ` Jan Beulich
2018-01-19 10:53 ` Roger Pau Monné
2018-01-19 11:48 ` Jan Beulich
2018-01-18 18:16 ` [PATCH 6/9] Revert "x86/boot: Map more than the first 16MB" Wei Liu
2018-01-19 10:07 ` Jan Beulich
2018-01-18 18:16 ` [PATCH 7/9] libxl: lower shim related message to level info Wei Liu
2018-01-19 10:57 ` Roger Pau Monné
2018-01-18 18:16 ` [PATCH 8/9] xen/consoled: discard NUL from guest Wei Liu
2018-01-19 11:03 ` Roger Pau Monné
2018-01-19 15:25 ` Wei Liu
2018-01-18 18:16 ` [PATCH 9/9] x86/shim: pass through vcpu runstate to L0 Xen Wei Liu
2018-01-19 11:18 ` Roger Pau Monné
2018-01-19 15:18 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A61D16602000078001A042A@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.