From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] x86: fix GET_STACK_END
Date: Thu, 25 Jan 2018 03:55:49 -0700 [thread overview]
Message-ID: <5A69C5C502000078001A24C3@prv-mh.provo.novell.com> (raw)
In-Reply-To: <c5e997370c234c448f2aedf406e515e2@AMSPEX02CL02.citrite.net>
>>> On 24.01.18 at 21:48, <Andrew.Cooper3@citrix.com> wrote:
> From: Wei Liu [wei.liu2@citrix.com]
> Sent: 24 January 2018 20:26
>
> AIUI the purpose of having the .if directive is to make GET_STACK_END
> work with any general purpose registers. The code as-is would produce
> the wrong result for r8. Fix it.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Oops. Acked-by: Andrew Cooper ≤andrew.cooper3@citrix.com≥
Oops indeed - luckily the build would have failed in such a case,
rather than producing a broken binary.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-01-25 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 20:26 [PATCH] x86: fix GET_STACK_END Wei Liu
2018-01-24 20:48 ` Andrew Cooper
2018-01-25 10:55 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A69C5C502000078001A24C3@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.