All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Wang <wei.w.wang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: yang.zhang.wz@gmail.com, virtio-dev@lists.oasis-open.org,
	riel@redhat.com, quan.xu0@gmail.com, kvm@vger.kernel.org,
	mst@redhat.com, nilal@redhat.com, liliang.opensource@gmail.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	pbonzini@redhat.com, mhocko@kernel.org
Subject: Re: [PATCH v25 1/2 RESEND] mm: support reporting free page blocks
Date: Fri, 26 Jan 2018 10:11:34 +0800	[thread overview]
Message-ID: <5A6A8E56.90408__47394.4710138769$1516932557$gmane$org@intel.com> (raw)
In-Reply-To: <20180125144124.7e9f6e2156b1b940b07aecfc@linux-foundation.org>

On 01/26/2018 06:41 AM, Andrew Morton wrote:
> On Thu, 25 Jan 2018 17:38:27 +0800 Wei Wang <wei.w.wang@intel.com> wrote:
>
>> This patch adds support to walk through the free page blocks in the
>> system and report them via a callback function. Some page blocks may
>> leave the free list after zone->lock is released, so it is the caller's
>> responsibility to either detect or prevent the use of such pages.
>>
>> One use example of this patch is to accelerate live migration by skipping
>> the transfer of free pages reported from the guest. A popular method used
>> by the hypervisor to track which part of memory is written during live
>> migration is to write-protect all the guest memory. So, those pages that
>> are reported as free pages but are written after the report function
>> returns will be captured by the hypervisor, and they will be added to the
>> next round of memory transfer.
> It would be useful if we had some quantitative testing results, so we
> can see the real-world benefits from this change?
>

Sure. Thanks for the reminder, I think I'll also attach this to the 
cover letter:

Without this feature, locally live migrating an 8G idle guest takes 
~2286 ms. With this featrue, it takes ~260 ms, which reduces the 
migration time to ~11%.

Idle guest means a guest which doesn't run any specific workloads after 
boots. The improvement depends on how much free memory the guest has, 
idle guest is a good case to show the improvement. From the optimization 
point of view, having something is better than nothing, IMHO. If the 
guest has less free memory, the improvement will be less, but still 
better than no improvement.

Best,
Wei

  reply	other threads:[~2018-01-26  2:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  9:38 [PATCH v25 1/2 RESEND] mm: support reporting free page blocks Wei Wang
2018-01-25  9:38 ` [virtio-dev] " Wei Wang
2018-01-25  9:38 ` Wei Wang
2018-01-25 10:02 ` [virtio-dev] " Wei Wang
2018-01-25 10:02 ` Wei Wang
2018-01-25 10:02   ` Wei Wang
2018-01-25 10:02   ` Wei Wang
2018-01-25 22:41 ` Andrew Morton
2018-01-25 22:41   ` Andrew Morton
2018-01-26  2:11   ` Wei Wang [this message]
2018-01-26  2:11   ` Wei Wang
2018-01-26  2:11     ` [virtio-dev] " Wei Wang
2018-01-26  2:11     ` Wei Wang
2018-01-25 22:41 ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2018-01-25  9:38 Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='5A6A8E56.90408__47394.4710138769$1516932557$gmane$org@intel.com' \
    --to=wei.w.wang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=liliang.opensource@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=nilal@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=quan.xu0@gmail.com \
    --cc=riel@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yang.zhang.wz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.