Re: [PATCH 1/7] x86/alt: Drop unused alternative infrastructure

["Jan Beulich" <JBeulich@suse.com>]

>>> On 12.02.18 at 12:23, <andrew.cooper3@citrix.com> wrote:
> --- a/xen/include/asm-x86/alternative.h
> +++ b/xen/include/asm-x86/alternative.h
> @@ -65,11 +65,6 @@ extern void alternative_instructions(void);
>  	ALTERNATIVE(oldinstr, newinstr1, feature1)			  \
>  	ALTERNATIVE_N(newinstr2, feature2, 2)
>  
> -#define ALTERNATIVE_3(oldinstr, newinstr1, feature1, newinstr2, feature2, \
> -		      newinstr3, feature3)				  \
> -	ALTERNATIVE_2(oldinstr, newinstr1, feature1, newinstr2, feature2) \
> -	ALTERNATIVE_N(newinstr3, feature3, 3)
> -
>  /*
>   * Alternative instructions for different CPU types or capabilities.
>   *

While this one is fine, ...

> @@ -118,26 +113,6 @@ extern void alternative_instructions(void);
>  				   newinstr2, feature2)			\
>  		     : output : input)
>  
> -/*
> - * This is similar to alternative_io. But it has three features and
> - * respective instructions.
> - *
> - * If CPU has feature3, newinstr3 is used.
> - * Otherwise, if CPU has feature2, newinstr2 is used.
> - * Otherwise, if CPU has feature1, newinstr1 is used.
> - * Otherwise, oldinstr is used.
> - */
> -#define alternative_io_3(oldinstr, newinstr1, feature1, newinstr2,	\
> -			 feature2, newinstr3, feature3, output,		\
> -			 input...)					\
> -	asm volatile(ALTERNATIVE_3(oldinstr, newinstr1, feature1,	\
> -				   newinstr2, feature2, newinstr3,	\
> -				   feature3)				\
> -		     : output : input)
> -
> -/* Use this macro(s) if you need more than one output parameter. */
> -#define ASM_OUTPUT2(a...) a

... I'm having patches to post which use both of these, so I'd
very much prefer them to not go away. It is simply a lack of time
which resulted in me not having posted that series already.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel