From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/3] Export TXQ parameters and statistics via nl80211
Date: Wed, 21 Feb 2018 09:56:37 +0100 [thread overview]
Message-ID: <5A8D3445.3040300@broadcom.com> (raw)
In-Reply-To: <20180219170224.14816-1-toke@toke.dk>
On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote:
> This series adds TXQ parameters and statistics that were previously only
> available through debugfs to the nl80211 userspace interface and the
> cfg80211 kernel interface. Patches for iw to print the statistics and
> change the settings are included.
So what is your motivation for having this exposed through nl80211. For
the average end-user the stats and parameters are fairly fuzzy. So can
we expect some manual in which is described what parameter should be
tweaked based on the retrieved statistics.
Also do you intend to remove the debugfs method? Seems a bit redundant
to have two mostly identical interfaces in place.
> Wasn't sure whether to include the updates to nl80211.h in the iw
> patchset, so I didn't :)
Updating the nl80211.h in iw should be done with a copy from the kernel
so it has to wait for the kernel patch to be applied (which tree I am
unsure).
Regards,
Arend
> -Toke
>
>
> Kernel patch:
>
> Toke Høiland-Jørgensen (1):
> cfg80211: Expose TXQ stats and parameters to userspace
>
> include/net/cfg80211.h | 52 +++++++++++++++++++
> include/uapi/linux/nl80211.h | 57 +++++++++++++++++++++
> net/mac80211/cfg.c | 95 +++++++++++++++++++++++++++++++++++
> net/mac80211/ieee80211_i.h | 3 ++
> net/mac80211/main.c | 3 ++
> net/mac80211/sta_info.c | 12 +++++
> net/mac80211/tx.c | 20 ++++++++
> net/wireless/nl80211.c | 115 +++++++++++++++++++++++++++++++++++++++++++
> net/wireless/rdev-ops.h | 12 +++++
> net/wireless/trace.h | 14 ++++++
> 10 files changed, 383 insertions(+)
>
>
> iw patches (updated nl80211.h not included):
>
> Toke Høiland-Jørgensen (2):
> iw: Print TXQ statistics for stations and interfaces
> iw: Add getting and setting of TXQ params for phy
>
> info.c | 3 ++
> interface.c | 6 ++++
> iw.h | 2 ++
> phy.c | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> station.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++-
> 5 files changed, 217 insertions(+), 1 deletion(-)
>
next prev parent reply other threads:[~2018-02-21 8:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 17:02 [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Toke Høiland-Jørgensen
2018-02-19 17:02 ` [PATCH 1/3] cfg80211: Expose TXQ stats and parameters to userspace Toke Høiland-Jørgensen
2018-05-07 19:13 ` Johannes Berg
2018-05-07 21:19 ` Toke Høiland-Jørgensen
2018-05-07 21:20 ` Johannes Berg
2018-05-08 10:18 ` Toke Høiland-Jørgensen
2018-05-08 10:18 ` Johannes Berg
2018-05-08 10:19 ` Johannes Berg
2018-05-08 10:23 ` Toke Høiland-Jørgensen
2018-05-08 10:21 ` Johannes Berg
2018-02-19 17:02 ` [PATCH 2/3] iw: Print TXQ statistics for stations and interfaces Toke Høiland-Jørgensen
2018-05-07 21:21 ` Johannes Berg
2018-05-07 21:30 ` Toke Høiland-Jørgensen
2018-02-19 17:02 ` [PATCH 3/3] iw: Add getting and setting of TXQ params for phy Toke Høiland-Jørgensen
2018-02-21 8:56 ` Arend van Spriel [this message]
2018-02-21 11:00 ` [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Toke Høiland-Jørgensen
2018-02-21 19:53 ` Arend van Spriel
2018-02-22 10:11 ` Toke Høiland-Jørgensen
2018-02-22 10:18 ` [PATCH v2] iw: Print TXQ statistics for stations and interfaces Toke Høiland-Jørgensen
2018-04-19 9:20 ` [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Toke Høiland-Jørgensen
2018-04-19 9:52 ` Johannes Berg
2018-04-19 10:30 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A8D3445.3040300@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.