From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 0/5] x86: improve PDX <-> PFN and alike translations
Date: Mon, 05 Mar 2018 01:37:31 -0700 [thread overview]
Message-ID: <5A9D0FDB02000078001AE664@prv-mh.provo.novell.com> (raw)
In-Reply-To: <94e4562c-90fe-0cd4-ea5f-4c5c568a5023@citrix.com>
>>> On 28.02.18 at 17:47, <andrew.cooper3@citrix.com> wrote:
> On 28/02/18 13:51, Jan Beulich wrote:
>> 1: remove page.h and processor.h inclusion from asm_defns.h
>> 2: use PDEP for PTE flags insertion when available
>> 3: use PDEP/PEXT for maddr/direct-map-offset conversion when available
>> 4: use PDEP/PEXT for PFN/PDX conversion when available
>> 5: use MOV for PFN/PDX conversion when possible
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>
> Ah - so this was the series you were on about which would have an
> interesting time in combination with my nop autosizing.
>
> Do you have performance numbers for these changes? I can certainly see
> the attraction of using BMI2 when available, but do the associated costs
> on incompatible hardware worth it? I'm thinking specifically of turning
> all this inline bit manipulation into function calls? (I genuinely
> don't know the answer, and it might be entirely fine, but I'm concerned
> about whether it may not be).
Btw, before you voice any performance concerns for older
hardware, please take into consideration the last patch of the
series, which converts the CALL to MOV on virtually all
hardware (as mentioned on some older thread I'm not sure the
hardware/firmware that this PDX/PFN conversion was written
for has ever made it to any customers).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-05 8:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 13:51 [PATCH 0/5] x86: improve PDX <-> PFN and alike translations Jan Beulich
2018-02-28 13:56 ` [PATCH 1/5] x86: remove page.h and processor.h inclusion from asm_defns.h Jan Beulich
2018-02-28 13:57 ` [PATCH 2/5] x86: use PDEP for PTE flags insertion when available Jan Beulich
2018-02-28 13:57 ` [PATCH 3/5] x86: use PDEP/PEXT for maddr/direct-map-offset conversion " Jan Beulich
2018-02-28 13:58 ` [PATCH 4/5] x86: use PDEP/PEXT for PFN/PDX " Jan Beulich
2018-02-28 14:35 ` Jan Beulich
2018-02-28 13:59 ` [PATCH 5/5] x86: use MOV for PFN/PDX conversion when possible Jan Beulich
2018-02-28 16:47 ` [PATCH 0/5] x86: improve PDX <-> PFN and alike translations Andrew Cooper
2018-03-01 7:22 ` Jan Beulich
2018-03-05 8:37 ` Jan Beulich [this message]
2018-03-06 8:45 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A9D0FDB02000078001AE664@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.