All of lore.kernel.org
 help / color / mirror / Atom feed
From: JeffyChen <jeffy.chen@rock-chips.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, briannorris@google.com,
	heiko@sntech.de, dtor@google.com, dianders@google.com,
	devicetree@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Joseph Lo <josephl@nvidia.com>, stephen lu <lumotuwe@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	linux-input@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Arvind Yadav <arvind.yadav.cs@gmail.com>
Subject: Re: [PATCH v5 1/3] Input: gpio-keys - add support for wakeup event action
Date: Mon, 12 Mar 2018 18:40:54 +0800	[thread overview]
Message-ID: <5AA65936.7040500@rock-chips.com> (raw)
In-Reply-To: <20180310181509.GB260013@dtor-ws>

Hi Dmitry,

Thanks for your reply.

On 03/11/2018 02:15 AM, Dmitry Torokhov wrote:>> +static int 
gpio_keys_enable_wakeup(struct gpio_button_data *bdata)
 > These new helpers need to be __maybe_unused in case we compile on system
 > without suspend support.
 >
 > I also wanted a bit more of error handling, so I ended up with the
 > version of the patch below. Can you please try it and let me know if I
 > broke it.

sure, the patch you sent works :)

Tested-by: Jeffy Chen <jeffy.chen@rock-chips.com>

 >
 > Thanks.
 >
 > -- Dmitry
 >
 > Input: gpio-keys - add support for wakeup event action
 >
 > From: Jeffy Chen <jeffy.chen@rock-chips.com>
 >
 > Add support for specifying event actions to trigger wakeup when using
 > the gpio-keys input device as a wakeup source.
 >
 > This would allow the device to configure when to wakeup the system. For
 > example a gpio-keys input device for pen insert, may only want to wakeup
 > the system when ejecting the pen.
 >
 > Suggested-by: Brian Norris <briannorris@chromium.org>
 > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
 > Reviewed-by: Rob Herring <robh@kernel.org>
 > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

  parent reply	other threads:[~2018-03-12 10:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  7:32 [PATCH v5 0/3] gpio-keys: Add support for specifying wakeup event action Jeffy Chen
2018-03-08  7:32 ` Jeffy Chen
2018-03-08  7:32 ` Jeffy Chen
2018-03-08  7:32 ` [PATCH v5 1/3] Input: gpio-keys - add support for " Jeffy Chen
2018-03-09 23:27   ` Rob Herring
2018-03-10 18:11     ` Dmitry Torokhov
2018-03-10 18:15   ` Dmitry Torokhov
2018-03-10 18:32     ` Andy Shevchenko
2018-03-12 10:40     ` JeffyChen [this message]
2018-03-08  7:32 ` [PATCH v5 2/3] Input: gpio-keys - allow setting wakeup event action in DT Jeffy Chen
2018-03-08  7:42 ` [PATCH v5 3/3] arm64: dts: rockchip: kevin: Avoid wakeup when inserting the pen Jeffy Chen
2018-03-08  7:42   ` Jeffy Chen
2018-03-08  7:42   ` Jeffy Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AA65936.7040500@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=briannorris@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=josephl@nvidia.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lumotuwe@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=pombredanne@nexb.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.