From: "Jan Beulich" <JBeulich@suse.com>
To: Anoob Soman <anoob.soman@citrix.com>
Cc: andrew.cooper3@citrix.com, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file
Date: Fri, 16 Mar 2018 05:26:04 -0600 [thread overview]
Message-ID: <5AABB7DC02000078001B2B48@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1521135113-3764-6-git-send-email-anoob.soman@citrix.com>
>>> On 15.03.18 at 18:31, <anoob.soman@citrix.com> wrote:
> --- a/tools/firmware/hvmloader/config.h
> +++ b/tools/firmware/hvmloader/config.h
> @@ -33,6 +33,11 @@ struct bios_config {
> void (*create_mp_tables)(void);
> void (*create_smbios_tables)(void);
> void (*create_pir_tables)(void);
> +
> + /* Physical address of iPXE ROM, loaded by domain builder
> + * when using ROMBIOS
> + */
> + unsigned int *ipxe_rom_addresss;
Comment style. And can the pointer be to const?
> @@ -368,7 +370,12 @@ int main(void)
> #ifdef ENABLE_ROMBIOS
> else if ( bios == &rombios_config )
> {
> - bios->bios_load(bios, NULL, 0);
> + ipxe_module = get_module_entry(hvm_start_info, "ipxe");
> +
> + if ( ipxe_module )
> + ipxe_rom_addresss = ipxe_module->paddr;
> +
> + bios->bios_load(bios, (void *)ipxe_rom_addresss, 0);
> }
> #endif
Considering the #ifdef around here - is this whole series an
enhancement for qemu-trad only? I don't think we mean to make
any such enhancements anymore.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-16 11:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 17:31 Make iPXE a standalone ROM Anoob Soman
2018-03-15 17:31 ` [PATCH 1/5] tools/firmware: Build ipxe as " Anoob Soman
2018-03-16 11:18 ` Jan Beulich
2018-03-16 11:21 ` Andrew Cooper
2018-03-18 1:30 ` Doug Goldstein
2018-03-19 7:48 ` Jan Beulich
2018-03-19 13:52 ` Doug Goldstein
2018-03-15 17:31 ` [PATCH 2/5] tools/firmware: #define IPXE_PATH Anoob Soman
2018-03-21 15:18 ` Wei Liu
2018-03-26 15:53 ` Anoob Soman
2018-03-15 17:31 ` [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest Anoob Soman
2018-03-18 1:32 ` Doug Goldstein
2018-03-19 14:31 ` Anoob Soman
2018-03-21 15:17 ` Wei Liu
2018-03-26 15:51 ` Anoob Soman
2018-03-15 17:31 ` [PATCH 4/5] libxl: Load iPXE ROM from a file Anoob Soman
2018-03-18 1:34 ` Doug Goldstein
2018-03-21 15:25 ` Wei Liu
2018-03-26 15:51 ` Anoob Soman
2018-03-15 17:31 ` [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file Anoob Soman
2018-03-16 11:26 ` Jan Beulich [this message]
2018-03-16 11:44 ` Andrew Cooper
2018-03-17 16:54 ` Doug Goldstein
2018-03-19 14:24 ` Anoob Soman
2018-03-19 15:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AABB7DC02000078001B2B48@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anoob.soman@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.