All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Yunhan Wang <yunhanw@google.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: how to add local name in scan response when setting MGMT_ADV_FLAG_LOCAL_NAME in Bluez
Date: Thu, 3 Aug 2017 01:54:56 +0200	[thread overview]
Message-ID: <5AD53E84-B68F-4F00-B0E1-EF555ADCBC91@holtmann.org> (raw)
In-Reply-To: <CALvjcs91hPqUGCGh286U4wDU8rfd1BfMVGHov9o9522MwrNpvw@mail.gmail.com>

Hi Yunnan,

> Thanks for your reply. I think kernel should support scan response
> because I am able to set different local name in scan rsp using hci
> socket instead of Dbus API. Have you ever post your patch or sample
> code in this thread or any other place? May I have a try on your
> patch? It would be doable and useful to put Local name change as
> property, like include tx power, so that we can set it in scan rsp
> when enabling advertisement.

have you actually checked that local name is supported via advertising instances. The Read Advertising Features mgmt command is pretty clear in its description that support for adding local name in scan response is optional. The command is also pretty clear in that if that flag is given, the local name is managed via the kernel and can only be modified via Set Local Name mgmt command. If you want to use any other name in scan response, you need to not specify that flag.

Using raw HCI sockets is like packet injection. That does not count. Also you will never make that work correctly since you essentially by-passing the kernel and programming the hardware directly.

Regards

Marcel


      reply	other threads:[~2017-08-02 23:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01  7:37 how to add local name in scan response when setting MGMT_ADV_FLAG_LOCAL_NAME in Bluez Yunhan Wang
2017-08-01 10:21 ` Luiz Augusto von Dentz
2017-08-01 10:48   ` Luiz Augusto von Dentz
2017-08-01 12:24     ` Luiz Augusto von Dentz
2017-08-01 15:42       ` Yunhan Wang
2017-08-02 23:54         ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AD53E84-B68F-4F00-B0E1-EF555ADCBC91@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=yunhanw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.