From: Ani Sinha <ani.sinha@nutanix.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Igor Mammedov" <imammedo@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses
Date: Wed, 29 Apr 2020 05:59:59 +0000 [thread overview]
Message-ID: <5AD9B19D-EACA-4111-BB5B-78F8378AE93D@nutanix.com> (raw)
In-Reply-To: <20200429011228-mutt-send-email-mst@kernel.org>
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> For example, how about hot-plugging a bridge which doesn't
> support hotplug itself?
So now for every device we want to hot plug, we will add a new bridge? Sounds not a scalable and elegant idea.
> Would that happen to make windows
> do what you want, for both PCI and PCIE? We don't support
> hotplugging bridges with devices behind them ATM, but
> that sounds like a useful option.
>
>
> Also, pcie root ports recently gained ability to disable hotplug, see
> commit 530a0963184e57e71a5b538e9161f115df533e96
> Author: Julia Suvorova <jusual@redhat.com>
> Date: Wed Feb 26 18:46:07 2020 +0100
>
> pcie_root_port: Add hotplug disabling option
>
> adding this to pci and pcie bridges sounds very reasonable.
This patch uses PCIE native hot plug capability to turn on or turn off per slot hot plug option. This does not enable hot unplugging while allowing devices to be hot plugged on a PCIE port. Besides, PCI-PCI bridges already have an option to disable hot plug capability for all the slots of that bridge. My patch follows that approach.
next prev parent reply other threads:[~2020-04-29 6:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 10:16 [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses Ani Sinha
2020-04-28 10:20 ` Ani Sinha
2020-04-28 16:05 ` Michael S. Tsirkin
2020-04-28 16:09 ` Ani Sinha
2020-04-28 16:21 ` Michael S. Tsirkin
2020-04-28 16:40 ` Ani Sinha
2020-04-28 20:45 ` Michael S. Tsirkin
2020-04-29 0:58 ` Ani Sinha
2020-04-29 5:28 ` Michael S. Tsirkin
2020-04-29 5:59 ` Ani Sinha [this message]
2020-04-29 6:11 ` Ani Sinha
2020-04-29 6:52 ` Michael S. Tsirkin
2020-04-29 6:54 ` Ani Sinha
2020-04-29 6:57 ` Michael S. Tsirkin
2020-04-29 7:02 ` Ani Sinha
2020-04-29 7:38 ` Michael S. Tsirkin
2020-04-29 7:43 ` Ani Sinha
2020-04-29 8:09 ` Michael S. Tsirkin
2020-04-29 8:14 ` Ani Sinha
2020-04-29 8:56 ` Michael S. Tsirkin
2020-04-29 9:14 ` Ani Sinha
2020-04-29 9:18 ` Ani Sinha
2020-04-29 10:15 ` Michael S. Tsirkin
2020-04-29 10:20 ` Ani Sinha
2020-04-29 10:30 ` Michael S. Tsirkin
2020-04-29 10:37 ` Ani Sinha
2020-04-30 17:12 ` Ani Sinha
2020-04-28 16:28 ` Daniel P. Berrangé
2020-04-28 16:30 ` Michael S. Tsirkin
2020-04-28 16:33 ` Daniel P. Berrangé
2020-04-28 20:44 ` Michael S. Tsirkin
2020-05-11 18:53 ` Igor Mammedov
2020-05-12 5:26 ` Ani Sinha
2020-05-13 19:43 ` Igor Mammedov
2020-05-15 12:13 ` Ani Sinha
2020-05-20 9:43 ` Igor Mammedow
2020-05-20 9:47 ` Michael S. Tsirkin
2020-05-20 9:56 ` Igor Mammedow
2020-05-20 10:06 ` Daniel P. Berrangé
2020-05-20 11:29 ` Michael S. Tsirkin
2020-05-20 11:42 ` Daniel P. Berrangé
2020-05-20 11:44 ` Michael S. Tsirkin
2020-05-20 10:28 ` Michael S. Tsirkin
2020-05-20 11:05 ` Igor Mammedow
2020-05-20 11:23 ` Michael S. Tsirkin
2020-05-20 12:20 ` Igor Mammedow
2020-05-20 16:13 ` Michael S. Tsirkin
2020-05-21 7:32 ` Igor Mammedow
2020-05-21 10:07 ` Michael S. Tsirkin
2020-05-21 13:23 ` Igor Mammedov
2020-05-21 15:40 ` Laine Stump
2020-05-26 5:32 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AD9B19D-EACA-4111-BB5B-78F8378AE93D@nutanix.com \
--to=ani.sinha@nutanix.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.