From: "Jan Beulich" <JBeulich@suse.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] x86/shutdown: use ACPI reboot method for Dell PowerEdge R540
Date: Mon, 14 May 2018 09:17:02 -0600 [thread overview]
Message-ID: <5AF9A86E02000078001C28D6@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180514110219.24169-1-ross.lagerwall@citrix.com>
>>> On 14.05.18 at 13:02, <ross.lagerwall@citrix.com> wrote:
> When EFI booting the Dell PowerEdge R540 it consistently wanders into
> the weeds and gets an invalid opcode in the EFI ResetSystem call. This
> is the same bug which affects the PowerEdge R740 so fix it in the same
> way: quirk this hardware to use the ACPI reboot method instead.
>
> BIOS Information
> Vendor: Dell Inc.
> Version: 1.3.7
> Release Date: 02/09/2018
> System Information
> Manufacturer: Dell Inc.
> Product Name: PowerEdge R540
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
with a remark:
> --- a/xen/arch/x86/shutdown.c
> +++ b/xen/arch/x86/shutdown.c
> @@ -520,6 +520,15 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740"),
> },
> },
> + { /* Handle problems with rebooting on Dell PowerEdge R540. */
> + .callback = override_reboot,
> + .driver_data = (void *)(long)BOOT_ACPI,
> + .ident = "Dell PowerEdge R540",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R540"),
> + },
> + },
> { }
Assuming ordinary numbering of machine models (R540 being older than
R740), I think it would be better to place the new entry ahead of the
R740 one. Should I end up being the one to commit this, I would take the
liberty of doing the re-arrangement at that point.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-14 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 11:02 [PATCH] x86/shutdown: use ACPI reboot method for Dell PowerEdge R540 Ross Lagerwall
2018-05-14 15:17 ` Jan Beulich [this message]
2018-05-14 16:22 ` Ross Lagerwall
2018-05-14 17:12 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AF9A86E02000078001C28D6@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.