From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v2 9/9] x86/vmx: Don't leak EFER.NXE into
 guest context
Date: Tue, 12 Jun 2018 02:54:15 -0600
Message-ID: <5B1F8A3702000078001CA457@prv1-mh.provo.novell.com>
References: <1528483723-4128-1-git-send-email-andrew.cooper3@citrix.com>
 <1528483723-4128-10-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
In-Reply-To: <1528483723-4128-10-git-send-email-andrew.cooper3@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>, Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>, Jun Nakajima <jun.nakajima@intel.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Pj4+IE9uIDA4LjA2LjE4IGF0IDIwOjQ4LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3Jv
dGU6Cj4gQEAgLTE2NDYsMjIgKzE2MzcsNzEgQEAgc3RhdGljIHZvaWQgdm14X3VwZGF0ZV9ndWVz
dF9jcihzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgaW50IGNyLAo+ICAKPiAgc3RhdGljIHZvaWQg
dm14X3VwZGF0ZV9ndWVzdF9lZmVyKHN0cnVjdCB2Y3B1ICp2KQo+ICB7Cj4gLSAgICB1bnNpZ25l
ZCBsb25nIHZtX2VudHJ5X3ZhbHVlOwo+ICsgICAgdW5zaWduZWQgbG9uZyBlbnRyeV9jdGxzLCBn
dWVzdF9lZmVyID0gdi0+YXJjaC5odm1fdmNwdS5ndWVzdF9lZmVyLAo+ICsgICAgICAgIHhlbl9l
ZmVyID0gcmVhZF9lZmVyKCk7Cj4gKwo+ICsgICAgaWYgKCBwYWdpbmdfbW9kZV9zaGFkb3codi0+
ZG9tYWluKSApCj4gKyAgICB7Cj4gKyAgICAgICAgLyoKPiArICAgICAgICAgKiBXaGVuIHVzaW5n
IHNoYWRvdyBwYWdldGFibGVzLCBFRkVSLk5YIGlzIGEgWGVuLW93bmVkIGJpdCBhbmQgaXMgbm90
Cj4gKyAgICAgICAgICogdW5kZXIgZ3Vlc3QgY29udHJvbC4KPiArICAgICAgICAgKi8KPiArICAg
ICAgICBndWVzdF9lZmVyICY9IH5FRkVSX05YOwo+ICsgICAgICAgIGd1ZXN0X2VmZXIgfD0geGVu
X2VmZXIgJiBFRkVSX05YOwo+ICsgICAgfQo+ICsKPiArICAgIGlmICggISh2LT5hcmNoLmh2bV92
bXguc2Vjb25kYXJ5X2V4ZWNfY29udHJvbCAmCj4gKyAgICAgICAgICAgU0VDT05EQVJZX0VYRUNf
VU5SRVNUUklDVEVEX0dVRVNUKSApCgohdm14X3VucmVzdHJpY3RlZF9ndWVzdCh2KQoKPiArICAg
IHsKPiArICAgICAgICAvKgo+ICsgICAgICAgICAqIFdoZW4gVW5yZXN0cmljdGVkIEd1ZXN0IGlz
IG5vdCBlbmFibGVkIGluIHRoZSBWTUNTLCBoYXJkd2FyZSBkb2VzCj4gKyAgICAgICAgICogbm90
IHRvbGVyYXRlIHRoZSBMTUUgYW5kIExNQSBzZXR0aW5ncyBiZWluZyBkaWZmZXJlbnQuICBBcyB3
cml0ZXMKPiArICAgICAgICAgKiB0byBDUjAgYXJlIGludGVyY2VwdGVkLCBpdCBpcyBzYWZlIHRv
IGxlYXZlIExNRSBjbGVhciBhdCB0aGlzCj4gKyAgICAgICAgICogcG9pbnQsIGFuZCBmaXggdXAg
Ym90aCBMTUUgYW5kIExNQSB3aGVuIENSMC5QRyBpcyBzZXQuCj4gKyAgICAgICAgICovCj4gKyAg
ICAgICAgaWYgKCAhKGd1ZXN0X2VmZXIgJiBFRkVSX0xNQSkgKQo+ICsgICAgICAgICAgICBndWVz
dF9lZmVyICY9IH5FRkVSX0xNRTsKPiArICAgIH0KPiAgCj4gICAgICB2bXhfdm1jc19lbnRlcih2
KTsKPiAgCj4gLSAgICBfX3ZtcmVhZChWTV9FTlRSWV9DT05UUk9MUywgJnZtX2VudHJ5X3ZhbHVl
KTsKPiAtICAgIGlmICggdi0+YXJjaC5odm1fdmNwdS5ndWVzdF9lZmVyICYgRUZFUl9MTUEgKQo+
IC0gICAgICAgIHZtX2VudHJ5X3ZhbHVlIHw9IFZNX0VOVFJZX0lBMzJFX01PREU7Cj4gKyAgICAv
Kgo+ICsgICAgICogVGhlIGludGVuZGVkIGd1ZXN0IHJ1bm5pbmcgbW9kZSBpcyBkZXJpdmVkIGZy
b20gVk1fRU5UUllfSUEzMkVfTU9ERSwKPiArICAgICAqIHdoaWNoIChhcmNoaXRlY3R1cmFsbHkp
IGlzIHRoZSBndWVzdCdzIExNQSBzZXR0aW5nLgo+ICsgICAgICovCj4gKyAgICBfX3ZtcmVhZChW
TV9FTlRSWV9DT05UUk9MUywgJmVudHJ5X2N0bHMpOwo+ICsKPiArICAgIGVudHJ5X2N0bHMgJj0g
flZNX0VOVFJZX0lBMzJFX01PREU7Cj4gKyAgICBpZiAoIGd1ZXN0X2VmZXIgJiBFRkVSX0xNQSAp
Cj4gKyAgICAgICAgZW50cnlfY3RscyB8PSBWTV9FTlRSWV9JQTMyRV9NT0RFOwo+ICsKPiArICAg
IF9fdm13cml0ZShWTV9FTlRSWV9DT05UUk9MUywgZW50cnlfY3Rscyk7Cj4gKwo+ICsgICAgLyog
V2UgZXhwZWN0IHRvIHVzZSBFRkVSIGxvYWRpbmcgaW4gdGhlIGNvbW1vbiBjYXNlLCBidXQuLi4g
Ki8KPiArICAgIGlmICggbGlrZWx5KGNwdV9oYXNfdm14X2VmZXIpICkKPiArICAgICAgICBfX3Zt
d3JpdGUoR1VFU1RfRUZFUiwgZ3Vlc3RfZWZlcik7Cj4gKwo+ICsgICAgLyogLi4uIG9uIEdlbjEg
VlQteCBoYXJkd2FyZSwgd2UgaGF2ZSB0byB1c2UgTVNSIGxvYWQvc2F2ZSBsaXN0cyBpbnN0ZWFk
LiAqLwo+ICAgICAgZWxzZQo+IC0gICAgICAgIHZtX2VudHJ5X3ZhbHVlICY9IH5WTV9FTlRSWV9J
QTMyRV9NT0RFOwo+IC0gICAgX192bXdyaXRlKFZNX0VOVFJZX0NPTlRST0xTLCB2bV9lbnRyeV92
YWx1ZSk7Cj4gKyAgICB7Cj4gKyAgICAgICAgLyoKPiArICAgICAgICAgKiBXaGVuIHRoZSBndWVz
dHMgY2hvaWNlIG9mIEVGRVIgbWF0Y2hlcyBYZW4ncywgcmVtb3ZlIHRoZSBsb2FkL3NhdmUKPiAr
ICAgICAgICAgKiBsaXN0IGVudHJpZXMuICBJdCBpcyB1bm5lY2Vzc2FyeSBvdmVyaGVhZCwgZXNw
ZWNpYWxseSBhcyB0aGlzIGlzCj4gKyAgICAgICAgICogZXhwZWN0ZWQgdG8gYmUgdGhlIGNvbW1v
biBjYXNlIGZvciA2NGJpdCBndWVzdHMuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAgaWYgKCBn
dWVzdF9lZmVyID09IHhlbl9lZmVyICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIHZteF9k
ZWxfbXNyKHYsIE1TUl9FRkVSLCBWTVhfTVNSX0hPU1QpOwo+ICsgICAgICAgICAgICB2bXhfZGVs
X21zcih2LCBNU1JfRUZFUiwgVk1YX01TUl9HVUVTVF9MT0FET05MWSk7Cj4gKyAgICAgICAgfQo+
ICsgICAgICAgIGVsc2UKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIHZteF9hZGRfbXNyKHYs
IE1TUl9FRkVSLCB4ZW5fZWZlciwgVk1YX01TUl9IT1NUKTsKPiArICAgICAgICAgICAgdm14X2Fk
ZF9tc3IodiwgTVNSX0VGRVIsIGd1ZXN0X2VmZXIsIFZNWF9NU1JfR1VFU1RfTE9BRE9OTFkpOwo+
ICsgICAgICAgIH0KPiArICAgIH0KPiAgCj4gICAgICB2bXhfdm1jc19leGl0KHYpOwo+IC0KPiAt
ICAgIGlmICggdiA9PSBjdXJyZW50ICkKPiAtICAgICAgICB3cml0ZV9lZmVyKChyZWFkX2VmZXIo
KSAmIH5FRkVSX1NDRSkgfAo+IC0gICAgICAgICAgICAgICAgICAgKHYtPmFyY2guaHZtX3ZjcHUu
Z3Vlc3RfZWZlciAmIEVGRVJfU0NFKSk7Cj4gIH0KCkFzIG1lbnRpb25lZCBiZWZvcmUsIG92ZXJh
bGwgdGhpcyB3b3VsZCBhbGxvdyBmb3IgZGlzYWJsaW5nIHJlYWQgaW50ZXJjZXB0cyBpbgpjZXJ0
YWluIGNhc2VzLiBJZiB5b3UgZG9uJ3Qgd2FudCB0byBkbyB0aGlzIHJpZ2h0IGF3YXkgdGhhdCdz
IGNlcnRhaW5seSBmaW5lLCBidXQKY291bGQgSSB0YWxrIHlvdSBpbnRvIGF0IGxlYXN0IGFkZGlu
ZyBhIGNvbW1lbnQgdG8gdGhpcyBlZmZlY3Q/Cgo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYv
aHZtL3ZteC92bWNzLmgKPiArKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS92bXgvdm1jcy5o
Cj4gQEAgLTMxMSw2ICszMTEsOCBAQCBleHRlcm4gdTY0IHZteF9lcHRfdnBpZF9jYXA7Cj4gICAg
ICAodm14X2NwdV9iYXNlZF9leGVjX2NvbnRyb2wgJiBDUFVfQkFTRURfTU9OSVRPUl9UUkFQX0ZM
QUcpCj4gICNkZWZpbmUgY3B1X2hhc192bXhfcGF0IFwKPiAgICAgICh2bXhfdm1lbnRyeV9jb250
cm9sICYgVk1fRU5UUllfTE9BRF9HVUVTVF9QQVQpCj4gKyNkZWZpbmUgY3B1X2hhc192bXhfZWZl
ciBcCj4gKyAgICAodm14X3ZtZW50cnlfY29udHJvbCAmIFZNX0VOVFJZX0xPQURfR1VFU1RfRUZF
UikKCkkgdGhpbmsgdGhpcyB3YXMgYXNrZWQgYmVmb3JlLCBidXQgSSdtIGNvbmNlcm5lZCAob2Yg
YXQgbGVhc3QgdGhlIGluY29uc2lzdGVuY3kpCmFueXdheTogY3B1X2hhc192bXhfbXB4LCBmb3Ig
ZXhhbXBsZSwgY2hlY2tzIGJvdGggZmxhZ3MuIE9mIGNvdXJzZSB0aGVyZSdzCnVubGlrZWx5IHRv
IGJlIGFueSBoYXJkd2FyZSB3aXRoIGp1c3Qgb25lIG9mIHRoZSB0d28gZmVhdHVyZXMsIGJ1dCB3
aGF0IGFib3V0CmJ1Z2d5IHZpcnR1YWwgZW52aXJvbm1lbnRzIHdlIG1pZ2h0IHJ1biBpbj8KCklP
VyAtIGlmIHlvdSB3YW50IHRvIGNoZWNrIGp1c3Qgb25lIG9mIHRoZSB0d28gZmxhZ3MgaGVyZSwg
SSB0aGluayB5b3Ugd2FudCB0bwplbmZvcmNlIHRoZSBkZXBlbmRlbmN5IGluIHZteF9pbml0X3Zt
Y3NfY29uZmlnKCksIGNsZWFyaW5nIHRoZSBlbnRyeSBjb250cm9sCmJpdCBpZiB0aGUgZXhpdCBj
b250cm9sIG9uZSBjb21lcyBvdXQgY2xlYXIgZnJvbSBhZGp1c3Rfdm14X2NvbnRyb2xzKCkuCgpK
YW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t
ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov
L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs