From: "Jan Beulich" <JBeulich@suse.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Paul Durrant <paul.durrant@citrix.com>
Subject: [PATCH 2/2] x86/HVM: attempts to emulate FPU insns need to set fpu_initialised
Date: Fri, 15 Jun 2018 02:58:43 -0600 [thread overview]
Message-ID: <5B237FC302000078001CB84E@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <5B237D0B02000078001CB837@prv1-mh.provo.novell.com>
My original way of thinking here was that this would be set anyway at
the point state gets reloaded after the adjustments hvmemul_put_fpu()
does, but the flag should already be set before that - after all the
guest may never again touch the FPU before e.g. getting migrated/saved.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -2053,6 +2053,7 @@ static int hvmemul_get_fpu(
* masking of all exceptions by FNSTENV.)
*/
save_fpu_enable();
+ curr->fpu_initialised = true;
curr->fpu_dirtied = true;
if ( (fpu_ctxt->fcw & 0x3f) != 0x3f )
{
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-06-15 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 8:47 [PATCH 0/2] x86/HVM: XSA-267 follow-ups Jan Beulich
2018-06-15 8:58 ` [PATCH 1/2] x86/HVM: account for fully eager FPU mode in emulation Jan Beulich
2018-06-15 8:58 ` Jan Beulich [this message]
2018-06-22 10:52 ` Ping: [PATCH 2/2] x86/HVM: attempts to emulate FPU insns need to set fpu_initialised Jan Beulich
2018-06-25 7:20 ` Paul Durrant
2018-06-15 9:27 ` [PATCH 0/2] x86/HVM: XSA-267 follow-ups Andrew Cooper
2018-06-15 9:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B237FC302000078001CB84E@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.