Re: [V9fs-developer] [PATCH] fs: 9p: Adding new return type vm_fault_t

From: piaojun <piaojun@huawei.com>
To: Souptick Joarder <jrdr.linux@gmail.com>, <akpm@linux-foundation.org>
Cc: <lucho@ionkov.net>, <ericvh@gmail.com>,
	<linux-kernel@vger.kernel.org>, <willy@infradead.org>,
	<v9fs-developer@lists.sourceforge.net>, <rminnich@sandia.gov>
Subject: Re: [V9fs-developer] [PATCH] fs: 9p: Adding new return type vm_fault_t
Date: Wed, 4 Jul 2018 16:46:44 +0800	[thread overview]
Message-ID: <5B3C8974.6000606@huawei.com> (raw)
In-Reply-To: <20180702154928.GA3964@jordon-HP-15-Notebook-PC>

LGTM

On 2018/7/2 23:49, Souptick Joarder wrote:
> Use new return type vm_fault_t for page_mkwrite
> handler.
> 
> see commit 1c8f422059ae ("mm: change return type to
> vm_fault_t") for reference.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
Acked-by: Jun Piao <piaojun@huawei.com>
> ---
>  fs/9p/vfs_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 03c9e32..5f2e48d 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -533,7 +533,7 @@ int v9fs_file_fsync_dotl(struct file *filp, loff_t start, loff_t end,
>  	return retval;
>  }
> 
> -static int
> +static vm_fault_t
>  v9fs_vm_page_mkwrite(struct vm_fault *vmf)
>  {
>  	struct v9fs_inode *v9inode;
> --
> 1.9.1
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>