From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0624EC28CF6 for ; Wed, 1 Aug 2018 09:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A858520844 for ; Wed, 1 Aug 2018 09:14:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A858520844 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388813AbeHAK72 (ORCPT ); Wed, 1 Aug 2018 06:59:28 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10206 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387689AbeHAK72 (ORCPT ); Wed, 1 Aug 2018 06:59:28 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 4B6618DA23146; Wed, 1 Aug 2018 17:14:33 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.399.0; Wed, 1 Aug 2018 17:14:28 +0800 Message-ID: <5B6179F3.8070002@huawei.com> Date: Wed, 1 Aug 2018 17:14:27 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: John Garry CC: , , , Subject: Re: [PATCH v2] driver/scsi/pmcraid: Use pci_zalloc_consistent instead of pci_alloc_consistent+memset References: <1533107805-7545-1-git-send-email-zhongjiang@huawei.com> In-Reply-To: Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/8/1 16:27, John Garry wrote: > ÔÚ 2018/8/1 15:16, zhong jiang дµÀ: >> Pci_zalloc_consistent is better than pci_alloc_consistent+memset, >> and it make the code concise > > Aren't these APIs deprecated: > https://lkml.org/lkml/2018/6/5/381 > I miss that, Thanks Thanks zhong jiang >> >> Signed-off-by: zhong jiang >> --- >> drivers/scsi/pmcraid.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c >> index 4e86994..8a6facc 100644 >> --- a/drivers/scsi/pmcraid.c >> +++ b/drivers/scsi/pmcraid.c >> @@ -4736,11 +4736,9 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance) >> buffer_size = HRRQ_ENTRY_SIZE * PMCRAID_MAX_CMD; >> for (i = 0; i < pinstance->num_hrrq; i++) { >> - pinstance->hrrq_start[i] = >> - pci_alloc_consistent( >> - pinstance->pdev, >> - buffer_size, >> - &(pinstance->hrrq_start_bus_addr[i])); >> + pinstance->hrrq_start[i] = pci_zalloc_consistent(pinstance->pdev, >> + buffer_size, >> + &(pinstance->hrrq_start_bus_addr[i])); >> if (!pinstance->hrrq_start[i]) { >> pmcraid_err("pci_alloc failed for hrrq vector : %d\n", >> @@ -4749,7 +4747,6 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance) >> return -ENOMEM; >> } >> - memset(pinstance->hrrq_start[i], 0, buffer_size); >> pinstance->hrrq_curr[i] = pinstance->hrrq_start[i]; >> pinstance->hrrq_end[i] = >> pinstance->hrrq_start[i] + PMCRAID_MAX_CMD - 1; >> > > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: Re: [PATCH v2] driver/scsi/pmcraid: Use pci_zalloc_consistent instead of pci_alloc_consistent+memset Date: Wed, 1 Aug 2018 17:14:27 +0800 Message-ID: <5B6179F3.8070002@huawei.com> References: <1533107805-7545-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: John Garry Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 2018/8/1 16:27, John Garry wrote: > ÔÚ 2018/8/1 15:16, zhong jiang дµÀ: >> Pci_zalloc_consistent is better than pci_alloc_consistent+memset, >> and it make the code concise > > Aren't these APIs deprecated: > https://lkml.org/lkml/2018/6/5/381 > I miss that, Thanks Thanks zhong jiang >> >> Signed-off-by: zhong jiang >> --- >> drivers/scsi/pmcraid.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c >> index 4e86994..8a6facc 100644 >> --- a/drivers/scsi/pmcraid.c >> +++ b/drivers/scsi/pmcraid.c >> @@ -4736,11 +4736,9 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance) >> buffer_size = HRRQ_ENTRY_SIZE * PMCRAID_MAX_CMD; >> for (i = 0; i < pinstance->num_hrrq; i++) { >> - pinstance->hrrq_start[i] = >> - pci_alloc_consistent( >> - pinstance->pdev, >> - buffer_size, >> - &(pinstance->hrrq_start_bus_addr[i])); >> + pinstance->hrrq_start[i] = pci_zalloc_consistent(pinstance->pdev, >> + buffer_size, >> + &(pinstance->hrrq_start_bus_addr[i])); >> if (!pinstance->hrrq_start[i]) { >> pmcraid_err("pci_alloc failed for hrrq vector : %d\n", >> @@ -4749,7 +4747,6 @@ static int pmcraid_allocate_host_rrqs(struct pmcraid_instance *pinstance) >> return -ENOMEM; >> } >> - memset(pinstance->hrrq_start[i], 0, buffer_size); >> pinstance->hrrq_curr[i] = pinstance->hrrq_start[i]; >> pinstance->hrrq_end[i] = >> pinstance->hrrq_start[i] + PMCRAID_MAX_CMD - 1; >> > > > > . >