From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA5BC433F5 for ; Fri, 31 Aug 2018 10:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 008EA2083A for ; Fri, 31 Aug 2018 10:06:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 008EA2083A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728269AbeHaOMz (ORCPT ); Fri, 31 Aug 2018 10:12:55 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:42381 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727559AbeHaOMz (ORCPT ); Fri, 31 Aug 2018 10:12:55 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C343DBDA00CEC; Fri, 31 Aug 2018 18:06:07 +0800 (CST) Received: from [127.0.0.1] (10.74.184.86) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.399.0; Fri, 31 Aug 2018 18:06:01 +0800 Subject: Re: [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs To: John Garry , James Morse References: <1535567632-18089-1-git-send-email-wufan@codeaurora.org> <5eab89c6-c063-cbc2-4d02-459faf87698a@arm.com> <6cc3c5e2-3827-a89c-e37b-09728a34f21f@huawei.com> CC: Zhengqiang , Fan Wu , , , , , , , Linuxarm , wanghuiqiang , Shiju Jose From: tanxiaofei Message-ID: <5B891308.40407@huawei.com> Date: Fri, 31 Aug 2018 18:06:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <6cc3c5e2-3827-a89c-e37b-09728a34f21f@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.184.86] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/8/31 0:50, John Garry wrote: > On 30/08/2018 17:34, James Morse wrote: > > Hi James, > > Zhengqiang no longer works on this topic, so I have cc'ed some more guys who should be able to help. > > John > >> Hi Zhengqiang, >> >> On 29/08/18 19:33, Fan Wu wrote: >>> The current ghes_edac driver does not update per-dimm error >>> counters when reporting memory errors, because there is no >>> platform-independent way to find DIMMs based on the error >>> information provided by firmware. This patch offers a solution >>> for platforms whose firmwares provide valid module handles >>> (SMBIOS type 17) in error records. In this case ghes_edac will >>> use the module handles to locate DIMMs and thus makes per-dimm >>> error reporting possible. >> >> Does your platform set CPER_MEM_VALID_MODULE_HANDLE in GHES Memory errors? If >> so, any chance you could test this patch on your platform? [0] >> (original patch: https://lore.kernel.org/patchwork/patch/978928/) >> Hi James, Our platform do not set CPER_MEM_VALID_MODULE_HANDLE in GHES Memory errors. Thanks, tanxiaofei >> Thanks, >> >> James >> >> [0] https://marc.info/?l=linux-edac&m=152603960002324 >> >> >>> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c >>> index 473aeec..db527f0 100644 >>> --- a/drivers/edac/ghes_edac.c >>> +++ b/drivers/edac/ghes_edac.c >>> @@ -81,6 +81,26 @@ static void ghes_edac_count_dimms(const struct dmi_header *dh, void *arg) >>> (*num_dimm)++; >>> } >>> >>> +static int ghes_edac_dimm_index(u16 handle) >>> +{ >>> + struct mem_ctl_info *mci; >>> + int i; >>> + >>> + if (!ghes_pvt) >>> + return -1; >>> + >>> + mci = ghes_pvt->mci; >>> + >>> + if (!mci) >>> + return -1; >>> + >>> + for (i = 0; i < mci->tot_dimms; i++) { >>> + if (mci->dimms[i]->smbios_handle == handle) >>> + return i; >>> + } >>> + return -1; >>> +} >>> + >>> static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg) >>> { >>> struct ghes_edac_dimm_fill *dimm_fill = arg; >>> @@ -177,6 +197,8 @@ static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg) >>> entry->total_width, entry->data_width); >>> } >>> >>> + dimm->smbios_handle = entry->handle; >>> + >>> dimm_fill->count++; >>> } >>> } >>> @@ -327,12 +349,20 @@ void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err) >>> p += sprintf(p, "bit_pos:%d ", mem_err->bit_pos); >>> if (mem_err->validation_bits & CPER_MEM_VALID_MODULE_HANDLE) { >>> const char *bank = NULL, *device = NULL; >>> + int index = -1; >>> + >>> dmi_memdev_name(mem_err->mem_dev_handle, &bank, &device); >>> + p += sprintf(p, "DIMM DMI handle: 0x%.4x ", >>> + mem_err->mem_dev_handle); >>> if (bank != NULL && device != NULL) >>> p += sprintf(p, "DIMM location:%s %s ", bank, device); >>> - else >>> - p += sprintf(p, "DIMM DMI handle: 0x%.4x ", >>> - mem_err->mem_dev_handle); >>> + >>> + index = ghes_edac_dimm_index(mem_err->mem_dev_handle); >>> + if (index >= 0) { >>> + e->top_layer = index; >>> + e->enable_per_layer_report = true; >>> + } >>> + >>> } >>> if (p > e->location) >>> *(p - 1) = '\0'; >>> diff --git a/include/linux/edac.h b/include/linux/edac.h >>> index bffb978..a45ce1f 100644 >>> --- a/include/linux/edac.h >>> +++ b/include/linux/edac.h >>> @@ -451,6 +451,8 @@ struct dimm_info { >>> u32 nr_pages; /* number of pages on this dimm */ >>> >>> unsigned csrow, cschannel; /* Points to the old API data */ >>> + >>> + u16 smbios_handle; /* Handle for SMBIOS type 17 */ >>> }; >>> >>> /** >>> >> >> >> . >> > > > > . > -- best wishes 谭小飞 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC, ghes: use CPER module handles to locate DIMMs From: tanxiaofei Message-Id: <5B891308.40407@huawei.com> Date: Fri, 31 Aug 2018 18:06:00 +0800 To: John Garry , James Morse Cc: Zhengqiang , Fan Wu , mchehab@kernel.org, bp@alien8.de, baicar.tyler@gmail.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linuxarm , wanghuiqiang , Shiju Jose List-ID: T24gMjAxOC84LzMxIDA6NTAsIEpvaG4gR2Fycnkgd3JvdGU6Cj4gT24gMzAvMDgvMjAxOCAxNzoz NCwgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gCj4gSGkgSmFtZXMsCj4gCj4gWmhlbmdxaWFuZyBubyBs b25nZXIgd29ya3Mgb24gdGhpcyB0b3BpYywgc28gSSBoYXZlIGNjJ2VkIHNvbWUgbW9yZSBndXlz IHdobyBzaG91bGQgYmUgYWJsZSB0byBoZWxwLgo+IAo+IEpvaG4KPiAKPj4gSGkgWmhlbmdxaWFu ZywKPj4KPj4gT24gMjkvMDgvMTggMTk6MzMsIEZhbiBXdSB3cm90ZToKPj4+IFRoZSBjdXJyZW50 IGdoZXNfZWRhYyBkcml2ZXIgZG9lcyBub3QgdXBkYXRlIHBlci1kaW1tIGVycm9yCj4+PiBjb3Vu dGVycyB3aGVuIHJlcG9ydGluZyBtZW1vcnkgZXJyb3JzLCBiZWNhdXNlIHRoZXJlIGlzIG5vCj4+ PiBwbGF0Zm9ybS1pbmRlcGVuZGVudCB3YXkgdG8gZmluZCBESU1NcyBiYXNlZCBvbiB0aGUgZXJy b3IKPj4+IGluZm9ybWF0aW9uIHByb3ZpZGVkIGJ5IGZpcm13YXJlLiBUaGlzIHBhdGNoIG9mZmVy cyBhIHNvbHV0aW9uCj4+PiBmb3IgcGxhdGZvcm1zIHdob3NlIGZpcm13YXJlcyBwcm92aWRlIHZh bGlkIG1vZHVsZSBoYW5kbGVzCj4+PiAoU01CSU9TIHR5cGUgMTcpIGluIGVycm9yIHJlY29yZHMu IEluIHRoaXMgY2FzZSBnaGVzX2VkYWMgd2lsbAo+Pj4gdXNlIHRoZSBtb2R1bGUgaGFuZGxlcyB0 byBsb2NhdGUgRElNTXMgYW5kIHRodXMgbWFrZXMgcGVyLWRpbW0KPj4+IGVycm9yIHJlcG9ydGlu ZyBwb3NzaWJsZS4KPj4KPj4gRG9lcyB5b3VyIHBsYXRmb3JtIHNldCBDUEVSX01FTV9WQUxJRF9N T0RVTEVfSEFORExFIGluIEdIRVMgTWVtb3J5IGVycm9ycz8gSWYKPj4gc28sIGFueSBjaGFuY2Ug eW91IGNvdWxkIHRlc3QgdGhpcyBwYXRjaCBvbiB5b3VyIHBsYXRmb3JtPyBbMF0KPj4gKG9yaWdp bmFsIHBhdGNoOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9wYXRjaHdvcmsvcGF0Y2gvOTc4OTI4 LykKPj4KCkhpIEphbWVzLAoKT3VyIHBsYXRmb3JtIGRvIG5vdCBzZXQgQ1BFUl9NRU1fVkFMSURf TU9EVUxFX0hBTkRMRSBpbiBHSEVTIE1lbW9yeSBlcnJvcnMuCgpUaGFua3MsCnRhbnhpYW9mZWkK Cj4+IFRoYW5rcywKPj4KPj4gSmFtZXMKPj4KPj4gWzBdIGh0dHBzOi8vbWFyYy5pbmZvLz9sPWxp bnV4LWVkYWMmbT0xNTI2MDM5NjAwMDIzMjQKPj4KPj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2VkYWMvZ2hlc19lZGFjLmMgYi9kcml2ZXJzL2VkYWMvZ2hlc19lZGFjLmMKPj4+IGluZGV4IDQ3 M2FlZWMuLmRiNTI3ZjAgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2VkYWMvZ2hlc19lZGFjLmMK Pj4+ICsrKyBiL2RyaXZlcnMvZWRhYy9naGVzX2VkYWMuYwo+Pj4gQEAgLTgxLDYgKzgxLDI2IEBA IHN0YXRpYyB2b2lkIGdoZXNfZWRhY19jb3VudF9kaW1tcyhjb25zdCBzdHJ1Y3QgZG1pX2hlYWRl ciAqZGgsIHZvaWQgKmFyZykKPj4+ICAgICAgICAgICgqbnVtX2RpbW0pKys7Cj4+PiAgfQo+Pj4K Pj4+ICtzdGF0aWMgaW50IGdoZXNfZWRhY19kaW1tX2luZGV4KHUxNiBoYW5kbGUpCj4+PiArewo+ Pj4gKyAgICBzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2k7Cj4+PiArICAgIGludCBpOwo+Pj4gKwo+ Pj4gKyAgICBpZiAoIWdoZXNfcHZ0KQo+Pj4gKyAgICAgICAgcmV0dXJuIC0xOwo+Pj4gKwo+Pj4g KyAgICBtY2kgPSBnaGVzX3B2dC0+bWNpOwo+Pj4gKwo+Pj4gKyAgICBpZiAoIW1jaSkKPj4+ICsg ICAgICAgIHJldHVybiAtMTsKPj4+ICsKPj4+ICsgICAgZm9yIChpID0gMDsgaSA8IG1jaS0+dG90 X2RpbW1zOyBpKyspIHsKPj4+ICsgICAgICAgIGlmIChtY2ktPmRpbW1zW2ldLT5zbWJpb3NfaGFu ZGxlID09IGhhbmRsZSkKPj4+ICsgICAgICAgICAgICByZXR1cm4gaTsKPj4+ICsgICAgfQo+Pj4g KyAgICByZXR1cm4gLTE7Cj4+PiArfQo+Pj4gKwo+Pj4gIHN0YXRpYyB2b2lkIGdoZXNfZWRhY19k bWlkZWNvZGUoY29uc3Qgc3RydWN0IGRtaV9oZWFkZXIgKmRoLCB2b2lkICphcmcpCj4+PiAgewo+ Pj4gICAgICBzdHJ1Y3QgZ2hlc19lZGFjX2RpbW1fZmlsbCAqZGltbV9maWxsID0gYXJnOwo+Pj4g QEAgLTE3Nyw2ICsxOTcsOCBAQCBzdGF0aWMgdm9pZCBnaGVzX2VkYWNfZG1pZGVjb2RlKGNvbnN0 IHN0cnVjdCBkbWlfaGVhZGVyICpkaCwgdm9pZCAqYXJnKQo+Pj4gICAgICAgICAgICAgICAgICBl bnRyeS0+dG90YWxfd2lkdGgsIGVudHJ5LT5kYXRhX3dpZHRoKTsKPj4+ICAgICAgICAgIH0KPj4+ Cj4+PiArICAgICAgICBkaW1tLT5zbWJpb3NfaGFuZGxlID0gZW50cnktPmhhbmRsZTsKPj4+ICsK Pj4+ICAgICAgICAgIGRpbW1fZmlsbC0+Y291bnQrKzsKPj4+ICAgICAgfQo+Pj4gIH0KPj4+IEBA IC0zMjcsMTIgKzM0OSwyMCBAQCB2b2lkIGdoZXNfZWRhY19yZXBvcnRfbWVtX2Vycm9yKGludCBz ZXYsIHN0cnVjdCBjcGVyX3NlY19tZW1fZXJyICptZW1fZXJyKQo+Pj4gICAgICAgICAgcCArPSBz cHJpbnRmKHAsICJiaXRfcG9zOiVkICIsIG1lbV9lcnItPmJpdF9wb3MpOwo+Pj4gICAgICBpZiAo bWVtX2Vyci0+dmFsaWRhdGlvbl9iaXRzICYgQ1BFUl9NRU1fVkFMSURfTU9EVUxFX0hBTkRMRSkg ewo+Pj4gICAgICAgICAgY29uc3QgY2hhciAqYmFuayA9IE5VTEwsICpkZXZpY2UgPSBOVUxMOwo+ Pj4gKyAgICAgICAgaW50IGluZGV4ID0gLTE7Cj4+PiArCj4+PiAgICAgICAgICBkbWlfbWVtZGV2 X25hbWUobWVtX2Vyci0+bWVtX2Rldl9oYW5kbGUsICZiYW5rLCAmZGV2aWNlKTsKPj4+ICsgICAg ICAgIHAgKz0gc3ByaW50ZihwLCAiRElNTSBETUkgaGFuZGxlOiAweCUuNHggIiwKPj4+ICsgICAg ICAgICAgICAgICAgIG1lbV9lcnItPm1lbV9kZXZfaGFuZGxlKTsKPj4+ICAgICAgICAgIGlmIChi YW5rICE9IE5VTEwgJiYgZGV2aWNlICE9IE5VTEwpCj4+PiAgICAgICAgICAgICAgcCArPSBzcHJp bnRmKHAsICJESU1NIGxvY2F0aW9uOiVzICVzICIsIGJhbmssIGRldmljZSk7Cj4+PiAtICAgICAg ICBlbHNlCj4+PiAtICAgICAgICAgICAgcCArPSBzcHJpbnRmKHAsICJESU1NIERNSSBoYW5kbGU6 IDB4JS40eCAiLAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIG1lbV9lcnItPm1lbV9kZXZfaGFu ZGxlKTsKPj4+ICsKPj4+ICsgICAgICAgIGluZGV4ID0gZ2hlc19lZGFjX2RpbW1faW5kZXgobWVt X2Vyci0+bWVtX2Rldl9oYW5kbGUpOwo+Pj4gKyAgICAgICAgaWYgKGluZGV4ID49IDApIHsKPj4+ ICsgICAgICAgICAgICBlLT50b3BfbGF5ZXIgPSBpbmRleDsKPj4+ICsgICAgICAgICAgICBlLT5l bmFibGVfcGVyX2xheWVyX3JlcG9ydCA9IHRydWU7Cj4+PiArICAgICAgICB9Cj4+PiArCj4+PiAg ICAgIH0KPj4+ICAgICAgaWYgKHAgPiBlLT5sb2NhdGlvbikKPj4+ICAgICAgICAgICoocCAtIDEp ID0gJ1wwJzsKPj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2VkYWMuaCBiL2luY2x1ZGUv bGludXgvZWRhYy5oCj4+PiBpbmRleCBiZmZiOTc4Li5hNDVjZTFmIDEwMDY0NAo+Pj4gLS0tIGEv aW5jbHVkZS9saW51eC9lZGFjLmgKPj4+ICsrKyBiL2luY2x1ZGUvbGludXgvZWRhYy5oCj4+PiBA QCAtNDUxLDYgKzQ1MSw4IEBAIHN0cnVjdCBkaW1tX2luZm8gewo+Pj4gICAgICB1MzIgbnJfcGFn ZXM7ICAgICAgICAgICAgLyogbnVtYmVyIG9mIHBhZ2VzIG9uIHRoaXMgZGltbSAqLwo+Pj4KPj4+ ICAgICAgdW5zaWduZWQgY3Nyb3csIGNzY2hhbm5lbDsgICAgLyogUG9pbnRzIHRvIHRoZSBvbGQg QVBJIGRhdGEgKi8KPj4+ICsKPj4+ICsgICAgdTE2IHNtYmlvc19oYW5kbGU7ICAgICAgICAgICAg ICAvKiBIYW5kbGUgZm9yIFNNQklPUyB0eXBlIDE3ICovCj4+PiAgfTsKPj4+Cj4+PiAgLyoqCj4+ Pgo+Pgo+Pgo+PiAuCj4+Cj4gCj4gCj4gCj4gLgo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: tanxiaofei@huawei.com (tanxiaofei) Date: Fri, 31 Aug 2018 18:06:00 +0800 Subject: [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs In-Reply-To: <6cc3c5e2-3827-a89c-e37b-09728a34f21f@huawei.com> References: <1535567632-18089-1-git-send-email-wufan@codeaurora.org> <5eab89c6-c063-cbc2-4d02-459faf87698a@arm.com> <6cc3c5e2-3827-a89c-e37b-09728a34f21f@huawei.com> Message-ID: <5B891308.40407@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018/8/31 0:50, John Garry wrote: > On 30/08/2018 17:34, James Morse wrote: > > Hi James, > > Zhengqiang no longer works on this topic, so I have cc'ed some more guys who should be able to help. > > John > >> Hi Zhengqiang, >> >> On 29/08/18 19:33, Fan Wu wrote: >>> The current ghes_edac driver does not update per-dimm error >>> counters when reporting memory errors, because there is no >>> platform-independent way to find DIMMs based on the error >>> information provided by firmware. This patch offers a solution >>> for platforms whose firmwares provide valid module handles >>> (SMBIOS type 17) in error records. In this case ghes_edac will >>> use the module handles to locate DIMMs and thus makes per-dimm >>> error reporting possible. >> >> Does your platform set CPER_MEM_VALID_MODULE_HANDLE in GHES Memory errors? If >> so, any chance you could test this patch on your platform? [0] >> (original patch: https://lore.kernel.org/patchwork/patch/978928/) >> Hi James, Our platform do not set CPER_MEM_VALID_MODULE_HANDLE in GHES Memory errors. Thanks, tanxiaofei >> Thanks, >> >> James >> >> [0] https://marc.info/?l=linux-edac&m=152603960002324 >> >> >>> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c >>> index 473aeec..db527f0 100644 >>> --- a/drivers/edac/ghes_edac.c >>> +++ b/drivers/edac/ghes_edac.c >>> @@ -81,6 +81,26 @@ static void ghes_edac_count_dimms(const struct dmi_header *dh, void *arg) >>> (*num_dimm)++; >>> } >>> >>> +static int ghes_edac_dimm_index(u16 handle) >>> +{ >>> + struct mem_ctl_info *mci; >>> + int i; >>> + >>> + if (!ghes_pvt) >>> + return -1; >>> + >>> + mci = ghes_pvt->mci; >>> + >>> + if (!mci) >>> + return -1; >>> + >>> + for (i = 0; i < mci->tot_dimms; i++) { >>> + if (mci->dimms[i]->smbios_handle == handle) >>> + return i; >>> + } >>> + return -1; >>> +} >>> + >>> static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg) >>> { >>> struct ghes_edac_dimm_fill *dimm_fill = arg; >>> @@ -177,6 +197,8 @@ static void ghes_edac_dmidecode(const struct dmi_header *dh, void *arg) >>> entry->total_width, entry->data_width); >>> } >>> >>> + dimm->smbios_handle = entry->handle; >>> + >>> dimm_fill->count++; >>> } >>> } >>> @@ -327,12 +349,20 @@ void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err) >>> p += sprintf(p, "bit_pos:%d ", mem_err->bit_pos); >>> if (mem_err->validation_bits & CPER_MEM_VALID_MODULE_HANDLE) { >>> const char *bank = NULL, *device = NULL; >>> + int index = -1; >>> + >>> dmi_memdev_name(mem_err->mem_dev_handle, &bank, &device); >>> + p += sprintf(p, "DIMM DMI handle: 0x%.4x ", >>> + mem_err->mem_dev_handle); >>> if (bank != NULL && device != NULL) >>> p += sprintf(p, "DIMM location:%s %s ", bank, device); >>> - else >>> - p += sprintf(p, "DIMM DMI handle: 0x%.4x ", >>> - mem_err->mem_dev_handle); >>> + >>> + index = ghes_edac_dimm_index(mem_err->mem_dev_handle); >>> + if (index >= 0) { >>> + e->top_layer = index; >>> + e->enable_per_layer_report = true; >>> + } >>> + >>> } >>> if (p > e->location) >>> *(p - 1) = '\0'; >>> diff --git a/include/linux/edac.h b/include/linux/edac.h >>> index bffb978..a45ce1f 100644 >>> --- a/include/linux/edac.h >>> +++ b/include/linux/edac.h >>> @@ -451,6 +451,8 @@ struct dimm_info { >>> u32 nr_pages; /* number of pages on this dimm */ >>> >>> unsigned csrow, cschannel; /* Points to the old API data */ >>> + >>> + u16 smbios_handle; /* Handle for SMBIOS type 17 */ >>> }; >>> >>> /** >>> >> >> >> . >> > > > > . > -- best wishes ???