All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: tools/fuzz fails due build, osstest did not notice
Date: Mon, 03 Sep 2018 06:35:42 -0600	[thread overview]
Message-ID: <5B8D2A9E02000078001E491D@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180903115323.616cc7f8.olaf@aepfle.de>

>>> On 03.09.18 at 11:53, <olaf@aepfle.de> wrote:
> Since about two months staging fails to build because tools/fuzz can not cope 
> with CFLAGS="-O2 -Wall  -fstack-protector-strong -funwind-tables 
> -fasynchronous-unwind-tables -fstack-clash-protection". While I can easily 
> hide the bug by undefining _FORTIFY_SOURCE, I always wonder why osstest does 
> not catch such bugs?
> 
> Looking at some random build-amd64/6.ts-xen-build.log output, it seems no 
> CFLAGS at all is set. I'm sure SUSE is not the only one that sets CFLAGS 
> during their package build, and further I think SUSE is not the only one who 
> enforces -D_FORTIFY_SOURCE= globally. So on that ground, shouldn't whatever 
> osstest does match what the consumers of xen use? Running osstest with 
> throw-away-binaries compiled with -D_FORTIFY_SOURCE will likely not hurt or 
> invalidate the overall coverage.

Leaving aside the suggestion you make (I'm unconvinced either variant is
strictly better than the other) - what is the actual problem? The mere
listing of compiler flags passed does not make clear to me where the clash
is, or how it would surface.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-09-03 12:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03  9:53 tools/fuzz fails due build, osstest did not notice Olaf Hering
2018-09-03 12:35 ` Jan Beulich [this message]
2018-09-04  7:32   ` Olaf Hering
2018-09-04  9:06     ` Jan Beulich
2018-09-20 18:19       ` Christopher Clark
2018-09-21 10:05         ` Jan Beulich
2018-09-21 19:25           ` [PATCH] fuzz, test x86_emulator: disable sse before including always_inline fns Christopher Clark
     [not found]       ` <960FC0BE02000080AB59E961@prv1-mh.provo.novell.com>
     [not found]         ` <FEBAD1C002000087824A10E1@prv1-mh.provo.novell.com>
2018-09-24 12:06           ` Jan Beulich
2018-09-24 23:17             ` Christopher Clark
2018-09-24 23:22               ` [PATCH v2] " Christopher Clark
2018-09-26  8:36                 ` Wei Liu
2018-09-26  8:40                   ` Wei Liu
     [not found]               ` <D1822B16020000D4AB59E961@prv1-mh.provo.novell.com>
2018-09-25  7:31                 ` [PATCH] " Jan Beulich
     [not found]                 ` <22FE05D1020000E4824A10E1@prv1-mh.provo.novell.com>
2018-09-25  9:51                   ` [PATCH v2] " Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B8D2A9E02000078001E491D@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.