All of lore.kernel.org
 help / color / mirror / Atom feed
* [xen-unstable test] 127070: regressions - FAIL
@ 2018-09-01 21:43 osstest service owner
  2018-09-03 12:44 ` Jan Beulich
  0 siblings, 1 reply; 5+ messages in thread
From: osstest service owner @ 2018-09-01 21:43 UTC (permalink / raw)
  To: xen-devel, osstest-admin

flight 127070 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/127070/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-shadow   20 guest-start/debian.repeat fail REGR. vs. 126854

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt      7 xen-boot                   fail pass in 127012
 test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail pass in 127012

Tests which did not succeed, but are not blocking:
 build-amd64-xen-freebsd       7 xen-build-freebsd   fail in 127012 like 126854
 test-armhf-armhf-libvirt 14 saverestore-support-check fail in 127012 like 126854
 test-armhf-armhf-libvirt    13 migrate-support-check fail in 127012 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop            fail like 126854
 test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop            fail like 126854
 test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop             fail like 126854
 test-amd64-i386-xl-qemut-win7-amd64 17 guest-stop             fail like 126854
 test-armhf-armhf-libvirt-raw 13 saverestore-support-check    fail  like 126854
 test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop            fail like 126854
 test-amd64-amd64-xl-qemut-ws16-amd64 17 guest-stop            fail like 126854
 test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop             fail like 126854
 build-amd64-xen-xsm-freebsd   7 xen-build-freebsd            fail   never pass
 test-amd64-i386-xl-pvshim    12 guest-start                  fail   never pass
 test-amd64-i386-libvirt      13 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  13 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     13 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 13 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 11 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  14 saverestore-support-check    fail   never pass
 test-amd64-amd64-qemuu-nested-amd 17 debian-hvm-install/l1/l2  fail never pass
 test-amd64-amd64-libvirt-vhd 12 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 13 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 14 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  14 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 13 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     14 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 14 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 12 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          13 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          14 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-qemut-ws16-amd64 17 guest-stop              fail never pass
 test-armhf-armhf-xl-vhd      12 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      13 saverestore-support-check    fail   never pass
 test-amd64-amd64-xl-qemuu-win10-i386 10 windows-install        fail never pass
 test-amd64-i386-xl-qemuu-win10-i386 10 windows-install         fail never pass
 test-amd64-amd64-xl-qemut-win10-i386 10 windows-install        fail never pass
 test-amd64-i386-xl-qemut-win10-i386 10 windows-install         fail never pass

version targeted for testing:
 xen                  f04955e18502035121776f6e09d83ae5a36c773c
baseline version:
 xen                  36e29dd9e580cb0f847f5ac1e72afdb5febe3e99

Last test of basis   126854  2018-08-28 12:14:33 Z    4 days
Failing since        126952  2018-08-29 15:25:50 Z    3 days    3 attempts
Testing same since   127012  2018-08-30 23:16:20 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Daniel De Graaf <dgdegra@tycho.nsa.gov>
  Gopalasetty, Manoj <manoj.gopalasetty@hpe.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <julien.grall@arm.com>
  Kevin Tian <kevin.tian@intel.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefanos@xilinx.com>
  Wei Liu <wei.liu2@citrix.com>
  Zhenzhong Duan <zhenzhong.duan@oracle.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-xen-freebsd                                      pass    
 build-amd64-xen-xsm-freebsd                                  fail    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 build-amd64-rumprun                                          pass    
 build-i386-rumprun                                           pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm                pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64-xsm                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm                pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm                 pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-rumprun-amd64                               pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-i386-rumprun-i386                                 pass    
 test-amd64-amd64-xl-qemut-win10-i386                         fail    
 test-amd64-i386-xl-qemut-win10-i386                          fail    
 test-amd64-amd64-xl-qemuu-win10-i386                         fail    
 test-amd64-i386-xl-qemuu-win10-i386                          fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-amd64-pvgrub                                pass    
 test-amd64-amd64-i386-pvgrub                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-xl-raw                                       pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 639 lines long.)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [xen-unstable test] 127070: regressions - FAIL
  2018-09-01 21:43 [xen-unstable test] 127070: regressions - FAIL osstest service owner
@ 2018-09-03 12:44 ` Jan Beulich
  2018-09-03 12:56   ` Juergen Gross
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2018-09-03 12:44 UTC (permalink / raw)
  To: xen-devel; +Cc: osstest service owner

>>> On 01.09.18 at 23:43, <osstest-admin@xenproject.org> wrote:
> flight 127070 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/127070/ 
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-i386-xl-shadow   20 guest-start/debian.repeat fail REGR. vs. 126854

I wonder if this

[   30.017142] BUG: unable to handle kernel paging request at 0002ffa8
[   30.017208] IP: __radix_tree_lookup+0x12/0xb0
[   30.017235] *pdpt = 000000001eca5027 *pde = 0000000000000000 
[   30.017271] Oops: 0000 [#1] SMP
[   30.017293] Modules linked in: ext4 mbcache jbd2
[   30.017352] CPU: 2 PID: 1204 Comm: systemd Not tainted 4.14.67+ #1
[   30.017383] task: df601f80 task.stack: dafd8000
[   30.017411] EIP: __radix_tree_lookup+0x12/0xb0
[   30.017445] EFLAGS: 00010282 CPU: 2
[   30.017468] EAX: 0002ffa4 EBX: b7ed2000 ECX: 00000000 EDX: 01ffffff
[   30.017503] ESI: 00000000 EDI: 00000000 EBP: dafd9de4 ESP: dafd9dd0
[   30.017534]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0069
[   30.017571] CR0: 80050033 CR2: 0002ffa8 CR3: 1eca4000 CR4: 00042660
[   30.017620] Call Trace:
[   30.017642]  radix_tree_lookup_slot+0x11/0x30
[   30.017673]  ? xen_set_pud+0xa0/0xa0
[   30.017699]  find_get_entry+0x1d/0x110
[   30.017723]  pagecache_get_page+0x1f/0x230
[   30.017752]  lookup_swap_cache+0x35/0x110
[   30.017778]  swap_readahead_detect+0x84/0x2f0
[   30.017809]  do_swap_page+0x25b/0x8e0
[   30.017837]  ? wp_page_copy+0x399/0x6b0
[   30.017866]  ? kmap_atomic_prot+0x2b/0x180
[   30.017892]  ? __raw_callee_save_xen_pte_val+0xc/0xc
[   30.017925]  handle_mm_fault+0x468/0x9e0
[   30.017951]  __do_page_fault+0x1ba/0x4e0
[   30.017976]  ? __do_page_fault+0x4e0/0x4e0
[   30.018008]  do_page_fault+0x37/0x100
[   30.018032]  ? __do_page_fault+0x4e0/0x4e0
[   30.018060]  common_exception+0x77/0x7e
[   30.018084] EIP: 0xb7f0d39f
[   30.018101] EFLAGS: 00010246 CPU: 2
[   30.018124] EAX: b7ed2030 EBX: b7f20000 ECX: b7bf91b8 EDX: 00000002
[   30.018158] ESI: b7f2055c EDI: b7f10e90 EBP: b7bf9260 ESP: b7bf9208
[   30.018190]  DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b
[   30.018220]  ? __do_page_fault+0x4e0/0x4e0
[   30.018242] Code: 00 8b 03 c1 e8 1a 85 c0 74 be 0f 0b 8d b6 00 00 00 00 8d bc 27 00 00 00 00 55 89 e5 57 56 53 83 ec 08 89 45 f0 89 4d ec 8b 45 f0 <8b> 40 04 89 c1 83 e1 03 83 f9 01 75 71 89 c1 bf 40 00 00 00 83
[   30.018415] EIP: __radix_tree_lookup+0x12/0xb0 SS:ESP: 0069:dafd9dd0
[   30.018445] CR2: 000000000002ffa8
[   30.018472] ---[ end trace c8ba97a241bb2040 ]---

isn't a (presumably indirect) result of

Sep  1 03:06:32.180094 (XEN) d28 L1TF-vulnerable L1e 8000000400000000 - Shadowing

Jürgen's change to avoid split PTE writes would then only be
papering over an active issue.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [xen-unstable test] 127070: regressions - FAIL
  2018-09-03 12:44 ` Jan Beulich
@ 2018-09-03 12:56   ` Juergen Gross
  2018-09-03 15:21     ` Jan Beulich
  0 siblings, 1 reply; 5+ messages in thread
From: Juergen Gross @ 2018-09-03 12:56 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: osstest service owner

On 03/09/18 14:44, Jan Beulich wrote:
>>>> On 01.09.18 at 23:43, <osstest-admin@xenproject.org> wrote:
>> flight 127070 xen-unstable real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/127070/ 
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>  test-amd64-i386-xl-shadow   20 guest-start/debian.repeat fail REGR. vs. 126854
> 
> I wonder if this
> 
> [   30.017142] BUG: unable to handle kernel paging request at 0002ffa8
> [   30.017208] IP: __radix_tree_lookup+0x12/0xb0
> [   30.017235] *pdpt = 000000001eca5027 *pde = 0000000000000000 
> [   30.017271] Oops: 0000 [#1] SMP
> [   30.017293] Modules linked in: ext4 mbcache jbd2
> [   30.017352] CPU: 2 PID: 1204 Comm: systemd Not tainted 4.14.67+ #1
> [   30.017383] task: df601f80 task.stack: dafd8000
> [   30.017411] EIP: __radix_tree_lookup+0x12/0xb0
> [   30.017445] EFLAGS: 00010282 CPU: 2
> [   30.017468] EAX: 0002ffa4 EBX: b7ed2000 ECX: 00000000 EDX: 01ffffff
> [   30.017503] ESI: 00000000 EDI: 00000000 EBP: dafd9de4 ESP: dafd9dd0
> [   30.017534]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0069
> [   30.017571] CR0: 80050033 CR2: 0002ffa8 CR3: 1eca4000 CR4: 00042660
> [   30.017620] Call Trace:
> [   30.017642]  radix_tree_lookup_slot+0x11/0x30
> [   30.017673]  ? xen_set_pud+0xa0/0xa0
> [   30.017699]  find_get_entry+0x1d/0x110
> [   30.017723]  pagecache_get_page+0x1f/0x230
> [   30.017752]  lookup_swap_cache+0x35/0x110
> [   30.017778]  swap_readahead_detect+0x84/0x2f0
> [   30.017809]  do_swap_page+0x25b/0x8e0
> [   30.017837]  ? wp_page_copy+0x399/0x6b0
> [   30.017866]  ? kmap_atomic_prot+0x2b/0x180
> [   30.017892]  ? __raw_callee_save_xen_pte_val+0xc/0xc
> [   30.017925]  handle_mm_fault+0x468/0x9e0
> [   30.017951]  __do_page_fault+0x1ba/0x4e0
> [   30.017976]  ? __do_page_fault+0x4e0/0x4e0
> [   30.018008]  do_page_fault+0x37/0x100
> [   30.018032]  ? __do_page_fault+0x4e0/0x4e0
> [   30.018060]  common_exception+0x77/0x7e
> [   30.018084] EIP: 0xb7f0d39f
> [   30.018101] EFLAGS: 00010246 CPU: 2
> [   30.018124] EAX: b7ed2030 EBX: b7f20000 ECX: b7bf91b8 EDX: 00000002
> [   30.018158] ESI: b7f2055c EDI: b7f10e90 EBP: b7bf9260 ESP: b7bf9208
> [   30.018190]  DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b
> [   30.018220]  ? __do_page_fault+0x4e0/0x4e0
> [   30.018242] Code: 00 8b 03 c1 e8 1a 85 c0 74 be 0f 0b 8d b6 00 00 00 00 8d bc 27 00 00 00 00 55 89 e5 57 56 53 83 ec 08 89 45 f0 89 4d ec 8b 45 f0 <8b> 40 04 89 c1 83 e1 03 83 f9 01 75 71 89 c1 bf 40 00 00 00 83
> [   30.018415] EIP: __radix_tree_lookup+0x12/0xb0 SS:ESP: 0069:dafd9dd0
> [   30.018445] CR2: 000000000002ffa8
> [   30.018472] ---[ end trace c8ba97a241bb2040 ]---
> 
> isn't a (presumably indirect) result of
> 
> Sep  1 03:06:32.180094 (XEN) d28 L1TF-vulnerable L1e 8000000400000000 - Shadowing
> 
> Jürgen's change to avoid split PTE writes would then only be
> papering over an active issue.

No, it isn't papering over the issue, but repairing it. See

https://bugzilla.kernel.org/show_bug.cgi?id=198497

which clearly states that this issue has been seen on bare metal, too.
On Xen its just much more frequent as the timing is different.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [xen-unstable test] 127070: regressions - FAIL
  2018-09-03 12:56   ` Juergen Gross
@ 2018-09-03 15:21     ` Jan Beulich
  0 siblings, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2018-09-03 15:21 UTC (permalink / raw)
  To: Juergen Gross; +Cc: xen-devel, osstest service owner

>>> On 03.09.18 at 14:56, <jgross@suse.com> wrote:
> On 03/09/18 14:44, Jan Beulich wrote:
>>>>> On 01.09.18 at 23:43, <osstest-admin@xenproject.org> wrote:
>>> flight 127070 xen-unstable real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/127070/ 
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>>  test-amd64-i386-xl-shadow   20 guest-start/debian.repeat fail REGR. vs. 
> 126854
>> 
>> I wonder if this
>> 
>> [   30.017142] BUG: unable to handle kernel paging request at 0002ffa8
>> [   30.017208] IP: __radix_tree_lookup+0x12/0xb0
>> [   30.017235] *pdpt = 000000001eca5027 *pde = 0000000000000000 
>> [   30.017271] Oops: 0000 [#1] SMP
>> [   30.017293] Modules linked in: ext4 mbcache jbd2
>> [   30.017352] CPU: 2 PID: 1204 Comm: systemd Not tainted 4.14.67+ #1
>> [   30.017383] task: df601f80 task.stack: dafd8000
>> [   30.017411] EIP: __radix_tree_lookup+0x12/0xb0
>> [   30.017445] EFLAGS: 00010282 CPU: 2
>> [   30.017468] EAX: 0002ffa4 EBX: b7ed2000 ECX: 00000000 EDX: 01ffffff
>> [   30.017503] ESI: 00000000 EDI: 00000000 EBP: dafd9de4 ESP: dafd9dd0
>> [   30.017534]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0069
>> [   30.017571] CR0: 80050033 CR2: 0002ffa8 CR3: 1eca4000 CR4: 00042660
>> [   30.017620] Call Trace:
>> [   30.017642]  radix_tree_lookup_slot+0x11/0x30
>> [   30.017673]  ? xen_set_pud+0xa0/0xa0
>> [   30.017699]  find_get_entry+0x1d/0x110
>> [   30.017723]  pagecache_get_page+0x1f/0x230
>> [   30.017752]  lookup_swap_cache+0x35/0x110
>> [   30.017778]  swap_readahead_detect+0x84/0x2f0
>> [   30.017809]  do_swap_page+0x25b/0x8e0
>> [   30.017837]  ? wp_page_copy+0x399/0x6b0
>> [   30.017866]  ? kmap_atomic_prot+0x2b/0x180
>> [   30.017892]  ? __raw_callee_save_xen_pte_val+0xc/0xc
>> [   30.017925]  handle_mm_fault+0x468/0x9e0
>> [   30.017951]  __do_page_fault+0x1ba/0x4e0
>> [   30.017976]  ? __do_page_fault+0x4e0/0x4e0
>> [   30.018008]  do_page_fault+0x37/0x100
>> [   30.018032]  ? __do_page_fault+0x4e0/0x4e0
>> [   30.018060]  common_exception+0x77/0x7e
>> [   30.018084] EIP: 0xb7f0d39f
>> [   30.018101] EFLAGS: 00010246 CPU: 2
>> [   30.018124] EAX: b7ed2030 EBX: b7f20000 ECX: b7bf91b8 EDX: 00000002
>> [   30.018158] ESI: b7f2055c EDI: b7f10e90 EBP: b7bf9260 ESP: b7bf9208
>> [   30.018190]  DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b
>> [   30.018220]  ? __do_page_fault+0x4e0/0x4e0
>> [   30.018242] Code: 00 8b 03 c1 e8 1a 85 c0 74 be 0f 0b 8d b6 00 00 00 00 
> 8d bc 27 00 00 00 00 55 89 e5 57 56 53 83 ec 08 89 45 f0 89 4d ec 8b 45 f0 <8b> 
> 40 04 89 c1 83 e1 03 83 f9 01 75 71 89 c1 bf 40 00 00 00 83
>> [   30.018415] EIP: __radix_tree_lookup+0x12/0xb0 SS:ESP: 0069:dafd9dd0
>> [   30.018445] CR2: 000000000002ffa8
>> [   30.018472] ---[ end trace c8ba97a241bb2040 ]---
>> 
>> isn't a (presumably indirect) result of
>> 
>> Sep  1 03:06:32.180094 (XEN) d28 L1TF-vulnerable L1e 8000000400000000 - 
> Shadowing
>> 
>> Jürgen's change to avoid split PTE writes would then only be
>> papering over an active issue.
> 
> No, it isn't papering over the issue, but repairing it. See
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=198497 
> 
> which clearly states that this issue has been seen on bare metal, too.
> On Xen its just much more frequent as the timing is different.

Hmm, yes - if the problem exists also on native, then while your fix is
hiding that problem, it's not one in Xen code. Question though is how
valuable this particular test is until the fix has trickled in on the Linux
side.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [xen-unstable test] 127070: regressions - FAIL
       [not found]     ` <5B8D517002000078001E4BA?= =?UTF-8?Q?1@suse.com>
@ 2018-09-03 15:28       ` Juergen Gross
  0 siblings, 0 replies; 5+ messages in thread
From: Juergen Gross @ 2018-09-03 15:28 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel, osstest service owner

On 03/09/18 17:21, Jan Beulich wrote:
>>>> On 03.09.18 at 14:56, <jgross@suse.com> wrote:
>> On 03/09/18 14:44, Jan Beulich wrote:
>>>>>> On 01.09.18 at 23:43, <osstest-admin@xenproject.org> wrote:
>>>> flight 127070 xen-unstable real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/127070/ 
>>>>
>>>> Regressions :-(
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>>  test-amd64-i386-xl-shadow   20 guest-start/debian.repeat fail REGR. vs. 
>> 126854
>>>
>>> I wonder if this
>>>
>>> [   30.017142] BUG: unable to handle kernel paging request at 0002ffa8
>>> [   30.017208] IP: __radix_tree_lookup+0x12/0xb0
>>> [   30.017235] *pdpt = 000000001eca5027 *pde = 0000000000000000 
>>> [   30.017271] Oops: 0000 [#1] SMP
>>> [   30.017293] Modules linked in: ext4 mbcache jbd2
>>> [   30.017352] CPU: 2 PID: 1204 Comm: systemd Not tainted 4.14.67+ #1
>>> [   30.017383] task: df601f80 task.stack: dafd8000
>>> [   30.017411] EIP: __radix_tree_lookup+0x12/0xb0
>>> [   30.017445] EFLAGS: 00010282 CPU: 2
>>> [   30.017468] EAX: 0002ffa4 EBX: b7ed2000 ECX: 00000000 EDX: 01ffffff
>>> [   30.017503] ESI: 00000000 EDI: 00000000 EBP: dafd9de4 ESP: dafd9dd0
>>> [   30.017534]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0069
>>> [   30.017571] CR0: 80050033 CR2: 0002ffa8 CR3: 1eca4000 CR4: 00042660
>>> [   30.017620] Call Trace:
>>> [   30.017642]  radix_tree_lookup_slot+0x11/0x30
>>> [   30.017673]  ? xen_set_pud+0xa0/0xa0
>>> [   30.017699]  find_get_entry+0x1d/0x110
>>> [   30.017723]  pagecache_get_page+0x1f/0x230
>>> [   30.017752]  lookup_swap_cache+0x35/0x110
>>> [   30.017778]  swap_readahead_detect+0x84/0x2f0
>>> [   30.017809]  do_swap_page+0x25b/0x8e0
>>> [   30.017837]  ? wp_page_copy+0x399/0x6b0
>>> [   30.017866]  ? kmap_atomic_prot+0x2b/0x180
>>> [   30.017892]  ? __raw_callee_save_xen_pte_val+0xc/0xc
>>> [   30.017925]  handle_mm_fault+0x468/0x9e0
>>> [   30.017951]  __do_page_fault+0x1ba/0x4e0
>>> [   30.017976]  ? __do_page_fault+0x4e0/0x4e0
>>> [   30.018008]  do_page_fault+0x37/0x100
>>> [   30.018032]  ? __do_page_fault+0x4e0/0x4e0
>>> [   30.018060]  common_exception+0x77/0x7e
>>> [   30.018084] EIP: 0xb7f0d39f
>>> [   30.018101] EFLAGS: 00010246 CPU: 2
>>> [   30.018124] EAX: b7ed2030 EBX: b7f20000 ECX: b7bf91b8 EDX: 00000002
>>> [   30.018158] ESI: b7f2055c EDI: b7f10e90 EBP: b7bf9260 ESP: b7bf9208
>>> [   30.018190]  DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b
>>> [   30.018220]  ? __do_page_fault+0x4e0/0x4e0
>>> [   30.018242] Code: 00 8b 03 c1 e8 1a 85 c0 74 be 0f 0b 8d b6 00 00 00 00 
>> 8d bc 27 00 00 00 00 55 89 e5 57 56 53 83 ec 08 89 45 f0 89 4d ec 8b 45 f0 <8b> 
>> 40 04 89 c1 83 e1 03 83 f9 01 75 71 89 c1 bf 40 00 00 00 83
>>> [   30.018415] EIP: __radix_tree_lookup+0x12/0xb0 SS:ESP: 0069:dafd9dd0
>>> [   30.018445] CR2: 000000000002ffa8
>>> [   30.018472] ---[ end trace c8ba97a241bb2040 ]---
>>>
>>> isn't a (presumably indirect) result of
>>>
>>> Sep  1 03:06:32.180094 (XEN) d28 L1TF-vulnerable L1e 8000000400000000 - 
>> Shadowing
>>>
>>> Jürgen's change to avoid split PTE writes would then only be
>>> papering over an active issue.
>>
>> No, it isn't papering over the issue, but repairing it. See
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=198497 
>>
>> which clearly states that this issue has been seen on bare metal, too.
>> On Xen its just much more frequent as the timing is different.
> 
> Hmm, yes - if the problem exists also on native, then while your fix is
> hiding that problem, it's not one in Xen code. Question though is how
> valuable this particular test is until the fix has trickled in on the Linux
> side.

I'm about to request the patch to be included in stable kernels.

To be more explicit why the patch is fixing the problem:

native_ptep_get_and_clear() is thought to get the old pte contents and
clear the pte atomically. While the implementation via 32-bit
operations was fine regarding races against other updates it was not
fine regarding read accesses after having written the low word and
before clearing the high word: a page fault would detect a non-zero
value in the high word and assume the data being present on some swap
device.

My patch now removes this possible race and the problem can't occur any
longer.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-09-03 15:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-01 21:43 [xen-unstable test] 127070: regressions - FAIL osstest service owner
2018-09-03 12:44 ` Jan Beulich
2018-09-03 12:56   ` Juergen Gross
2018-09-03 15:21     ` Jan Beulich
     [not found] <osstest=ef=bf=bd127070=ef=bf=bdmainreport@xen.org>
     [not found] ` <5?= =?UTF-8?Q?B8D2CC302000078001E492B@prv1=ef=bf=bdmh.provo.novell.com>
     [not found]   ` <96f953?= =?UTF-8?Q?1b-015b-3aec-b53c-7a4628bc82e6@suse.com>
     [not found]     ` <5B8D517002000078001E4BA?= =?UTF-8?Q?1@suse.com>
2018-09-03 15:28       ` Juergen Gross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.