From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Winkler, Tomas" Subject: Re: [PATCH v2 1/4] tpm/tpm_crb: implement tpm crb idle state Date: Mon, 12 Sep 2016 20:34:00 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B542CDFAA@hasmsx108.ger.corp.intel.com> References: <1473670501-29281-1-git-send-email-tomas.winkler@intel.com> <1473670501-29281-2-git-send-email-tomas.winkler@intel.com> <20160912120109.GA957@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542CDCB7@hasmsx108.ger.corp.intel.com> <20160912173902.GC5843@obsidianresearch.com> <20160912201703.GC8889@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160912201703.GC8889-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen , Jason Gunthorpe Cc: "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" List-Id: tpmdd-devel@lists.sourceforge.net > On Mon, Sep 12, 2016 at 11:39:02AM -0600, Jason Gunthorpe wrote: > > On Mon, Sep 12, 2016 at 12:25:21PM +0000, Winkler, Tomas wrote: > > > > > > @pdev: CRB platform device > > > > > > I find pdev here a bit misleading this is not a platform device, > > > also if we want to clean up the variable names this should not be > > > mixed within these patches. > > > > These days within tpm core it means 'parent device' > > That's a better name, agreed. Just the tpm_crb is the low level driver hence it this context it Is not a parent device, the is the device :) Tomas ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev