From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Avri Altman <Avri.Altman@sandisk.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Andy Lutomirski <luto@kernel.org>, Hj?nnev?g <arve@android.com>,
"Michael Ryleev" <gmar@google.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"Christoph Hellwig" <hch@lst.de>,
Yaniv Gardi <ygardi@codeaurora.org>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
Avi Shchislowski <Avi.Shchislowski@sandisk.com>,
Alex Lemberg <Alex.Lemberg@sandisk.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux- <mmc@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem
Date: Sat, 24 Sep 2016 20:30:49 +0000 [thread overview]
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B542EE59B@hasmsx108.ger.corp.intel.com> (raw)
In-Reply-To: <CY4PR02MB2501420649DCBF633584B949E5C80@CY4PR02MB2501.namprd02.prod.outlook.com>
>
>
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Tested-by: Avri Altman <Avri.Altman@sandisk.com>
>
> - mmc - full functionality. One issue found that was fixed on V6: patch V6 2/9.
> - ufs - read & read counter only. Testing is still wip.
>
>
> > +static int rpmb_request_verify(struct rpmb_dev *rdev, struct rpmb_data
> > +*rpmbd) {
>
> Seems excessive - Isn't the standard should be enforced by the device?
Yes the device is responsible to detect the issues in the protocol. The rpmb_request_verify is called only for the managed interface (rpmb_cmd_req) the raw interface (rpm_cmd_seq) is going through. Second, we only check more or less if we can accommodate the request/response into the arguments. If there is a specific issue you see in this check, please let me know.
Thanks
Tomas
next prev parent reply other threads:[~2016-09-24 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 13:22 [PATCH v6 0/9] Replay Protected Memory Block (RPMB) subsystem Tomas Winkler
2016-09-13 13:22 ` [PATCH v6 1/9] rpmb: add " Tomas Winkler
[not found] ` <CAG8K7gRqn_Feu_22WESrS8T_xm-GZ9d0jXGSQi=ssvQepVPtwQ@mail.gmail.com>
2016-09-23 9:38 ` Avri Altman
2016-09-24 20:30 ` Winkler, Tomas [this message]
2016-09-13 13:22 ` [PATCH v6 2/9] rpmb: enable emmc specific read data fixup Tomas Winkler
2016-09-13 13:22 ` [PATCH v6 3/9] rpmb: add sysfs-class ABI documentation Tomas Winkler
2016-09-13 13:22 ` [PATCH v6 4/9] char: rpmb: add device attributes Tomas Winkler
2016-09-13 13:23 ` [PATCH v6 5/9] char: rpmb: provide a user space interface Tomas Winkler
2016-09-13 13:23 ` [PATCH v6 6/9] char: rpmb: add RPMB simulation device Tomas Winkler
2016-09-13 13:23 ` [PATCH v6 7/9] tools rpmb: add RPBM access tool Tomas Winkler
2016-09-13 13:23 ` [PATCH v6 8/9] mmc: block: register RPMB partition with the RPMB subsystem Tomas Winkler
2016-09-13 13:23 ` [PATCH v6 9/9] scsi: ufs: connect to " Tomas Winkler
2016-09-19 12:17 ` [PATCH v6 0/9] Replay Protected Memory Block (RPMB) subsystem Winkler, Tomas
2016-09-20 11:11 ` Greg Kroah-Hartman
2016-09-20 11:58 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B542EE59B@hasmsx108.ger.corp.intel.com \
--to=tomas.winkler@intel.com \
--cc=Alex.Lemberg@sandisk.com \
--cc=Avi.Shchislowski@sandisk.com \
--cc=Avri.Altman@sandisk.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Joao.Pinto@synopsys.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=arve@android.com \
--cc=gmar@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.