From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbcLFKIa convert rfc822-to-8bit (ORCPT ); Tue, 6 Dec 2016 05:08:30 -0500 Received: from mga01.intel.com ([192.55.52.88]:10341 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbcLFKIZ (ORCPT ); Tue, 6 Dec 2016 05:08:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,309,1477983600"; d="scan'208";a="39452276" From: "Winkler, Tomas" To: Greg Kroah-Hartman CC: "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" Subject: RE: [char-misc-next RESEND] mei: bus: enable non-blocking RX Thread-Topic: [char-misc-next RESEND] mei: bus: enable non-blocking RX Thread-Index: AQHSTOHJ9x0SOcMyU0qZaleMKC2kHqD6lSGAgAAhxgA= Date: Tue, 6 Dec 2016 10:08:20 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B5433778D@hasmsx108.ger.corp.intel.com> References: <1480716925-23339-1-git-send-email-tomas.winkler@intel.com> <20161206100503.GA17050@kroah.com> In-Reply-To: <20161206100503.GA17050@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzZiYjZlZWEtM2YwMy00ZjM3LWEwNDUtZGZhOGI0ODFkNjY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InhMMnFLS2UzUXVxYjk2MFM5K0VHcGJrSlhNaWxQTFhGZVVzSVd2akJ5cFU9In0= x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Sat, Dec 03, 2016 at 12:15:25AM +0200, Tomas Winkler wrote: > > From: Alexander Usyskin > > > > Enable non-blocking receive for drivers on mei bus, this allows > > checking for data availability by mei client drivers. This is most > > effective for fixed address clients, that lacks flow control. > > > > This function adds new API function mei_cldev_recv_nonblock(), it > > retuns -EGAIN if function will block. > > > > Signed-off-by: Alexander Usyskin > > Signed-off-by: Tomas Winkler > > --- > > drivers/misc/mei/bus-fixup.c | 4 ++-- > > drivers/misc/mei/bus.c | 31 +++++++++++++++++++++++++++++-- > > drivers/misc/mei/mei_dev.h | 7 ++++++- > > include/linux/mei_cl_bus.h | 6 ++++-- > > 4 files changed, 41 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/misc/mei/bus-fixup.c > > b/drivers/misc/mei/bus-fixup.c index 7f2cef9011ae..18e05ca7584f 100644 > > --- a/drivers/misc/mei/bus-fixup.c > > +++ b/drivers/misc/mei/bus-fixup.c > > @@ -141,7 +141,7 @@ static int mei_osver(struct mei_cl_device *cldev) > > if (ret < 0) > > return ret; > > > > - ret = __mei_cl_recv(cldev->cl, buf, length); > > + ret = __mei_cl_recv(cldev->cl, buf, length, 0); > > if (ret < 0) > > return ret; > > > > @@ -272,7 +272,7 @@ static int mei_nfc_if_version(struct mei_cl *cl, > > return -ENOMEM; > > > > ret = 0; > > - bytes_recv = __mei_cl_recv(cl, (u8 *)reply, if_version_length); > > + bytes_recv = __mei_cl_recv(cl, (u8 *)reply, if_version_length, 0); > > I still don't like this, as here are two examples of you having to somehow > mentally keep track of the "mode" of what is going on. I know, but I don't have better solution. We try to keep the code documented as much as possible. > a> But it's your code, you have to maintain it, not me, good luck! Fair enough Tomas