From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S939470AbdAJSMu convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 13:12:50 -0500
Received: from mga05.intel.com ([192.55.52.43]:55310 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1762622AbdAJSMO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 13:12:14 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; 
   d="scan'208";a="211791261"
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Chen, Yu C" <yu.c.chen@intel.com>
Subject: RE: [char-misc for 4.10-rc4] mei: bus: enable OS version only for
 SPT and newer
Thread-Topic: [char-misc for 4.10-rc4] mei: bus: enable OS version only for
 SPT and newer
Thread-Index: AQHSaov/CAJBphK2BU+UWV3sdgNUhKExzW0AgAA2waA=
Date: Tue, 10 Jan 2017 18:12:06 +0000
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B543797E5@hasmsx108.ger.corp.intel.com>
References: <1483978529-8134-1-git-send-email-tomas.winkler@intel.com>
 <20170110165310.GA15679@kroah.com>
In-Reply-To: <20170110165310.GA15679@kroah.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.184.70.11]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 
> On Mon, Jan 09, 2017 at 06:15:29PM +0200, Tomas Winkler wrote:
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > Sending OS version for support of TPM2_ChangeEPS() is required only
> > for SPT FW (HMB version 2.0) and newer.
> > On older platforms the command should be just ignored by the firmware
> > but some older platforms misbehave so it's safer to send the command
> > only if required.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=192051
> > Fixes: 94a621b0b8aa (mei: send OS type to the FW)
> 
> That's not a valid sha1 :(
> 
> Please fix it up and resend, after figuring out where you got that odd number
> from.

Sorry for that, the sha1 is form our internal branch. 
Will need to add some script that checks that before sending, as that happened in the past already.

Thanks
Tomas