From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F39CC004D2 for ; Tue, 2 Oct 2018 05:00:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0A7A208AE for ; Tue, 2 Oct 2018 05:00:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0A7A208AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726572AbeJBLlm convert rfc822-to-8bit (ORCPT ); Tue, 2 Oct 2018 07:41:42 -0400 Received: from mga14.intel.com ([192.55.52.115]:40244 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbeJBLlm (ORCPT ); Tue, 2 Oct 2018 07:41:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 22:00:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,330,1534834800"; d="scan'208";a="96659275" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 01 Oct 2018 21:58:29 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 1 Oct 2018 21:58:29 -0700 Received: from hasmsx105.ger.corp.intel.com (10.184.198.19) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 1 Oct 2018 21:58:28 -0700 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.28]) by HASMSX105.ger.corp.intel.com ([169.254.1.191]) with mapi id 14.03.0319.002; Tue, 2 Oct 2018 07:58:26 +0300 From: "Winkler, Tomas" To: Jarkko Sakkinen CC: Jason Gunthorpe , Nayna Jain , "Usyskin, Alexander" , "Struk, Tadeusz" , "linux-integrity@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "roberto.sassu@huawei.com" Subject: RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c Thread-Topic: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c Thread-Index: AQHUWeozFz0QOr+BiUiSikU4mA0ywaULXotQ Date: Tue, 2 Oct 2018 04:58:25 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D9DFAA5@hasmsx109.ger.corp.intel.com> References: <20180928223035.14471-1-tomas.winkler@intel.com> <20180928223035.14471-13-tomas.winkler@intel.com> <20181002005208.GH23753@linux.intel.com> In-Reply-To: <20181002005208.GH23753@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDZjMzZhZDYtOTE2ZC00MzJkLWE1NzctOWYzMjNlYTFkNjM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFNLeFNcL05mXC9XQWF1U0V5NUVPckkzMTR5dW1KdXhNN3FsdWc5SFpoNjRwSjdlTnNGSXN3QVh4RVdVQUlNMDlEIn0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.255.196.9] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > > by tpm-interface.c. It wraps the original open code implementation. > > The original original tpm2_pcr_extend() function is renamed to > > __tpm2_pcr_extend() and made static, it is called only from new > > tpm2_pcr_extend(). > > > > Fix warnings in __tpm2_pcr_extend() > > tpm2-cmd.c:251:16: warning: comparison between signed and unsigned > > integer expressions [-Wsign-compare] > > tpm2-cmd.c:252:17: warning: comparison between signed and unsigned > > integer expressions [-Wsign-compare] > > > > Signed-off-by: Tomas Winkler > > We do not want the signature change, especially because as we are working > on getting Roberto's changes in and also because it has absolutely a zero > gain. Who cares if those functions take different parameters? I don't. Yes, we do care this series tries to have a clean cut between 1.x and 2.x specs. Please, let's finish one transformation and then move to another. I understand that Roberto will have to rebase anyhow, if this series goes in first, if this is hard I can do it myself, it's trivial. Tomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:40244 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbeJBLlm (ORCPT ); Tue, 2 Oct 2018 07:41:42 -0400 From: "Winkler, Tomas" To: Jarkko Sakkinen CC: Jason Gunthorpe , Nayna Jain , "Usyskin, Alexander" , "Struk, Tadeusz" , "linux-integrity@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "roberto.sassu@huawei.com" Subject: RE: [PATCH v5 12/21] tpm: move pcr extend code to tpm2-cmd.c Date: Tue, 2 Oct 2018 04:58:25 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D9DFAA5@hasmsx109.ger.corp.intel.com> References: <20180928223035.14471-1-tomas.winkler@intel.com> <20180928223035.14471-13-tomas.winkler@intel.com> <20181002005208.GH23753@linux.intel.com> In-Reply-To: <20181002005208.GH23753@linux.intel.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-integrity-owner@vger.kernel.org List-ID: > > On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > > by tpm-interface.c. It wraps the original open code implementation. > > The original original tpm2_pcr_extend() function is renamed to > > __tpm2_pcr_extend() and made static, it is called only from new > > tpm2_pcr_extend(). > > > > Fix warnings in __tpm2_pcr_extend() > > tpm2-cmd.c:251:16: warning: comparison between signed and unsigned > > integer expressions [-Wsign-compare] > > tpm2-cmd.c:252:17: warning: comparison between signed and unsigned > > integer expressions [-Wsign-compare] > > > > Signed-off-by: Tomas Winkler > > We do not want the signature change, especially because as we are working > on getting Roberto's changes in and also because it has absolutely a zero > gain. Who cares if those functions take different parameters? I don't. Yes, we do care this series tries to have a clean cut between 1.x and 2.x specs. Please, let's finish one transformation and then move to another. I understand that Roberto will have to rebase anyhow, if this series goes in first, if this is hard I can do it myself, it's trivial. Tomas