From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 3/3] xen/vcpu: Rework sanity checks in vcpu_create() Date: Fri, 07 Sep 2018 04:15:23 -0600 Message-ID: <5B924FBB02000078001E64B5@prv1-mh.provo.novell.com> References: <1536261934-1236-1-git-send-email-andrew.cooper3@citrix.com> <1536261934-1236-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1536261934-1236-4-git-send-email-andrew.cooper3@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Julien Grall , Stefano Stabellini , Wei Liu , Xen-devel , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDA2LjA5LjE4IGF0IDIxOjI1LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gV2hpbGUgdjAgbXVzdCBiZSB0aGUgZmlyc3QgYWxsb2NhdGVkIHZjcHUgZm9yIGZvcl9l YWNoX3ZjcHUoKSB0byB3b3JrLCBpdAo+IGlzbid0IGEgcmVxdWlyZW1lbnQgZm9yIHRoZSB0aHJl YWRpbmcgdGhlIHZjcHUgaW50byB0aGUgbGlua2VkIGxpc3QsIHNvIHVwZGF0ZQo+IHRoZSB0aHJl YWRpbmcgY29kZSB0byBiZSBtb3JlIGdlbmVyaWMsIGFuZCBhZGQgYSBjb21tZW50IGV4cGxhaW5p bmcgd2h5IHdlCj4gbmVlZCB0byBzZWFyY2ggZm9yIHByZXZfaWQuCgpJJ20gYWZyYWlkIEkgY2Fu J3QgYnJpbmcgdGhpcyBpbiBsaW5lIHdpdGggdGhlIGNvZGUgY2hhbmdlOgoKPiBAQCAtMTc4LDE1 ICsxOTAsMjcgQEAgc3RydWN0IHZjcHUgKnZjcHVfY3JlYXRlKAo+ICAgICAgaWYgKCBhcmNoX3Zj cHVfY3JlYXRlKHYpICE9IDAgKQo+ICAgICAgICAgIGdvdG8gZmFpbF9zY2hlZDsKPiAgCj4gKyAg ICAvKiBJbnNlcnQgdGhlIHZjcHUgaW50byB0aGUgZG9tYWluJ3MgdmNwdSBsaXN0LiAqLwo+ICAg ICAgZC0+dmNwdVt2Y3B1X2lkXSA9IHY7Cj4gICAgICBpZiAoIHZjcHVfaWQgIT0gMCApCgpUaGVy ZSBzdGlsbCBpcyB0aGlzIGNvbmRpdGlvbmFsLCBhbmQgeW91IGRvbid0IGFkZCBhbnkgZWxzZSB0 byBpdC4gSGVuY2UKYWZhaWNzIGlmIHZDUFUgMCB3YXMgY3JlYXRlZCBhZnRlciB2Q1BVIDEsIHZD UFUgMCdzIG5leHRfaW5fbGlzdAp3b3VsZCBub3QgYmUgbWFkZSBwb2ludCB0byB2Q1BVIDEuIFRo YXQncyBub3Qgd2hhdCBJJ2QgY2FsbCAibW9yZQpnZW5lcmljIi4KCkJ1dCB0aGUgcXVlc3Rpb24g aXMgd2hhdCB1c2UgdGhlIG5leHRfaW5fbGlzdCBmaWVsZCBpcyBpbiB0aGUgZmlyc3QgcGxhY2Us CndoZW4gdGhlIGVudHJpZXMgdGhlcmUgYXJlIHNvcnRlZCBieSBJRCBhbnl3YXk6IFdoeSBjYW4n dCB3ZQpzaW1wbHkgdXNlIHYtPmRvbWFpbi0+dmNwdVtdIGluc3RlYWQ/IEluIHRoZSBjb21tb24g Y2FzZQp2LT5kb21haW4tPnZjcHVbdi0+dmNwdV9pZCsxXSBpcyBub3QgZ29pbmcgdG8gYmUgTlVM TCBhbnl3YXksCmFuZCBJIGRvbid0IHRoaW5rIGZvcl9lYWNoX3ZjcHUoKSB3b3VsZCBiZWNvbWUg dGhhdCBtdWNoIG1vcmUKY29tcGxpY2F0ZWQgdGhhdCB3YXkuCgo+ICAgICAgewo+ICAgICAgICAg IGludCBwcmV2X2lkID0gdi0+dmNwdV9pZCAtIDE7Cj4gKwo+ICsgICAgICAgIC8qCj4gKyAgICAg ICAgICogTG9vayBmb3IgdGhlIHByZXZpb3VzbHkgYWxsb2NhdGVkIHZjcHUsIGFuZCBzcGxpY2Ug aW50byB0aGUKPiArICAgICAgICAgKiBuZXh0X2luX2xpc3Qgc2luZ2xlIGxpbmtlZCBsaXN0LgoK SSdtIGFsc28gbm90IHZlcnkgaGFwcHkgYWJvdXQgdGhlIHVzZSBvZiAicHJldmlvdXNseSIgaGVy ZTogVGhpcyAodG8KbWUgYXMgYSBub24tbmF0aXZlIHNwZWFrZXIpIGluIG5vIHdheSBtZWFucyAi dGhlIG9uZSB3aXRoIHRoZSBuZXh0Cmxvd2VzdCBJRCIuCgpKYW4KCj4gKyAgICAgICAgICogQWxs IGRvbWFpbnMgb3RoZXIgdGhhbiBJRExFIGhhdmUgdGlnaHRseSBwYWNrZWQgdmNwdV9pZCdzLiAg SURMRQo+ICsgICAgICAgICAqIHZjcHVfaWQncyBhcmUgZGVyaXZlZCBmcm9tIGhhcmR3YXJlIENQ VSBpZCdzIGFuZCBjYW4gYmUgc3BhcnNlLgo+ICsgICAgICAgICAqLwo+ICAgICAgICAgIHdoaWxl ICggKHByZXZfaWQgPj0gMCkgJiYgKGQtPnZjcHVbcHJldl9pZF0gPT0gTlVMTCkgKQo+ICAgICAg ICAgICAgICBwcmV2X2lkLS07Cj4gLSAgICAgICAgQlVHX09OKHByZXZfaWQgPCAwKTsKPiAtICAg ICAgICB2LT5uZXh0X2luX2xpc3QgPSBkLT52Y3B1W3ByZXZfaWRdLT5uZXh0X2luX2xpc3Q7Cj4g LSAgICAgICAgZC0+dmNwdVtwcmV2X2lkXS0+bmV4dF9pbl9saXN0ID0gdjsKPiArCj4gKyAgICAg ICAgaWYgKCBwcmV2X2lkID49IDAgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgdi0+bmV4 dF9pbl9saXN0ID0gZC0+dmNwdVtwcmV2X2lkXS0+bmV4dF9pbl9saXN0Owo+ICsgICAgICAgICAg ICBkLT52Y3B1W3ByZXZfaWRdLT5uZXh0X2luX2xpc3QgPSB2Owo+ICsgICAgICAgIH0KPiAgICAg IH0KPiAgCj4gICAgICAvKiBNdXN0IGJlIGNhbGxlZCBhZnRlciBtYWtpbmcgbmV3IHZjcHUgdmlz aWJsZSB0byBmb3JfZWFjaF92Y3B1KCkuICovCj4gLS0gCj4gMi4xLjQKCgoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs