All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: george.dunlap@citrix.com
Cc: Tim Deegan <tim@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	andrii.anisov@gmail.com, Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	"andrii_anisov@epam.com" <andrii_anisov@epam.com>
Subject: Re: [PATCH] perfc: Print a system time in a convenient format
Date: Tue, 11 Sep 2018 03:37:32 -0600	[thread overview]
Message-ID: <5B978CDC02000078001E71DC@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <4a4d7ad8-be0d-ee52-5657-fd90eaaab420@citrix.com>

>>> On 11.09.18 at 11:28, <george.dunlap@citrix.com> wrote:
> On 09/11/2018 10:18 AM, Jan Beulich wrote:
>>>>> On 11.09.18 at 11:15, <andrew.cooper3@citrix.com> wrote:
>>> On 11/09/18 10:10, Jan Beulich wrote:
>>>>>>> On 11.09.18 at 10:50, <andrii_anisov@epam.com> wrote:
>>>>> On 11.09.18 11:27, Jan Beulich wrote:
>>>>>> NAK, for two reasons: I'm not of the opinion that reading a 15 or more
>>>>>> digit decimal number without any separators is any easier than the
>>>>>> current format.
>>>>> It's quite subjective. IMHO timestamps measured in ns easier to 
>>>>> understand in decimals rather than in separated 32-bit hex-es. No matter 
>>>>> how many digital number they have.
>>>> It is subjective, yes, but in such a case you even more so need to
>>>> demonstrate a change is an overall improvement.
>>>>
>>>>> Even post processing of perfc output is easier in case of decimal 
>>>>> timestamps. You should not parse hexes and odd separators to calculate 
>>>>> the time elapsed between two samples.
>>>> Post processing usually uses scrips for parsing - I don't think it's
>>>> overly complicated to have a script convert the number into
>>>> basically any format you want.
>>>
>>> Right, but this particular mis-pattern wants fixing.  It is simply
>>> confusing to have a single number formatted with a colon inbetween.
>> 
>> What other separator do you suggest? I consider it quite helpful
>> to have one when there are more than about 10 digits. (I'd also
>> be fine, btw, to have the time printed in decimal, but then
>> perhaps with ms granularity and 6 digits for the fractional part.)
> 
> * We clearly already have a standard way of printing stime
> * The places where a colon is used are non-standard, and thus wrong
> * His patch makes an improvement by fixing the non-standard timestamp
> printing.
> 
> If you're not happy with the current PRI_stime, then it should be on you
> to propose and code up a change, not Andrii (unless he feels
> particularly motivated to do so).

Excuse me, but no. I'm sure there are places where PRI_stime is
fine to use as is, or there are people thinking so. But to me
personally the proposed change is the opposite of an improvement,
and hence I think I'm perfectly fine to object without going and
creating a counter proposal patch myself. If I'm the only one, I
can still be talked into accepting the change, or outvoted.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-09-11  9:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11  6:53 [PATCH] perfc: Print a system time in a convenient format Andrii Anisov
2018-09-11  8:27 ` Jan Beulich
2018-09-11  8:50   ` Andrii Anisov
2018-09-11  9:10     ` Jan Beulich
2018-09-11  9:15       ` Andrew Cooper
2018-09-11  9:18         ` Jan Beulich
2018-09-11  9:20           ` Andrew Cooper
2018-09-11  9:28             ` Jan Beulich
2018-09-11  9:21           ` Andrii Anisov
2018-09-11  9:30             ` Jan Beulich
2018-09-11  9:49               ` Andrii Anisov
2018-09-11 14:04                 ` Andrii Anisov
2018-09-11 14:27                   ` George Dunlap
2018-09-11 14:33                   ` Jan Beulich
2018-09-11  9:28           ` George Dunlap
2018-09-11  9:37             ` Jan Beulich [this message]
2018-09-11  9:19       ` Andrii Anisov
2018-09-11  9:24     ` George Dunlap
2018-09-11  9:33       ` Jan Beulich
2018-09-11  9:50         ` Andrii Anisov
2018-09-11  9:51         ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B978CDC02000078001E71DC@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=andrii.anisov@gmail.com \
    --cc=andrii_anisov@epam.com \
    --cc=george.dunlap@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.