All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
	george.dunlap@citrix.com
Subject: Re: [PATCH v9 7/7] vtd: add lookup_page method to iommu_ops
Date: Tue, 18 Sep 2018 07:20:15 -0600	[thread overview]
Message-ID: <5BA0FB8F02000078001E9785@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180913152128.6114-9-paul.durrant@citrix.com>

>>> On 13.09.18 at 17:21, <paul.durrant@citrix.com> wrote:
> @@ -179,9 +181,17 @@ struct iommu_ops {
>  #endif /* HAS_PCI */
>  
>      void (*teardown)(struct domain *d);
> +
> +    /*
> +     * This block of operations must be appropriately locked against each
> +     * other to have meaningful results.
> +     */
>      int __must_check (*map_page)(struct domain *d, dfn_t dfn, mfn_t mfn,
>                                   unsigned int flags);
>      int __must_check (*unmap_page)(struct domain *d, dfn_t dfn);
> +    int __must_check (*lookup_page)(struct domain *d, dfn_t dfn, mfn_t *mfn,
> +                                    unsigned int *flags);

I'm afraid the comment is ambiguous: It may mean the implementations
of the hooks have to have suitable locking in place, or callers have to
take care of locking. I think the latter is meant, which I think needs to
be made explicit. With that
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-09-18 13:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 15:21 [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up Paul Durrant
2018-09-13 15:21 ` [PATCH v9 1/7] iommu: introduce the concept of DFN Paul Durrant
2018-09-14  2:27   ` Tian, Kevin
2018-09-13 15:21 ` [PATCH v9 2/7] iommu: make use of type-safe DFN and MFN in exported functions Paul Durrant
2018-09-13 15:21 ` [PATCH v9 3/7] iommu: push use of type-safe DFN and MFN into iommu_ops Paul Durrant
2018-09-13 15:21 ` [PATCH v9 4/7] iommu: don't domain_crash() inside iommu_map/unmap_page() Paul Durrant
2018-09-13 15:21 ` [PATCH v9 5/7] memory: add check_get_page_from_gfn() as a wrapper Paul Durrant
2018-09-18 13:16   ` Jan Beulich
2018-09-18 14:03     ` Paul Durrant
2018-09-18 14:51       ` Jan Beulich
2018-09-18 16:37         ` Paul Durrant
2018-09-19  6:03           ` Jan Beulich
2018-09-19  7:56             ` Paul Durrant
2018-09-19  8:01               ` Paul Durrant
2018-09-19  8:31                 ` Jan Beulich
2018-09-19  8:59                   ` Roger Pau Monné
2018-09-19 16:13                     ` Wei Liu
2018-09-19  8:34               ` Jan Beulich
2018-09-19  8:54                 ` Paul Durrant
2018-09-19  9:22                   ` Jan Beulich
2018-09-19  9:24                     ` Paul Durrant
2018-09-19  9:29                     ` Roger Pau Monné
     [not found]                       ` <304E51960200007575B6CDDB@prv1-mh.provo.novell.com>
2018-09-19  9:34                         ` Jan Beulich
2018-09-13 15:21 ` [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops Paul Durrant
2018-09-13 15:22   ` Paul Durrant
2018-09-13 15:21 ` [PATCH v9 6/7] vtd: add missing check for shared EPT Paul Durrant
2018-09-14  2:29   ` Tian, Kevin
2018-09-13 15:21 ` [PATCH v9 7/7] vtd: add lookup_page method to iommu_ops Paul Durrant
2018-09-14  2:30   ` Tian, Kevin
2018-09-18 13:20   ` Jan Beulich [this message]
2018-09-18 14:00     ` Paul Durrant
2018-09-18 14:50       ` Jan Beulich
2018-09-18 16:03         ` Paul Durrant
2018-09-13 15:24 ` [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BA0FB8F02000078001E9785@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=george.dunlap@citrix.com \
    --cc=kevin.tian@intel.com \
    --cc=paul.durrant@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.