All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	george.dunlap@citrix.com,
	Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: Current staging crashes on boot on an AMD EPYC 7251
Date: Fri, 21 Sep 2018 04:41:16 -0600	[thread overview]
Message-ID: <5BA4CACC02000078001EA7F2@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180921101545.th2ncxhjg4qk6rfu@mac.bytemobile.com>

>>> On 21.09.18 at 12:15, <roger.pau@citrix.com> wrote:
> On Fri, Sep 21, 2018 at 12:45:18PM +0300, Razvan Cojocaru wrote:
>> While doing my best to make sure what I understand to be George's
>> proposed changes for the altp2m series I've tried to boot Xen staging on
>> an AMD host, but it crashes in an unrelated place (I've tested this by
>> stashing my changes and booting a "vanilla" staging):
> 
> Can you apply the following debug patch and paste the full boot log?

Well, not having provided the full boot log right away is clearly
unhelpful, as from that alone we should be able to tell what's
going on here (unless we e.g. screw up the E820 map somewhere).
However, it is already clear that ...

> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -465,6 +465,8 @@ unsigned int page_get_ram_type(mfn_t mfn)
>              break;
>  
>          default:
> +printk("[%#lx, %#lx) type: %u\n", e820.map[i].addr,
> +       e820.map[i].addr + e820.map[i].size, e820.map[i].type);
>              ASSERT_UNREACHABLE();

... this assertion needs to go away, as it would trigger for both
E820_TYPE_PMEM and E820_TYPE_PRAM (using the Linux
naming), or the unnamed type 6 mentioned in their header. It
would also trigger for types which may get added down the road.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-09-21 10:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21  9:45 Current staging crashes on boot on an AMD EPYC 7251 Razvan Cojocaru
2018-09-21 10:15 ` Roger Pau Monné
2018-09-21 10:41   ` Jan Beulich [this message]
2018-09-21 10:48     ` Razvan Cojocaru
2018-09-21 11:00       ` Jan Beulich
2018-09-21 11:05         ` Roger Pau Monné
2018-09-21 11:18           ` Roger Pau Monné
2018-09-21 11:51             ` Razvan Cojocaru
2018-09-21 12:03             ` Jan Beulich
2018-09-21 11:56           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BA4CACC02000078001EA7F2@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=george.dunlap@citrix.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.