From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] xen: make opt_xen_console true before console initialisation
Date: Fri, 28 Sep 2018 10:05:21 -0600 [thread overview]
Message-ID: <5BAE514102000078001ECFF0@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20180928155327.ecbrkbcny7luwqxg@zion.uk.xensource.com>
>>> On 28.09.18 at 17:53, <wei.liu2@citrix.com> wrote:
> At the moment the ordering of the options matter, which means if "xen"
> is not the first option we can lose output.
>
> I think one easy way of improving is to parse opt_console twice. The
> first time solely looks for "xen" and the second time parses the rest
> options.
What's wrong with making the variable a tristate, and move your
set-to-false after the parsing loop? If the user said "false" for the
option, then they apparently don't care much about the output.
But yes, what you suggest is an option as well.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-28 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 8:24 [PATCH 0/2] Minor improvement to early boot code Wei Liu
2018-09-28 8:24 ` [PATCH 1/2] x86: make sure module array is large enough in pvh-boot.c Wei Liu
2018-09-28 15:06 ` Jan Beulich
2018-09-28 15:13 ` Wei Liu
2018-09-28 8:24 ` [PATCH 2/2] xen: make opt_xen_console true before console initialisation Wei Liu
2018-09-28 15:08 ` Jan Beulich
2018-09-28 15:12 ` Wei Liu
2018-09-28 15:13 ` Andrew Cooper
2018-09-28 15:16 ` Wei Liu
2018-09-28 15:19 ` Jan Beulich
2018-09-28 15:23 ` Wei Liu
2018-09-28 15:53 ` Wei Liu
2018-09-28 16:05 ` Jan Beulich [this message]
2018-09-28 16:19 ` Wei Liu
2018-09-28 16:55 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BAE514102000078001ECFF0@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.