All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>,
	george.dunlap@citrix.com, Jun Nakajima <jun.nakajima@intel.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH v14 4/9] iommu: don't domain_crash() inside iommu_map/unmap_page()
Date: Fri, 05 Oct 2018 01:33:07 -0600	[thread overview]
Message-ID: <5BB713B302000078001EEA3E@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <456a887cbf714c2f84c2548168df1b97@AMSPEX02CL03.citrite.net>

>>> On 04.10.18 at 18:36, <Paul.Durrant@citrix.com> wrote:
> I still think an implicit domain_crash() doesn't really belong in something 
> that looks like a straightforward wrapper around a per-implementation jump 
> table. How about iommu_map/unmap_may_crash() instead to highlight the 
> semantic?

If anything then the other way around, i.e. iommu_unmap_no_crash(),
such that only callers who explicitly mean to deal with the crashing
themselves would use the otherwise insecure variant.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-10-05  7:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 10:45 [PATCH v14 0/9] paravirtual IOMMU pre-requisites and clean-up Paul Durrant
2018-10-04 10:45 ` [PATCH v14 1/9] iommu: introduce the concept of DFN Paul Durrant
2018-10-04 10:45 ` [PATCH v14 2/9] iommu: make use of type-safe DFN and MFN in exported functions Paul Durrant
2018-10-04 15:14   ` George Dunlap
2018-10-04 10:45 ` [PATCH v14 3/9] iommu: push use of type-safe DFN and MFN into iommu_ops Paul Durrant
2018-10-04 13:04   ` Paul Durrant
2018-10-04 13:07     ` Julien Grall
2018-10-04 10:45 ` [PATCH v14 4/9] iommu: don't domain_crash() inside iommu_map/unmap_page() Paul Durrant
2018-10-04 16:29   ` George Dunlap
2018-10-04 16:36     ` Paul Durrant
2018-10-05  7:33       ` Jan Beulich [this message]
2018-10-05  9:02         ` Paul Durrant
     [not found]           ` <F5DD545D-610B-40C7-827C-4CEAA2DF5F04@citrix.com>
     [not found]             ` <8B147463-7834-4525-AC10-36922338876F@citrix.com>
     [not found]               ` <b6add5ff3b6647eaab63265dbaf923bd@AMSPEX02CL03.citrite.net>
2018-10-05 10:31                 ` Paul Durrant
     [not found]                 ` <28341D09-548F-460C-8B22-43CA61EA1308@citrix.com>
2018-10-05 10:37                   ` George Dunlap
2018-10-05 10:38                   ` Paul Durrant
2018-10-05 11:17                     ` Jan Beulich
2018-10-05 11:44                       ` Paul Durrant
2018-10-04 10:45 ` [PATCH v14 5/9] memory: add check_get_page_from_gfn() as a wrapper Paul Durrant
2018-10-04 16:02   ` George Dunlap
2018-10-04 10:45 ` [PATCH v14 6/9] vtd: add missing check for shared EPT Paul Durrant
2018-10-04 10:45 ` [PATCH v14 7/9] vtd: add lookup_page method to iommu_ops Paul Durrant
2018-12-24 15:15   ` Andrew Cooper
2019-01-03  8:58     ` Paul Durrant
2018-10-04 10:45 ` [PATCH v14 8/9] mm / iommu: include need_iommu() test in iommu_use_hap_pt() Paul Durrant
2018-10-04 14:02   ` Jan Beulich
2018-10-04 16:23   ` George Dunlap
2018-10-05 16:03   ` Wei Liu
2018-10-05 16:13     ` Paul Durrant
2018-10-04 10:45 ` [PATCH v14 9/9] mm / iommu: split need_iommu() into has_iommu_pt() and need_iommu_pt_sync() Paul Durrant
2018-10-04 14:11   ` Jan Beulich
2018-10-04 16:23   ` George Dunlap
2018-10-04 17:15   ` Julien Grall
2018-10-05 14:50   ` Jan Beulich
2018-10-05 15:19     ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BB713B302000078001EEA3E@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=paul.durrant@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.