All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>, Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <stefanos@xilinx.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel@lists.xen.org, Julien Grall <julien.grall@arm.com>,
	"andrii_anisov@epam.com" <andrii_anisov@epam.com>
Subject: Re: [PATCH v4 21/23] xen/vpl011: buffer out chars when the backend is xen
Date: Mon, 08 Oct 2018 03:41:36 -0600	[thread overview]
Message-ID: <5BBB265002000078001EF70A@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1538765251-25256-21-git-send-email-sstabellini@kernel.org>

>>> On 05.10.18 at 20:47, <sstabellini@kernel.org> wrote:
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -406,6 +406,13 @@ static void dump_console_ring_key(unsigned char key)
>   */
>  static unsigned int __read_mostly console_rx = 0;
>  
> +struct domain *console_input_domain(void)
> +{
> +    if ( console_rx == 0 )
> +            return NULL;
> +    return get_domain_by_id(console_rx - 1);

This acquires a domain reference, yet I can't see that reference
getting dropped anywhere in the caller.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-10-08  9:41 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 18:47 [PATCH v4 00/23] dom0less step1: boot multiple domains from device tree Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 01/23] xen: allow console_io hypercalls from certain DomUs Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 02/23] xen/arm: extend device tree based multiboot protocol Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 03/23] xen/arm: document dom0less Stefano Stabellini
2018-10-09 11:52   ` Julien Grall
2018-10-16  7:58     ` Lars Kurth
2018-10-22 23:58       ` Stefano Stabellini
2018-10-23  0:12     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 04/23] xen/arm: increase MAX_MODULES Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 05/23] xen/arm: introduce bootcmdlines Stefano Stabellini
2018-10-09 13:24   ` Julien Grall
2018-10-23  1:59     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 06/23] xen/arm: don't add duplicate boot modules, introduce domU flag Stefano Stabellini
2018-10-09 13:35   ` Julien Grall
2018-10-19 23:36     ` Stefano Stabellini
2018-10-20 12:10       ` Julien Grall
2018-10-05 18:47 ` [PATCH v4 07/23] xen/arm: probe domU kernels and initrds Stefano Stabellini
2018-10-15 14:27   ` Julien Grall
2018-10-20  0:42     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 08/23] xen/arm: rename get_11_allocation_size to get_allocation_size Stefano Stabellini
2018-10-15 14:28   ` Julien Grall
2018-10-05 18:47 ` [PATCH v4 09/23] xen/arm: rename allocate_memory to allocate_memory_11 Stefano Stabellini
2018-10-15 14:29   ` Julien Grall
2018-10-05 18:47 ` [PATCH v4 10/23] xen/arm: introduce allocate_memory Stefano Stabellini
2018-10-15 14:43   ` Julien Grall
2018-10-19 22:28     ` Stefano Stabellini
2018-10-20 11:58       ` Julien Grall
2018-10-22 23:53         ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 11/23] xen/arm: refactor construct_dom0 Stefano Stabellini
2018-10-15 14:49   ` Julien Grall
2018-10-17 15:06     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 12/23] xen/arm: introduce create_domUs Stefano Stabellini
2018-10-15 15:05   ` Julien Grall
2018-10-19 22:37     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 13/23] xen/arm: implement construct_domU Stefano Stabellini
2018-10-15 15:15   ` Julien Grall
2018-10-19 22:53     ` Stefano Stabellini
2018-10-20 12:01       ` Julien Grall
2018-10-22 19:46         ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 14/23] xen/arm: generate a simple device tree for domUs Stefano Stabellini
2018-10-15 15:24   ` Julien Grall
2018-10-17 15:09     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 15/23] xen/arm: make set_interrupt_ppi able to handle non-PPI Stefano Stabellini
2018-10-15 15:25   ` Julien Grall
2018-10-05 18:47 ` [PATCH v4 16/23] xen/arm: generate vpl011 node on device tree for domU Stefano Stabellini
2018-10-15 15:47   ` Julien Grall
2018-10-17 14:59     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 17/23] xen/arm: introduce a union in vpl011 Stefano Stabellini
2018-10-15 15:49   ` Julien Grall
2018-10-05 18:47 ` [PATCH v4 18/23] xen/arm: refactor vpl011_data_avail Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 19/23] xen/arm: Allow vpl011 to be used by DomU Stefano Stabellini
2018-10-15 15:56   ` Julien Grall
2018-10-05 18:47 ` [PATCH v4 20/23] xen: support console_switching between Dom0 and DomUs on ARM Stefano Stabellini
2018-10-08  9:50   ` Jan Beulich
2018-10-19 23:10     ` Stefano Stabellini
2018-10-25  9:37       ` Jan Beulich
2018-10-05 18:47 ` [PATCH v4 21/23] xen/vpl011: buffer out chars when the backend is xen Stefano Stabellini
2018-10-08  9:41   ` Jan Beulich [this message]
2018-10-19 23:20     ` Stefano Stabellini
2018-10-20 12:07       ` Julien Grall
2018-10-22 23:46         ` Stefano Stabellini
2018-10-15 16:10   ` Julien Grall
2018-10-17 15:24     ` Stefano Stabellini
2018-10-05 18:47 ` [PATCH v4 22/23] xen/arm: move kernel.h to asm-arm/ Stefano Stabellini
2018-10-15 16:17   ` Julien Grall
2018-10-17 14:42     ` Stefano Stabellini
2018-10-17 16:11       ` Julien Grall
2018-10-17 16:26         ` Andrew Cooper
2018-10-19 21:54         ` Stefano Stabellini
2018-10-20 10:49           ` Julien Grall
2018-10-05 18:47 ` [PATCH v4 23/23] xen/arm: split domain_build.c Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BBB265002000078001EF70A@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=andrii_anisov@epam.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=stefanos@xilinx.com \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.