From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch
Date: Tue, 30 Oct 2018 09:52:56 -0600 [thread overview]
Message-ID: <5BD87E5802000078001F6678@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20181030154623.f6gwtwlgzgedwav6@zion.uk.xensource.com>
>>> On 30.10.18 at 16:46, <wei.liu2@citrix.com> wrote:
> On Tue, Oct 30, 2018 at 09:40:17AM -0600, Jan Beulich wrote:
>> >>> On 30.10.18 at 16:32, <wei.liu2@citrix.com> wrote:
>> > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote:
>> >> >>> On 22.10.18 at 14:58, <andrew.cooper3@citrix.com> wrote:
>> >> > --- a/xen/common/efi/boot.c
>> >> > +++ b/xen/common/efi/boot.c
>> >> > @@ -487,6 +487,7 @@ static EFI_FILE_HANDLE __init
> get_parent_handle(EFI_LOADED_IMAGE *loaded_image,
>> >> > CHAR16 **leaf)
>> >> > {
>> >> > static EFI_GUID __initdata fs_protocol = SIMPLE_FILE_SYSTEM_PROTOCOL;
>> >> > + static CHAR16 __initdata buffer[256];
>> >>
>> >> Did you intentionally halve the size of the buffer?
>> >
>> >
>> > Seeing the length field consists of two uint8, the maximum length of the
>> > path is 256.
>>
>> With
>>
>> #define DevicePathNodeLength(a) ( ((a)->Length[0]) | ((a)->Length[1] << 8) )
>>
>> I'd rather say 65536.
>
> Yes you're right. Can't do calculation when I'm having a cold. :-(
> But having 65536 is unrealistic.
Sure, I certainly don't mean the buffer to grow that large, but I'd
prefer if it didn't shrink compared to the original.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-10-30 15:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 12:57 [PATCH v2 0/5] xen: Use %*pb[l] for printing bitmaps Andrew Cooper
2018-10-22 12:57 ` [PATCH v2 1/5] xen/sched: Use %*pb[l] instead of cpumask_scn{, list}printf() Andrew Cooper
2018-10-22 12:57 ` [PATCH v2 2/5] xen/common: Use %*pb[l] instead of {cpu, node}mask_scn{, list}printf() Andrew Cooper
2018-10-25 10:56 ` Jan Beulich
2018-11-09 18:01 ` Andrew Cooper
2018-11-12 8:04 ` Jan Beulich
2018-10-22 12:58 ` [PATCH v2 3/5] xen/x86: Use %*pb[l] instead of cpumask_scn{, list}printf() Andrew Cooper
2018-10-25 10:56 ` Jan Beulich
2018-10-22 12:58 ` [PATCH v2 4/5] xen/bitmap: Drop all bitmap_scn{, list}printf() infrastructure Andrew Cooper
2018-10-22 12:58 ` [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch Andrew Cooper
2018-10-26 15:21 ` Jan Beulich
2018-10-30 15:32 ` Wei Liu
2018-10-30 15:40 ` Jan Beulich
2018-10-30 15:46 ` Wei Liu
2018-10-30 15:52 ` Jan Beulich [this message]
2018-10-30 15:32 ` Wei Liu
2018-11-16 17:45 ` [PATCH v3 " Andrew Cooper
2018-11-19 8:14 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BD87E5802000078001F6678@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.