From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Kevin Tian <kevin.tian@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 3/7] x86: make PV hypercall entry points work with !CONFIG_PV
Date: Mon, 05 Nov 2018 08:04:37 -0700 [thread overview]
Message-ID: <5BE05C0502000078001F8186@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <578d1dfbfc76230034b81fc79175a2181a62eac2.1541174103.git-series.wei.liu2@citrix.com>
>>> On 02.11.18 at 16:55, <wei.liu2@citrix.com> wrote:
> --- a/xen/arch/x86/x86_64/traps.c
> +++ b/xen/arch/x86/x86_64/traps.c
> @@ -298,8 +298,21 @@ static unsigned int write_stub_trampoline(
> }
>
> DEFINE_PER_CPU(struct stubs, stubs);
> +
> +#ifdef CONFIG_PV
> void lstar_enter(void);
> void cstar_enter(void);
> +#else
> +static inline void lstar_enter(void)
> +{
> + panic("%s called", __func__);
> +}
> +
> +static inline void cstar_enter(void)
> +{
> + panic("%s called", __func__);
> +}
> +#endif /* CONFIG_PV */
Do we really need two separate stubs (and two separate string literals)
here?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-05 15:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 15:55 [PATCH v3 0/7] Make CONFIG_PV work on x86 Wei Liu
2018-11-02 15:55 ` [PATCH v3 1/7] x86: make traps.c build with !CONFIG_PV Wei Liu
2018-11-05 14:07 ` Andrew Cooper
2018-11-02 15:55 ` [PATCH v3 2/7] x86/domctl: rework XEN_DOMCTL_{set, get}_address_size Wei Liu
2018-11-05 14:08 ` Andrew Cooper
2018-11-02 15:55 ` [PATCH v3 3/7] x86: make PV hypercall entry points work with !CONFIG_PV Wei Liu
2018-11-05 14:13 ` Andrew Cooper
2018-11-05 15:04 ` Jan Beulich [this message]
2018-11-05 15:48 ` Wei Liu
2018-11-05 15:49 ` Andrew Cooper
2018-11-05 15:51 ` Wei Liu
2018-11-05 16:11 ` Jan Beulich
2018-11-08 15:33 ` Wei Liu
2018-11-08 15:36 ` Andrew Cooper
2018-11-08 15:49 ` Jan Beulich
2018-11-08 16:09 ` Wei Liu
2018-11-08 16:22 ` Jan Beulich
2018-11-08 16:42 ` Wei Liu
2018-11-08 15:39 ` Jan Beulich
2018-11-08 15:49 ` Wei Liu
2018-11-02 15:55 ` [PATCH v3 4/7] x86: rearrange x86_64/entry.S Wei Liu
2018-11-05 14:20 ` Andrew Cooper
2018-11-02 15:55 ` [PATCH v3 5/7] x86: make entry point code build when !CONFIG_PV Wei Liu
2018-11-05 14:33 ` Andrew Cooper
2018-11-05 17:08 ` Wei Liu
2018-11-05 17:10 ` Andrew Cooper
2018-11-02 15:55 ` [PATCH v3 6/7] x86: expose CONFIG_PV Wei Liu
2018-11-02 15:55 ` [PATCH v3 7/7] x86: update help string for CONFIG_HVM Wei Liu
2018-11-05 15:20 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE05C0502000078001F8186@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.