From: Programmingkid <programmingkidx@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode
Date: Mon, 18 Jun 2018 18:24:25 -0400 [thread overview]
Message-ID: <5BE60DE6-10C2-4B62-B34D-50F6C014EE7A@gmail.com> (raw)
In-Reply-To: <CAFEAcA9F1sTX_9b5PJL61K5eRsP9XoY3KKje_4CNh71JKiw39w@mail.gmail.com>
On Jun 18, 2018, at 7:18 AM, Peter Maydell wrote:
> On 8 June 2018 at 21:01, John Arbuckle <programmingkidx@gmail.com> wrote:
>> Fix the cocoa front-end to correctly be able to use absolute mode.
>>
>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>
> This commit message is insufficiently detailed, which makes
> it hard to review the patch. When you send patches, please
> can you provide commit messages which describe what the
> problem is, where the current code gets things wrong and
> why the changes fix the issue? It is painful to have to
> reverse-engineer your design from your code changes.
Sorry I will correct this problem now.
This should have been the commit message:
When using an usb-tablet device in QEMU, the Cocoa UI uses absolute mode code to handle mouse events. The absolute mode code does not correctly determine where QEMU's window is located. Tests indicate the current code thinks the window is located in the bottom left of the screen. This makes grabbing and ungrabbing happen at the wrong place. This patch fixes this problem by making mouse grabs happen only in the window and mouse ungrabs happen only when the mouse is moved outside the window.
next prev parent reply other threads:[~2018-06-18 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 20:01 [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode John Arbuckle
2018-06-18 11:18 ` Peter Maydell
2018-06-18 22:24 ` Programmingkid [this message]
2018-07-01 19:24 ` Peter Maydell
2018-07-01 19:26 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE60DE6-10C2-4B62-B34D-50F6C014EE7A@gmail.com \
--to=programmingkidx@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.