From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list Date: Mon, 12 Nov 2018 05:40:21 -0700 Message-ID: <5BE974B502000078001FAF6F@prv1-mh.provo.novell.com> References: <20181109172250.12894-1-roger.pau@citrix.com> <20181109172250.12894-2-roger.pau@citrix.com> <5BE955D502000078001FAC06@prv1-mh.provo.novell.com> <20181112114909.rovrjxp2ynrlgx2n@mac.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gMBW0-0000r0-HI for xen-devel@lists.xenproject.org; Mon, 12 Nov 2018 12:40:28 +0000 In-Reply-To: <20181112114909.rovrjxp2ynrlgx2n@mac.citrite.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDEyLjExLjE4IGF0IDEyOjQ5LCA8cm9nZXIucGF1QGNpdHJpeC5jb20+IHdyb3RlOgo+ IE9uIE1vbiwgTm92IDEyLCAyMDE4IGF0IDAzOjI4OjM3QU0gLTA3MDAsIEphbiBCZXVsaWNoIHdy b3RlOgo+PiA+Pj4gT24gMDkuMTEuMTggYXQgMTg6MjIsIDxyb2dlci5wYXVAY2l0cml4LmNvbT4g d3JvdGU6Cj4+ID4gICAgICBmb3IgKCBpID0gMDsgaSA8IHB2aF9pbmZvLT5ucl9tb2R1bGVzOyBp KysgKQo+PiA+ICAgICAgewo+PiA+ICAgICAgICAgIEJVR19PTihlbnRyeVtpXS5wYWRkciA+PiAz Mik7Cj4+ID4gICAgICAgICAgQlVHX09OKGVudHJ5W2ldLmNtZGxpbmVfcGFkZHIgPj4gMzIpOwo+ PiA+ICAKPj4gPiAtICAgICAgICBtb2RbaV0ubW9kX3N0YXJ0ID0gZW50cnlbaV0ucGFkZHI7Cj4+ ID4gLSAgICAgICAgbW9kW2ldLm1vZF9lbmQgICA9IGVudHJ5W2ldLnBhZGRyICsgZW50cnlbaV0u c2l6ZTsKPj4gPiAtICAgICAgICBtb2RbaV0uc3RyaW5nICAgID0gZW50cnlbaV0uY21kbGluZV9w YWRkcjsKPj4gPiArICAgICAgICBwdmhfbWJpX21vZHNbaV0ubW9kX3N0YXJ0ID0gZW50cnlbaV0u cGFkZHI7Cj4+ID4gKyAgICAgICAgcHZoX21iaV9tb2RzW2ldLm1vZF9lbmQgICA9IGVudHJ5W2ld LnBhZGRyICsgZW50cnlbaV0uc2l6ZTsKPj4gPiArICAgICAgICBwdmhfbWJpX21vZHNbaV0uc3Ry aW5nICAgID0gZW50cnlbaV0uY21kbGluZV9wYWRkcjsKPj4gPiAgICAgIH0KPj4gPiAgCj4+ID4g ICAgICBCVUdfT04oIXB2aF9pbmZvLT5yc2RwX3BhZGRyKTsKPj4gPiAgICAgIHJzZHBfaGludCA9 IHB2aF9pbmZvLT5yc2RwX3BhZGRyOwo+PiA+ICsKPj4gPiArICAgICptYmkgPSAmcHZoX21iaTsK Pj4gPiArICAgICptb2QgPSBwdmhfbWJpX21vZHM7Cj4+IAo+PiBBbmQgdGhlcmUgYXJlIG5vIF9f dmEoKSB1c2VzIG9yIGFsaWtlIGdldHRpbmcgYWRkZWQgaGVyZSAobm90IHRoYXQKPj4gaXQgd291 bGQgbWFrZSBhbnkgc2Vuc2UgZm9yIHN0YXRpYyB2YXJpYWJsZXMsIGkuZS4gdGhpbmdzIHNpdHRp bmcgaW5zaWRlCj4+IHRoZSBYZW4gaW1hZ2UpLgo+IAo+IE5vLCBfX3ZhIHdhcyBjdXJyZW50bHkg dXNlZCBieSBfX3N0YXJ0X3hlbiBpbiBvcmRlciB0byBnZXQgdGhlIHZpcnR1YWwKPiBhZGRyZXNz IG9mIHRoZSBtb2R1bGUgbGlzdCAoX192YShtYmktPm1vZHNfYWRkcikpLCB3aGljaCBiZWNvbWVz IHN0YWxlCj4gYWZ0ZXIgcmVsb2NhdGluZyBYZW4gaXRzZWxmIGJlY2F1c2UgaW4gdGhlIFBWSCBj YXNlIHRoZSBtb2RzX2FkZHJzCj4gcG9pbnRzIHRvIGEgcGh5c2ljYWwgYWRkcmVzcyBpbiB0aGUg LmluaXQgc2VjdGlvbiBvZiB0aGUgWGVuIGltYWdlLgoKU28gYWl1aSB5b3UgcmVmZXIgdG8gdGhp cyBodW5rOgoKLS0tIGEveGVuL2FyY2gveDg2L3NldHVwLmMKKysrIGIveGVuL2FyY2gveDg2L3Nl dHVwLmMKQEAgLTcxOSwxMiArNzE5LDEzIEBAIHZvaWQgX19pbml0IG5vcmV0dXJuIF9fc3RhcnRf eGVuKHVuc2lnbmVkIGxvbmcgbWJpX3ApCiAgICAgICAgICAqLwogICAgICAgICBvcHRfY29uc29s ZV94ZW4gPSAtMTsKICAgICAgICAgQVNTRVJUKG1iaV9wID09IDApOwotICAgICAgICBtYmkgPSBw dmhfaW5pdCgpOworICAgICAgICBwdmhfaW5pdCgmbWJpLCAmbW9kKTsKICAgICB9CiAgICAgZWxz ZQorICAgIHsKICAgICAgICAgbWJpID0gX192YShtYmlfcCk7Ci0KLSAgICBtb2QgPSBfX3ZhKG1i aS0+bW9kc19hZGRyKTsKKyAgICAgICAgbW9kID0gX192YShtYmktPm1vZHNfYWRkcik7CisgICAg fQogCiAgICAgbG9hZGVyID0gKG1iaS0+ZmxhZ3MgJiBNQklfTE9BREVSTkFNRSkKICAgICAgICAg PyAoY2hhciAqKV9fdmEobWJpLT5ib290X2xvYWRlcl9uYW1lKSA6ICJ1bmtub3duIjsKCldoaWNo IGluZGVlZCBieXBhc3NlcyB0aGUgcGFzc2luZyB0aHJvdWdoIF9fdmEoKSBmb3IgbW9kc19hZGRy LApidXQgdGhlIGxhc3QgcGFyYWdyYXBoIG9mIHRoZSBkZXNjcmlwdGlvbiBzdWdnZXN0cyB0aGF0 IHlvdSBhbHNvCmFsdGVyIGhvdyBtYmkgZ2V0cyBoYW5kbGVkLCB3aGljaCBpcyBwZXJoYXBzIHBh cnQgb2YgbXkgY29uZnVzaW9uLgoKPj4gPiAtLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2d1ZXN0 L3B2aC1ib290LmgKPj4gPiArKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2d1ZXN0L3B2aC1ib290 LmgKPj4gPiBAQCAtMjUsMTcgKzI1LDE2IEBACj4+ID4gIAo+PiA+ICBleHRlcm4gYm9vbCBwdmhf Ym9vdDsKPj4gPiAgCj4+ID4gLW11bHRpYm9vdF9pbmZvX3QgKnB2aF9pbml0KHZvaWQpOwo+PiA+ ICt2b2lkIHB2aF9pbml0KG11bHRpYm9vdF9pbmZvX3QgKiptYmksIG1vZHVsZV90ICoqbW9kKTsK Pj4gPiAgdm9pZCBwdmhfcHJpbnRfaW5mbyh2b2lkKTsKPj4gPiAgCj4+ID4gICNlbHNlCj4+ID4g IAo+PiA+ICAjZGVmaW5lIHB2aF9ib290IDAKPj4gPiAgCj4+ID4gLXN0YXRpYyBpbmxpbmUgbXVs dGlib290X2luZm9fdCAqcHZoX2luaXQodm9pZCkKPj4gPiArc3RhdGljIGlubGluZSB2b2lkICpw dmhfaW5pdChtdWx0aWJvb3RfaW5mb190ICoqbWJpLCBtb2R1bGVfdCAqKm1vZCkKPj4gPiAgewo+ PiA+ICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7Cj4+ID4gLSAgICByZXR1cm4gTlVMTDsKPj4g PiAgfQo+PiAKPj4gUGxlYXNlIGRvbid0IHJlbW92ZSB0aGUgcmV0dXJuIHN0YXRlbWVudC4gT3Ig d2FpdCAtIGRvbid0IHlvdQo+PiBtZWFuIHRoZSBmdW5jdGlvbiB0byByZXR1cm4gInZvaWQiIHJh dGhlciB0aGFuICJ2b2lkICoiPwo+IAo+IFllcywgdGhpcyBpcyBhIG1pc3Rha2UsIHBsZWFzZSBz ZWUgdjIgb2YgdGhpcyBwYXRjaCB3aGljaCBpcyBhbHJlYWR5Cj4gb24gdGhlIGxpc3QuCgpPaCwg SSBzZWUuIEkgZGlkbid0IGV2ZW4gbm90aWNlIHRoZSB2MiBpbiB0aGUgdGl0bGUgLSBpdCBiZWlu ZyBhIHN0YW5kYWxvbmUKMS8yIHBhdGNoLCBJIHRob3VnaHQgdGhpcyB3YXMgYSBtYWlsaW5nIGFy dGlmYWN0LiAgVGhlIG1vcmUgdGhhdCBpdCBhbHNvCmRvZXNuJ3QgbGlzdCB3aGF0IGhhcyBjaGFu Z2VkIGluIHYyLgoKSmFuCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw=