From: "Jan Beulich" <JBeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen: only clobber multicall elements without error
Date: Mon, 26 Nov 2018 03:58:14 -0700 [thread overview]
Message-ID: <5BFBD1C602000078001FFE09@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20181123132516.28681-1-jgross@suse.com>
>>> On 23.11.18 at 14:25, <jgross@suse.com> wrote:
> In debug builds the hypervisor will deliberately clobber processed
> elements of the multicall structure. In order to ease diagnostic data
> printout in the affected guest only clobber elements which didn't
> return an error.
Besides what Andrew has said such a relaxation reduces
the guarding against bad guest side code. If a guest really
wishes to produce diagnostics, I think it should go to the
lengths of copying arguments (if they can't be re-calculated
anyway). Suppressing the clobbering in more cases merely
invites guests to read the arguments after the call, which
they simply should not do. Not clobbering the values in
release builds is a performance choice, and we ought to be
allowed to change our opinion regarding this implementation
detail at any point in time.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-26 10:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 13:25 [PATCH] xen: only clobber multicall elements without error Juergen Gross
2018-11-23 13:28 ` Andrew Cooper
2018-11-23 13:40 ` Juergen Gross
2018-11-26 10:58 ` Jan Beulich [this message]
2018-11-26 14:54 ` Ian Jackson
2018-11-26 15:25 ` Juergen Gross
2018-11-26 15:40 ` Ian Jackson
[not found] ` <5BFBD1C602000078001FFE09@suse.com>
2018-11-26 13:52 ` Juergen Gross
2018-11-26 14:01 ` Jan Beulich
[not found] ` <5BFBFCD3020000780020004F@suse.com>
2018-11-26 14:23 ` Juergen Gross
2018-11-26 14:58 ` Jan Beulich
[not found] ` <5BFC0A1302000078002000E1@suse.com>
[not found] ` <06592737*411f*d518*d972*6b4cdc704d9b@suse.com>
2018-11-26 15:29 ` Juergen Gross
2018-11-26 16:01 ` Julien Grall
2018-11-26 16:17 ` Juergen Gross
2018-11-26 16:50 ` Jan Beulich
[not found] ` <5BFC2462020000780020022A@suse.com>
2018-11-27 7:37 ` Juergen Gross
2018-11-27 9:24 ` Jan Beulich
2018-11-26 16:51 Julien Grall
2018-11-27 7:34 Juergen Gross
2018-11-27 9:16 Julien Grall
2018-11-27 9:25 Juergen Gross
2018-11-27 9:28 Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BFBD1C602000078001FFE09@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.