From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] controllers/cpuacct.sh: Fix timeout for cpuacct.sh
Date: Thu, 20 Dec 2018 14:05:29 +0800 [thread overview]
Message-ID: <5C1B3129.8090806@cn.fujitsu.com> (raw)
In-Reply-To: <1544087108-5717-1-git-send-email-yangx.jy@cn.fujitsu.com>
Hi,
Ping :-)
Best Regards,
Xiao Yang
On 2018/12/06 17:05, Xiao Yang wrote:
> With commit fbea02a, cpuacct.sh always gets timeout because wait
> command tries to wait all background processes including the timeout
> process. We should just wait the processes created for test.
>
> e.g. running cpuacct_1_1 gets the following timeout:
> -----------------------------------------------------------
> cpuacct 1 TINFO: timeout per run is 0h 5m 0s
> cpuacct 1 TINFO: cpuacct:
> cpuacct 1 TINFO: Creating 1 subgroups each with 1 processes
> cpuacct 1 TBROK: test killed, timeout!
> -----------------------------------------------------------
>
> Fixes: fbea02a("lib/tst_test.sh: setup timeout per test run for the shell tests")
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> testcases/kernel/controllers/cpuacct/cpuacct.sh | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/controllers/cpuacct/cpuacct.sh b/testcases/kernel/controllers/cpuacct/cpuacct.sh
> index edd4a98..5e90b05 100755
> --- a/testcases/kernel/controllers/cpuacct/cpuacct.sh
> +++ b/testcases/kernel/controllers/cpuacct/cpuacct.sh
> @@ -41,6 +41,7 @@ TST_TESTFUNC=do_test
> TST_POS_ARGS=2
> TST_USAGE=usage
> TST_NEEDS_ROOT=1
> +TST_NEEDS_TMPDIR=1
>
> . tst_test.sh
>
> @@ -114,10 +115,12 @@ do_test()
> for i in `seq 1 $max`; do
> for j in `seq 1 $nbprocess`; do
> cpuacct_task $testpath/subgroup_$i/tasks &
> + echo $! >> task_pids
> done
> done
>
> - wait
> + for pid in $(cat task_pids); do wait $pid; done
> + rm -f task_pids
>
> acc=0
> fails=0
next prev parent reply other threads:[~2018-12-20 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 9:05 [LTP] [PATCH] controllers/cpuacct.sh: Fix timeout for cpuacct.sh Xiao Yang
2018-12-20 6:05 ` Xiao Yang [this message]
2018-12-20 14:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C1B3129.8090806@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.