From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A650C43387 for ; Wed, 9 Jan 2019 10:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 227DD21738 for ; Wed, 9 Jan 2019 10:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729958AbfAIK3d (ORCPT ); Wed, 9 Jan 2019 05:29:33 -0500 Received: from mga14.intel.com ([192.55.52.115]:62736 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729222AbfAIK3c (ORCPT ); Wed, 9 Jan 2019 05:29:32 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 02:29:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,457,1539673200"; d="scan'208";a="106845948" Received: from unknown (HELO [10.239.13.114]) ([10.239.13.114]) by orsmga006.jf.intel.com with ESMTP; 09 Jan 2019 02:29:30 -0800 Message-ID: <5C35CE55.6030200@intel.com> Date: Wed, 09 Jan 2019 18:35:01 +0800 From: Wei Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Christian Borntraeger , virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, mst@redhat.com, cohuck@redhat.com CC: pbonzini@redhat.com, dgilbert@redhat.com, pasic@linux.ibm.com Subject: Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation References: <1546844466-38079-1-git-send-email-wei.w.wang@intel.com> <1546844466-38079-2-git-send-email-wei.w.wang@intel.com> <4ea022d4-6b89-b481-5747-871e154dd21a@de.ibm.com> <5C343688.2060609@intel.com> <20f5fb20-612a-fe37-c5e1-af5ecb98f5d3@de.ibm.com> In-Reply-To: <20f5fb20-612a-fe37-c5e1-af5ecb98f5d3@de.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2019 04:46 PM, Christian Borntraeger wrote: > > On 08.01.2019 06:35, Wei Wang wrote: >> On 01/07/2019 09:49 PM, Christian Borntraeger wrote: >>> On 07.01.2019 08:01, Wei Wang wrote: >>>> virtio-ccw has deadlock issues with reading the config space inside the >>>> interrupt context, so we tweak the virtballoon_changed implementation >>>> by moving the config read operations into the related workqueue contexts. >>>> The config_read_bitmap is used as a flag to the workqueue callbacks >>>> about the related config fields that need to be read. >>>> >>>> The cmd_id_received is also renamed to cmd_id_received_cache, and >>>> the value should be obtained via virtio_balloon_cmd_id_received. >>>> >>>> Reported-by: Christian Borntraeger >>>> Signed-off-by: Wei Wang >>>> Reviewed-by: Cornelia Huck >>>> Reviewed-by: Halil Pasic >>> Together with >>> virtio_pci: use queue idx instead of array idx to set up the vq >>> virtio: don't allocate vqs when names[i] = NULL >>> >>> Tested-by: Christian Borntraeger >> OK. I don't plan to send a new version of the above patches as no changes needed so far. >> >> Michael, if the above two patches look good to you, please help add the related tested-by >> and reviewed-by tags. Thanks. > Can we also make sure that > > virtio_pci: use queue idx instead of array idx to set up the vq > virtio: don't allocate vqs when names[i] = NULL > > also land in stable? > You could also send the request to stable after it gets merged to Linus' tree. The stable review committee will decide whether to take it. Please see Option 2: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html Best, Wei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5298-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 3B6CC985CDD for ; Wed, 9 Jan 2019 10:29:34 +0000 (UTC) Message-ID: <5C35CE55.6030200@intel.com> Date: Wed, 09 Jan 2019 18:35:01 +0800 From: Wei Wang MIME-Version: 1.0 References: <1546844466-38079-1-git-send-email-wei.w.wang@intel.com> <1546844466-38079-2-git-send-email-wei.w.wang@intel.com> <4ea022d4-6b89-b481-5747-871e154dd21a@de.ibm.com> <5C343688.2060609@intel.com> <20f5fb20-612a-fe37-c5e1-af5ecb98f5d3@de.ibm.com> In-Reply-To: <20f5fb20-612a-fe37-c5e1-af5ecb98f5d3@de.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation To: Christian Borntraeger , virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, mst@redhat.com, cohuck@redhat.com Cc: pbonzini@redhat.com, dgilbert@redhat.com, pasic@linux.ibm.com List-ID: On 01/08/2019 04:46 PM, Christian Borntraeger wrote: > > On 08.01.2019 06:35, Wei Wang wrote: >> On 01/07/2019 09:49 PM, Christian Borntraeger wrote: >>> On 07.01.2019 08:01, Wei Wang wrote: >>>> virtio-ccw has deadlock issues with reading the config space inside the >>>> interrupt context, so we tweak the virtballoon_changed implementation >>>> by moving the config read operations into the related workqueue contexts. >>>> The config_read_bitmap is used as a flag to the workqueue callbacks >>>> about the related config fields that need to be read. >>>> >>>> The cmd_id_received is also renamed to cmd_id_received_cache, and >>>> the value should be obtained via virtio_balloon_cmd_id_received. >>>> >>>> Reported-by: Christian Borntraeger >>>> Signed-off-by: Wei Wang >>>> Reviewed-by: Cornelia Huck >>>> Reviewed-by: Halil Pasic >>> Together with >>> virtio_pci: use queue idx instead of array idx to set up the vq >>> virtio: don't allocate vqs when names[i] = NULL >>> >>> Tested-by: Christian Borntraeger >> OK. I don't plan to send a new version of the above patches as no changes needed so far. >> >> Michael, if the above two patches look good to you, please help add the related tested-by >> and reviewed-by tags. Thanks. > Can we also make sure that > > virtio_pci: use queue idx instead of array idx to set up the vq > virtio: don't allocate vqs when names[i] = NULL > > also land in stable? > You could also send the request to stable after it gets merged to Linus' tree. The stable review committee will decide whether to take it. Please see Option 2: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html Best, Wei --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org