From: Zhou Wang <wangzhou1@hisilicon.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-crypto@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator support
Date: Wed, 16 Jan 2019 22:12:47 +0800 [thread overview]
Message-ID: <5C3F3BDF.6070409@hisilicon.com> (raw)
In-Reply-To: <5C383908.4090107@hisilicon.com>
On 2019/1/11 14:34, Zhou Wang wrote:
> On 2019/1/11 14:08, Herbert Xu wrote:
>> On Sat, Dec 22, 2018 at 03:51:44PM +0800, Zhou Wang wrote:
>>>
>>> +static struct crypto_alg hisi_zip_zlib = {
>>> + .cra_name = "zlib-deflate",
>>> + .cra_flags = CRYPTO_ALG_TYPE_COMPRESS,
>>> + .cra_ctxsize = sizeof(struct hisi_zip_ctx),
>>> + .cra_priority = 300,
>>> + .cra_module = THIS_MODULE,
>>> + .cra_init = hisi_zip_alloc_comp_ctx,
>>> + .cra_exit = hisi_zip_free_comp_ctx,
>>> + .cra_u = {
>>> + .compress = {
>>> + .coa_compress = hisi_zip_compress,
>>> + .coa_decompress = hisi_zip_decompress
>>> + }
>>> + }
>>> +};
>>
>> Please do not add any new implementations using the compress
>> interface. You should either use scomp or acomp depending on
>> whether your driver is synchronous or async.
Hi Herbert,
A stupid question: how do we test scomp alg?
It seems we can not use general comp API, e.g. crypto_alloc_comp
to do this.
Could you give me any clue about this?
Best,
Zhou
>
> OK, current this driver only supports synchronous interface.
> Will fix it in v2.
>
> Thanks,
> Zhou
>
>>
>> Thanks,
>>
>
> _______________________________________________
> Linuxarm mailing list
> Linuxarm@huawei.com
> http://hulk.huawei.com/mailman/listinfo/linuxarm
>
> .
>
next prev parent reply other threads:[~2019-01-16 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 7:51 [PATCH 0/4] crypto: hisilicon: Add HiSilicon QM and ZIP controller driver Zhou Wang
2018-12-22 7:51 ` [PATCH 1/4] Documentation: Add debugfs doc for hisi_zip Zhou Wang
2018-12-22 7:51 ` [PATCH 2/4] crypto: hisilicon: Add queue management driver for HiSilicon QM module Zhou Wang
2018-12-22 7:51 ` [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator support Zhou Wang
2019-01-11 6:08 ` Herbert Xu
2019-01-11 6:34 ` Zhou Wang
2019-01-16 14:12 ` Zhou Wang [this message]
2019-01-18 4:55 ` Herbert Xu
2019-01-18 7:55 ` Zhou Wang
2019-01-18 10:09 ` Herbert Xu
2018-12-22 7:51 ` [PATCH 4/4] MAINTAINERS: add maintainer for HiSilicon QM and ZIP controller driver Zhou Wang
2019-01-10 6:30 ` [PATCH 0/4] crypto: hisilicon: Add " Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C3F3BDF.6070409@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.