From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Sander Eikelenboom <linux@eikelenboom.it>,
Julien Grall <julien.grall@arm.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Chao Gao <chao.gao@intel.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] iommu: specify page_count rather than page_order to iommu_map/unmap()...
Date: Mon, 21 Jan 2019 04:27:38 -0700 [thread overview]
Message-ID: <5C45ACAA020000780020FAF9@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20190118160328.10455-1-paul.durrant@citrix.com>
>>> On 18.01.19 at 17:03, <paul.durrant@citrix.com> wrote:
> ...and remove alignment assertions.
>
> Testing shows that certain callers of iommu_legacy_map/unmap() specify
> order > 0 ranges that are not order aligned thus causing one of the
> IS_ALIGNED() assertions to fire.
As said before - without a much better explanation of why the current
order-based model is unsuitable (so far I've been provided only vague
pointers into "somewhere in PVH Dom0 boot code" iirc) to understand
why it's undesirable to simply make those call sites obey to the current
requirements, I'm not happy to see us go this route.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-21 11:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 16:03 [PATCH] iommu: specify page_count rather than page_order to iommu_map/unmap() Paul Durrant
2019-01-18 16:06 ` Julien Grall
2019-01-18 16:09 ` Paul Durrant
2019-01-18 17:40 ` Andrew Cooper
2019-01-21 9:19 ` Paul Durrant
2019-01-21 11:27 ` Jan Beulich [this message]
2019-01-21 11:56 ` Paul Durrant
2019-01-21 12:04 ` Jan Beulich
2019-01-21 13:22 ` Paul Durrant
2019-01-22 10:46 ` Jan Beulich
2019-01-22 16:36 ` Paul Durrant
2019-01-22 18:23 ` Andrew Cooper
2019-01-23 10:42 ` Jan Beulich
2019-01-22 17:02 ` Roger Pau Monné
2019-01-23 10:47 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C45ACAA020000780020FAF9@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.gao@intel.com \
--cc=julien.grall@arm.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux@eikelenboom.it \
--cc=paul.durrant@citrix.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.