From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E0CC43381 for ; Tue, 19 Feb 2019 12:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1508A204EC for ; Tue, 19 Feb 2019 12:49:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bfs.de header.i=@bfs.de header.b="Pyldwsrr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728353AbfBSMtB (ORCPT ); Tue, 19 Feb 2019 07:49:01 -0500 Received: from mx01-fr.bfs.de ([193.174.231.67]:35002 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbfBSMtB (ORCPT ); Tue, 19 Feb 2019 07:49:01 -0500 X-Greylist: delayed 483 seconds by postgrey-1.27 at vger.kernel.org; Tue, 19 Feb 2019 07:49:00 EST Received: from mail-fr.bfs.de (mail-fr.bfs.de [10.177.18.200]) by mx01-fr.bfs.de (Postfix) with ESMTPS id E84D3202DA; Tue, 19 Feb 2019 13:40:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bfs.de; s=dkim201901; t=1550580051; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hZ6OX3fpVzFO2HLT/iO7nQCXLNla2fv7+VLzVj1YlnQ=; b=Pyldwsrr98iLKOfjkUwdwzqnc9D19bcC3sVb9dRpvFUIfYbOS7FR9U6G1bpQi5nwKjqXav FNAmDndHehPYmaroeKzZGu9674sBlDwTv7VHHfAiQU/kEHEbdVUProk3dAe12N2l395fRn AC6wM9idBoa5cQIeFxdHHtHqF7F+0ySLiSzQgN1sW4UJaiIONZDfC8CDHMaYKrlEPMqfcx PLkUb4Jf6NRwTzYtcSqyCwvEAg6nsUadNbsW0wjLjLoAZYU1IZjEP54hbtkHZOevBtSVEf 9Ecec+efNvCF/GWZd5WpgfboWqmF2oYXpeSDtHibwA8TN0NijzSe2VKjT+1C4g== Received: from [134.92.181.33] (unknown [134.92.181.33]) by mail-fr.bfs.de (Postfix) with ESMTPS id 7DC21BEEBD; Tue, 19 Feb 2019 13:40:50 +0100 (CET) Message-ID: <5C6BF952.1000603@bfs.de> Date: Tue, 19 Feb 2019 13:40:50 +0100 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Mao Wenan CC: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() References: <20190219090635.134457-1-maowenan@huawei.com> In-Reply-To: <20190219090635.134457-1-maowenan@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: mx01-fr.bfs.de X-Spamd-Result: default: False [-3.10 / 7.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[wharms@bfs.de]; BAYES_HAM(-3.00)[100.00%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; NEURAL_HAM(-0.00)[-0.999,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am 19.02.2019 10:06, schrieb Mao Wenan: > This patch is to do code cleanup for ns83820_probe_phy(). > It deletes unused variable 'first' and commented out code. > > Signed-off-by: Mao Wenan > --- > v2->v3: delte unused variable 'first'; change subject from > "net: ns83820: drop pointless static qualifier in ns83820_probe_phy()" to > "net: ns83820: code cleanup for ns83820_probe_phy()". > drivers/net/ethernet/natsemi/ns83820.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c > index 958fced4dacf..955d34a6f0d8 100644 > --- a/drivers/net/ethernet/natsemi/ns83820.c > +++ b/drivers/net/ethernet/natsemi/ns83820.c > @@ -1869,34 +1869,16 @@ static unsigned ns83820_mii_write_reg(struct ns83820 *dev, unsigned phy, unsigne > static void ns83820_probe_phy(struct net_device *ndev) > { > struct ns83820 *dev = PRIV(ndev); > - static int first; > int i; > #define MII_PHYIDR1 0x02 > #define MII_PHYIDR2 0x03 > > -#if 0 > - if (!first) { > - unsigned tmp; > - ns83820_mii_read_reg(dev, 1, 0x09); > - ns83820_mii_write_reg(dev, 1, 0x10, 0x0d3e); > - > - tmp = ns83820_mii_read_reg(dev, 1, 0x00); > - ns83820_mii_write_reg(dev, 1, 0x00, tmp | 0x8000); > - udelay(1300); > - ns83820_mii_read_reg(dev, 1, 0x09); > - } > -#endif > - first = 1; > - > for (i=1; i<2; i++) { > int j; > unsigned a, b; > a = ns83820_mii_read_reg(dev, i, MII_PHYIDR1); > b = ns83820_mii_read_reg(dev, i, MII_PHYIDR2); > > - //printk("%s: phy %d: 0x%04x 0x%04x\n", > - // ndev->name, i, a, b); > - > for (j=0; j<0x16; j+=4) { > dprintk("%s: [0x%02x] %04x %04x %04x %04x\n", > ndev->name, j, From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Tue, 19 Feb 2019 12:40:50 +0000 Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() Message-Id: <5C6BF952.1000603@bfs.de> List-Id: References: <20190219090635.134457-1-maowenan@huawei.com> In-Reply-To: <20190219090635.134457-1-maowenan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mao Wenan Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, julia.lawall@lip6.fr Am 19.02.2019 10:06, schrieb Mao Wenan: > This patch is to do code cleanup for ns83820_probe_phy(). > It deletes unused variable 'first' and commented out code. > > Signed-off-by: Mao Wenan > --- > v2->v3: delte unused variable 'first'; change subject from > "net: ns83820: drop pointless static qualifier in ns83820_probe_phy()" to > "net: ns83820: code cleanup for ns83820_probe_phy()". > drivers/net/ethernet/natsemi/ns83820.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c > index 958fced4dacf..955d34a6f0d8 100644 > --- a/drivers/net/ethernet/natsemi/ns83820.c > +++ b/drivers/net/ethernet/natsemi/ns83820.c > @@ -1869,34 +1869,16 @@ static unsigned ns83820_mii_write_reg(struct ns83820 *dev, unsigned phy, unsigne > static void ns83820_probe_phy(struct net_device *ndev) > { > struct ns83820 *dev = PRIV(ndev); > - static int first; > int i; > #define MII_PHYIDR1 0x02 > #define MII_PHYIDR2 0x03 > > -#if 0 > - if (!first) { > - unsigned tmp; > - ns83820_mii_read_reg(dev, 1, 0x09); > - ns83820_mii_write_reg(dev, 1, 0x10, 0x0d3e); > - > - tmp = ns83820_mii_read_reg(dev, 1, 0x00); > - ns83820_mii_write_reg(dev, 1, 0x00, tmp | 0x8000); > - udelay(1300); > - ns83820_mii_read_reg(dev, 1, 0x09); > - } > -#endif > - first = 1; > - > for (i=1; i<2; i++) { > int j; > unsigned a, b; > a = ns83820_mii_read_reg(dev, i, MII_PHYIDR1); > b = ns83820_mii_read_reg(dev, i, MII_PHYIDR2); > > - //printk("%s: phy %d: 0x%04x 0x%04x\n", > - // ndev->name, i, a, b); > - > for (j=0; j<0x16; j+=4) { > dprintk("%s: [0x%02x] %04x %04x %04x %04x\n", > ndev->name, j,