From: "Jan Beulich" <JBeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Stefano Stabellini <stefanos@xilinx.com>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
george.dunlap@citrix.com, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>,
ian.jackson@citrix.com
Subject: Re: [PATCH v11 1/9] xen: use __UINTPTR_TYPE__ for uintptr_t
Date: Wed, 06 Mar 2019 00:47:50 -0700 [thread overview]
Message-ID: <5C7F7B26020000780021BF3A@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1551825512-8975-1-git-send-email-sstabellini@kernel.org>
>>> On 05.03.19 at 23:38, <sstabellini@kernel.org> wrote:
> Use __UINTPTR_TYPE__ to define uintptr_t. A later patch will make use of
> __PTRDIFF_TYPE__ to define ptrdiff_t.
>
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>
As before - I object to this change without the description supplying
both a reason (which would better also explain why the current way
of defining uintptr_t is detrimental) and a discussion why it is okay for
us to use __UINTPTR_TYPE__, despite (at least) gcc making this
available only under certain conditions (i.e. it would need to be
confirmed that whatever the conditions they're always met for us).
With this I think it is pretty clear that you would better have split
the original patch the other way around - the uncontroversial one
first, as that one now wouldn't apply without the one here.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-06 7:47 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 22:38 [PATCH v11 0/9] misc safety certification fixes Stefano Stabellini
2019-03-05 22:38 ` [PATCH v11 1/9] xen: use __UINTPTR_TYPE__ for uintptr_t Stefano Stabellini
2019-03-06 7:47 ` Jan Beulich [this message]
2019-03-06 21:16 ` Stefano Stabellini
2019-03-07 8:29 ` Jan Beulich
2019-03-07 15:43 ` Ian Jackson
2019-03-08 7:23 ` Jan Beulich
2019-03-08 14:18 ` Andrew Cooper
2019-03-08 15:19 ` Ian Jackson
2019-03-05 22:38 ` [PATCH v11 2/9] xen: introduce ptrdiff_t Stefano Stabellini
2019-03-05 22:38 ` [PATCH v11 3/9] xen: introduce DECLARE_BOUNDS Stefano Stabellini
2019-03-06 15:24 ` Jan Beulich
2019-03-06 20:55 ` Stefano Stabellini
2019-03-07 8:39 ` Jan Beulich
2019-03-07 14:16 ` Ian Jackson
2019-03-08 8:15 ` Jan Beulich
2019-03-08 15:31 ` Ian Jackson
2019-03-05 22:38 ` [PATCH v11 4/9] xen/arm: use DECLARE_BOUNDS as required Stefano Stabellini
2019-03-05 22:38 ` [PATCH v11 5/9] xen/x86: " Stefano Stabellini
2019-03-06 15:33 ` Jan Beulich
2019-03-06 21:05 ` Stefano Stabellini
2019-03-07 8:40 ` Jan Beulich
2019-03-07 14:02 ` Ian Jackson
2019-03-07 14:42 ` George Dunlap
2019-03-08 8:46 ` Jan Beulich
2019-03-08 8:55 ` Juergen Gross
2019-03-08 15:33 ` Ian Jackson
2019-03-06 15:48 ` Jan Beulich
2019-03-06 21:38 ` Stefano Stabellini
2019-03-07 8:50 ` Jan Beulich
2019-03-07 14:43 ` Ian Jackson
2019-03-08 8:22 ` Jan Beulich
2019-03-08 15:36 ` Ian Jackson
2019-03-08 15:57 ` Jan Beulich
2019-03-07 14:00 ` Ian Jackson
2019-03-08 15:43 ` Ian Jackson
2019-03-08 15:49 ` Jan Beulich
2019-03-05 22:38 ` [PATCH v11 6/9] xen/common: " Stefano Stabellini
2019-03-06 15:37 ` Jan Beulich
2019-03-06 21:08 ` Stefano Stabellini
2019-03-05 22:38 ` [PATCH v11 7/9] xen: " Stefano Stabellini
2019-03-05 22:38 ` [PATCH v11 8/9] xen: use DECLARE_BOUNDS in alternative.c Stefano Stabellini
2019-03-06 16:35 ` Jan Beulich
2019-03-06 21:38 ` Stefano Stabellini
2019-03-05 22:38 ` [PATCH v11 9/9] xen: explicit casts when DECLARE_BOUNDS cannot be used Stefano Stabellini
2019-03-07 11:40 ` Jan Beulich
2019-03-07 15:25 ` [PATCH v11 9/9] xen: explicit casts when DECLARE_BOUNDS cannot be used [and 1 more messages] Ian Jackson
2019-03-07 22:55 ` Stefano Stabellini
2019-03-08 15:39 ` [PATCH v11 9/9] xen: explicit casts when DECLARE_BOUNDS cannot be used [and 1 more messages] " Ian Jackson
2019-03-08 8:28 ` [PATCH v11 9/9] xen: explicit casts when DECLARE_BOUNDS cannot be used " Jan Beulich
2019-03-08 15:26 ` SRSL People... [PATCH v11 0/9] misc safety certification fixes Andrew Cooper
2019-03-08 15:44 ` Ian Jackson
2019-03-08 15:46 ` Jan Beulich
2019-03-08 20:14 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C7F7B26020000780021BF3A@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=stefanos@xilinx.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.