From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] x86/hvm: finish IOREQ correctly on completion path Date: Mon, 11 Mar 2019 05:32:50 -0600 Message-ID: <5C864762020000780021D2A9@prv1-mh.provo.novell.com> References: <1552080650-9168-1-git-send-email-igor.druzhinin@citrix.com> <71b6e1dee81b499a90e4b24b1989abf6@AMSPEX02CL02.citrite.net> <5C864097020000780021D280@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h3JAy-0005Md-H3 for xen-devel@lists.xenproject.org; Mon, 11 Mar 2019 11:33:00 +0000 In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Andrew Cooper , Roger Pau Monne , Wei Liu , xen-devel , Igor Druzhinin List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDExLjAzLjE5IGF0IDEyOjA5LCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+IHdyb3Rl Ogo+PiBGcm9tOiBKYW4gQmV1bGljaCBbbWFpbHRvOkpCZXVsaWNoQHN1c2UuY29tXQo+PiBTZW50 OiAxMSBNYXJjaCAyMDE5IDExOjA0Cj4+IAo+PiA+Pj4gT24gMTEuMDMuMTkgYXQgMTE6MzAsIDxQ YXVsLkR1cnJhbnRAY2l0cml4LmNvbT4gd3JvdGU6Cj4+ID4+IEZyb206IElnb3IgRHJ1emhpbmlu IFttYWlsdG86aWdvci5kcnV6aGluaW5AY2l0cml4LmNvbV0KPj4gPj4gU2VudDogMDggTWFyY2gg MjAxOSAyMTozMQo+PiA+Pgo+PiA+PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL2VtdWxhdGUuYwo+ PiA+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2VtdWxhdGUuYwo+PiA+PiBAQCAtMTA4MCw3ICsx MDgwLDE1IEBAIHN0YXRpYyBpbnQgbGluZWFyX3JlYWQodW5zaWduZWQgbG9uZyBhZGRyLCB1bnNp Z25lZCBpbnQgYnl0ZXMsIHZvaWQgKnBfZGF0YSwKPj4gPj4gICAgICAgICAgICAgICAgICAgICAg ICAgdWludDMyX3QgcGZlYywgc3RydWN0IGh2bV9lbXVsYXRlX2N0eHQgKmh2bWVtdWxfY3R4dCkK Pj4gPj4gIHsKPj4gPj4gICAgICBwYWdlZmF1bHRfaW5mb190IHBmaW5mbzsKPj4gPj4gLSAgICBp bnQgcmMgPSBodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcihwX2RhdGEsIGFkZHIsIGJ5dGVzLCBw ZmVjLCAmcGZpbmZvKTsKPj4gPj4gKyAgICBjb25zdCBzdHJ1Y3QgaHZtX3ZjcHVfaW8gKnZpbyA9 ICZjdXJyZW50LT5hcmNoLmh2bS5odm1faW87Cj4+ID4+ICsgICAgaW50IHJjID0gSFZNVFJBTlNf YmFkX2dmbl90b19tZm47Cj4+ID4+ICsKPj4gPj4gKyAgICAvKgo+PiA+PiArICAgICAqIElmIHRo ZSBtZW1vcnkgYWNjZXNzIGNhbiBiZSBoYW5kbGVkIGltbWVkaWF0ZWx5IC0gZG8gaXQsCj4+ID4+ ICsgICAgICogb3RoZXJ3aXNlIHJlLWVudGVyIGlvcmVxIGNvbXBsZXRpb24gcGF0aCB0byBwcm9w ZXJseSBjb25zdW1lIGl0Lgo+PiA+PiArICAgICAqLwo+PiA+PiArICAgIGlmICggIWh2bV9pb3Jl cV9uZWVkc19jb21wbGV0aW9uKCZ2aW8tPmlvX3JlcSkgKQo+PiA+PiArICAgICAgICByYyA9IGh2 bV9jb3B5X2Zyb21fZ3Vlc3RfbGluZWFyKHBfZGF0YSwgYWRkciwgYnl0ZXMsIHBmZWMsICZwZmlu Zm8pOwo+PiA+Cj4+ID4gSSB0aGluayB0aGlzIGlzIHRoZSByaWdodCB0aGluZyB0byBkbwo+PiAK Pj4gSXQncyBub3QsIGFuZCB0aGF0J3Mgd2h5IEkgaGFkIHdyaXR0ZW4gdGhhdCBlYXJsaWVyIGV4 cGxhbmF0aW9uIHdoaWNoCj4+IHlvdSB0aGVuIHJlc3BvbmRlZCB0byBzYXlpbmcgdGhhdCB0aGUg aXNzdWUgbmVlZHMgdG8gYmUgZGVhbHQgd2l0aAo+PiBieSBlbmZvcmNpbmcgYSBjb25zaXN0ZW50 IHZpZXcgb2YgTU1JTyAob3Igbm90KSBkdXJpbmcgaW5pdGlhbCB0cnkgYW5kCj4+IHJlcGxheS4g VGhhdCdzIF9ub3RfIHdoYXQgdGhlIGFib3ZlIGRvZXMgaW4gdGhlIGdlbmVyYWwgY2FzZTogSXQK Pj4gc2ltcGx5IGZvcmNlcyBfYWxsXyBhY2Nlc3NlcyBpbnRvIHRoZSBzbG93IHBhdGgsIHRodXMg cmUtaW50cm9kdWNpbmcKPj4gdGhlIHByb2JsZW0gb2YgcGFnZSBzdHJhZGRsaW5nIGFjY2Vzc2Vz IG5vdCBnZXR0aW5nIHJvdXRlZCBjb3JyZWN0bHkuCj4gCj4gV2h5PyBJZiB0aGVyZSBpcyBubyBw ZW5kaW5nIGlvcmVxIHRoZW4gd2h5IHdvdWxkIHRoZSBjYWxsIHRvIAo+IGh2bV9jb3B5X2Zyb21f Z3Vlc3RfbGluZWFyKCkgbm90IGhhcHBlbj8gQUZBSUNUIHZpby0+aW9fcmVxIHdpbGwgb25seSBi ZSAKPiB1cGRhdGVkIHdoZW4gaHZtZW11bF9kb19pbygpIGlzc3VlcyBhIG5ldyBpb3JlcSwgc28g dGhlIHRlc3QgYXBwZWFycyBjb3JyZWN0LiAKPiBIb3cgaXMgdGhhdCBfYWxsXyBhY2Nlc3MgZmFp bCB0aGlzIHRlc3Q/CgoiQWxsIiB3YXMgdG9vIGhlYXZ5LCBhcyBwZXIgdGhpcyBkaXNjdXNzaW9u OgoKPj4gRXZlbiB3b3JzZSwgaXQgZm9yY2VzIF9hbGxfIG1lbW9yeSBhY2Nlc3NlcyBieSB0aGUg aW5zbiB1bmRlcgo+PiBlbXVsYXRpb24gaW50byB0aGUgTU1JTyBwYXRoLiBXaGlsZSB0aGlzIHdv dWxkIGhhcHBlbiB0byBiZSBva2F5Cj4+IGZvciBhIFBVU0ggZnJvbSBNTUlPIChiZWNhdXNlIHRo ZSByZWFkIGNvbWVzIGZpcnN0LCBhbmQgaGVuY2UgdGhlCj4+IHdyaXRlIHdvdWxkIG5vIGxvbmdl ciBzZWUgYSBwZW5kaW5nIElPUkVRKSwgaXQncyB3cm9uZyBmb3IgKGFtb25nCj4+IG1hbnkgb3Ro ZXIgY2FzZXMpIGEgUE9QIHRvIE1NSU8sIGFzIHRoZSByZWFkIChmcm9tIHN0YWNrLCBpLmUuIFJB TSkKPj4gd2lsbCBiZSByZXBsYXllZCBmaXJzdCwgd2hpbGUgdGhlIElPUkVRIGlzIHN0aWxsIG1h cmtlZCBpbmNvbXBsZXRlLiBJJ2QKPj4gZXhwZWN0IHRoaXMgdG8gdHJpZ2dlciB0aGUgdmVyeSBk b21haW5fY3Jhc2goKSBpbiBodm1lbXVsX2RvX2lvKCkKPj4gdGhhdCB3YXMgYWxzbyB0cmlnZ2Vy aW5nIGJlY2F1c2Ugb2YgdGhlIFAyTSB0eXBlIGNoYW5nZSBiZWhpbmQgb3VyCj4+IGJhY2tzLgoK SSBzaG91bGQgaGF2ZSBzYWlkICJhbGwgYWNjZXNzZXMgcHJlY2VkaW5nIHRoZSBvbmUgcmVhbGx5 IGFjY2Vzc2luZwpNTUlPIi4gVXNpbmcgdGhlIHByb3ZpZGVkIGV4YW1wbGUgb2YgUE9QLCB0aGUg bGluZWFyX3JlYWQoKSBpbnZvY2F0aW9uCmR1cmluZyByZXBsYXkgKHRvIHJlYWQgdGhlIHN0YWNr KSB3aWxsIGZpbmQgYSBwZW5kaW5nIElPUkVRLCBhbmQgd3JvbmdseQpnbyB0aGUgTU1JTyBwYXRo LiBUaGlzIHdvdWxkLCBpbiB0aGlzIGV4YW1wbGUsIGJlIGNvcnJlY3Qgb25seSBmb3IKbGluZWFy X3dyaXRlKCkgdG8gZG8uIFNvIHRoZSBzdWdnZXN0ZWQgY2hhbmdlIGlzIGNvcnJlY3Qgb25seSBm b3IgYW55Cmluc24gYWNjZXNzaW5nIG5vIG1vcmUgdGhhbiBvbmUgbWVtb3J5IGxvY2F0aW9uIChp ZiB0aGVyZSdzIG5vIG1lbW9yeQphY2Nlc3MgdGhlbiBvZiBjb3Vyc2Ugd2Ugd29uJ3QgbWFrZSBp dCBoZXJlIGluIHRoZSBmaXJzdCBwbGFjZSkuCgpKYW4KCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==