From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 8F07B6C4E6 for ; Thu, 4 Apr 2019 09:31:20 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id x349VKBD000510 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 4 Apr 2019 02:31:20 -0700 (PDT) Received: from [128.224.162.194] (128.224.162.194) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Apr 2019 02:31:19 -0700 To: , References: <1552985080-65398-1-git-send-email-mingli.yu@windriver.com> From: "Yu, Mingli" Message-ID: <5CA5D023.9090802@windriver.com> Date: Thu, 4 Apr 2019 17:36:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1552985080-65398-1-git-send-email-mingli.yu@windriver.com> X-Originating-IP: [128.224.162.194] Subject: Re: [PATCH] gcc-sanitizers: fix -Werror=maybe-uninitialized issue X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 09:31:20 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Ping. Any comments here? Thanks, On 2019年03月19日 16:44, mingli.yu@windriver.com wrote: > From: Mingli Yu > > When DEBUG_BUILD = "1" added in local.conf, there > comes below build error when "bitbake gcc-sanitizers": > | ./../../../../../../../../work-shared/gcc-8.3.0-r0/gcc-8.3.0/libsanitizer/libbacktrace/../../libbacktrace/elf.c: In function 'elf_is_symlink': > | ../../../../../../../../../work-shared/gcc-8.3.0-r0/gcc-8.3.0/libsanitizer/libbacktrace/../../libbacktrace/elf.c:772:21: error: 'st.st_mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] > | return S_ISLNK (st.st_mode); > > Initialize st_mode member to fix the above issue. > > Signed-off-by: Mingli Yu > --- > meta/recipes-devtools/gcc/gcc-8.3.inc | 1 + > .../0041-elf.c-initialize-st_mode-member.patch | 33 ++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 meta/recipes-devtools/gcc/gcc-8.3/0041-elf.c-initialize-st_mode-member.patch > > diff --git a/meta/recipes-devtools/gcc/gcc-8.3.inc b/meta/recipes-devtools/gcc/gcc-8.3.inc > index f7bf257..3501325 100644 > --- a/meta/recipes-devtools/gcc/gcc-8.3.inc > +++ b/meta/recipes-devtools/gcc/gcc-8.3.inc > @@ -71,6 +71,7 @@ SRC_URI = "\ > file://0038-Re-introduce-spe-commandline-options.patch \ > file://0039-riscv-Disable-multilib-for-OE.patch \ > file://0040-powerpc-powerpc64-Add-support-for-musl-ldso.patch \ > + file://0041-elf.c-initialize-st_mode-member.patch \ > " > SRC_URI[md5sum] = "65b210b4bfe7e060051f799e0f994896" > SRC_URI[sha256sum] = "64baadfe6cc0f4947a84cb12d7f0dfaf45bb58b7e92461639596c21e02d97d2c" > diff --git a/meta/recipes-devtools/gcc/gcc-8.3/0041-elf.c-initialize-st_mode-member.patch b/meta/recipes-devtools/gcc/gcc-8.3/0041-elf.c-initialize-st_mode-member.patch > new file mode 100644 > index 0000000..8e80c4e > --- /dev/null > +++ b/meta/recipes-devtools/gcc/gcc-8.3/0041-elf.c-initialize-st_mode-member.patch > @@ -0,0 +1,33 @@ > +From 960f3e1f104192ceb80a97e665fadffda5285aab Mon Sep 17 00:00:00 2001 > +From: Mingli Yu > +Date: Tue, 19 Mar 2019 16:23:04 +0800 > +Subject: [PATCH] elf.c: initialize st_mode member > + > +Initialize st_mode member to fix the below > +build failure when -Og included in compiler flag. > +| ./../../../../../../../../work-shared/gcc-8.3.0-r0/gcc-8.3.0/libsanitizer/libbacktrace/../../libbacktrace/elf.c: In function 'elf_is_symlink': > +| ../../../../../../../../../work-shared/gcc-8.3.0-r0/gcc-8.3.0/libsanitizer/libbacktrace/../../libbacktrace/elf.c:772:21: error: 'st.st_mode' may be used uninitialized in this function [-Werror=maybe-uninitialized] > + return S_ISLNK (st.st_mode); > + > +Upstream-Status: Submitted[https://gcc.gnu.org/ml/gcc-patches/2019-03/msg00900.html] > + > +Signed-off-by: Mingli Yu > +--- > + libbacktrace/elf.c | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/libbacktrace/elf.c b/libbacktrace/elf.c > +index f4863f0..561bdc2 100644 > +--- a/libbacktrace/elf.c > ++++ b/libbacktrace/elf.c > +@@ -766,6 +766,7 @@ static int > + elf_is_symlink (const char *filename) > + { > + struct stat st; > ++ st.st_mode = 0; > + > + if (lstat (filename, &st) < 0) > + return 0; > +-- > +2.7.4 > + >